New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 712374 link

Starred by 1 user

Issue metadata

Status: Archived
Owner:
Closed: Apr 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

M58 beta all repair / validate fail - DUT's goto repair failed.

Project Member Reported by haddowk@chromium.org, Apr 17 2017

Issue description


When running Moblab M58 beta it seems like repair/validate always fails with "The host is in dev mode"

http://100.107.2.199/results/hosts/192.168.231.104/3820-repair/debug/autoserv.DEBUG


04/17 15:00:32.082 INFO |            repair:0479| No failed triggers, skipping repair:  Re-install the stable firmware via servo
04/17 15:00:32.082 INFO |            repair:0327| Verifying this condition: The host should not be in dev mode
04/17 15:00:32.083 DEBUG|          ssh_host:0284| Running (ssh) 'crossystem devsw_boot'
04/17 15:00:32.177 DEBUG|        base_utils:0299| [stdout] 1
04/17 15:00:32.178 ERROR|            repair:0332| Failed: The host should not be in dev mode
Traceback (most recent call last):
  File "/usr/local/autotest/client/common_lib/hosts/repair.py", line 329, in _verify_host
    self.verify(host)
  File "/usr/local/autotest/server/hosts/cros_repair.py", line 235, in verify
    raise hosts.AutoservVerifyError('The host is in dev mode')
AutoservVerifyError: The host is in dev mode
04/17 15:00:32.178 INFO |        server_job:0184| 	FAIL	----	verify.devmode	timestamp=1492466432	localtime=Apr 17 15:00:32	The host is in dev mode
04/17 15:00:32.179 INFO |            repair:0327| Verifying this condition: The stateful filesystems are writable
04/17 15:00:32.179 DEBUG|          ssh_host:0284| Running (ssh) 'touch /mnt/stateful_partition/writable_test && rm /mnt/stateful_partition/writable_test'
04/17 15:00:32.264 DEBUG|          ssh_host:0284| Running (ssh) 'touch /var/tmp/writable_test && rm /var/tmp/writable_test'
04/17 15:00:32.339 INFO |        server_job:0184| 	GOOD	----	verify.writable	timestamp=1492466432	localtime=Apr 17 15:00:32	

 
Cc: stephenlin@chromium.org
Cc: xixuan@chromium.org
Labels: -Pri-3 Pri-1
Looks like the change was introduced in 

https://chromium-review.googlesource.com/#/c/446662/

Adding Xixuan Wu to help understand why this might break moblab.

Comment 3 by xixuan@chromium.org, Apr 19 2017

I thought it fails a moblab host and got confused when I commented on that CL. Actually it fails the DUT internally connected to a moblab host, not a moblab host itself, right?


Correct the moblab is ok - but the DUT fails

Here is a provision log failure that shows the problem
http://100.107.2.199/results/hosts/192.168.231.100/1-provision/debug/autoserv.DEBUG

And this is the same DUT after I applied the fix to the moblab - not a provision but a verify job
http://100.107.2.199/results/hosts/192.168.231.100/9-verify/debug/autoserv.DEBUG
Project Member

Comment 5 by bugdroid1@chromium.org, Apr 25 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/ae09543f48be2016757de33f6c1aaf4967abdeeb

commit ae09543f48be2016757de33f6c1aaf4967abdeeb
Author: Keith Haddow <haddowk@chromium.org>
Date: Tue Apr 25 21:03:46 2017

[autotest] Add setting to allow devices to be in dev mode.

A new check was added to the cros device repair to ensure all
devices must not be in dev mode.  This does not apply to autotest
so add a config setting that moblab can use to bypass this repair
check.

TEST=dev build flashed to moblab and cts test run.
BUG= chromium:712374 

Change-Id: I455c3ca8b9a0a1b3bb1a04f3b94983d206e0e6ce
Reviewed-on: https://chromium-review.googlesource.com/480912
Commit-Ready: Keith Haddow <haddowk@chromium.org>
Tested-by: Keith Haddow <haddowk@chromium.org>
Reviewed-by: Keith Haddow <haddowk@chromium.org>
Reviewed-by: Michael Tang <ntang@chromium.org>

[modify] https://crrev.com/ae09543f48be2016757de33f6c1aaf4967abdeeb/moblab_config.ini
[modify] https://crrev.com/ae09543f48be2016757de33f6c1aaf4967abdeeb/server/hosts/cros_repair.py

Project Member

Comment 6 by bugdroid1@chromium.org, Apr 25 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/ae09543f48be2016757de33f6c1aaf4967abdeeb

commit ae09543f48be2016757de33f6c1aaf4967abdeeb
Author: Keith Haddow <haddowk@chromium.org>
Date: Tue Apr 25 21:03:46 2017

[autotest] Add setting to allow devices to be in dev mode.

A new check was added to the cros device repair to ensure all
devices must not be in dev mode.  This does not apply to autotest
so add a config setting that moblab can use to bypass this repair
check.

TEST=dev build flashed to moblab and cts test run.
BUG= chromium:712374 

Change-Id: I455c3ca8b9a0a1b3bb1a04f3b94983d206e0e6ce
Reviewed-on: https://chromium-review.googlesource.com/480912
Commit-Ready: Keith Haddow <haddowk@chromium.org>
Tested-by: Keith Haddow <haddowk@chromium.org>
Reviewed-by: Keith Haddow <haddowk@chromium.org>
Reviewed-by: Michael Tang <ntang@chromium.org>

[modify] https://crrev.com/ae09543f48be2016757de33f6c1aaf4967abdeeb/moblab_config.ini
[modify] https://crrev.com/ae09543f48be2016757de33f6c1aaf4967abdeeb/server/hosts/cros_repair.py

Status: Assigned (was: Untriaged)
Project Member

Comment 8 by bugdroid1@chromium.org, Apr 25 2017

Labels: merge-merged-release-R58-9334.B
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/6330969d9f5b113d3fde86bda0a15fb97dd94cf3

commit 6330969d9f5b113d3fde86bda0a15fb97dd94cf3
Author: Keith Haddow <haddowk@chromium.org>
Date: Tue Apr 25 23:45:35 2017

[autotest] Add setting to allow devices to be in dev mode.

A new check was added to the cros device repair to ensure all
devices must not be in dev mode.  This does not apply to autotest
so add a config setting that moblab can use to bypass this repair
check.

TEST=dev build flashed to moblab and cts test run.
BUG= chromium:712374 

Change-Id: I455c3ca8b9a0a1b3bb1a04f3b94983d206e0e6ce
Reviewed-on: https://chromium-review.googlesource.com/480912
Commit-Ready: Keith Haddow <haddowk@chromium.org>
Tested-by: Keith Haddow <haddowk@chromium.org>
Reviewed-by: Keith Haddow <haddowk@chromium.org>
Reviewed-by: Michael Tang <ntang@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/487076
Commit-Queue: Keith Haddow <haddowk@chromium.org>

[modify] https://crrev.com/6330969d9f5b113d3fde86bda0a15fb97dd94cf3/moblab_config.ini
[modify] https://crrev.com/6330969d9f5b113d3fde86bda0a15fb97dd94cf3/server/hosts/cros_repair.py

Project Member

Comment 9 by bugdroid1@chromium.org, Apr 25 2017

Labels: merge-merged-release-R59-9460.B
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/2f9c09093118e2235d52ff38f36dfaed8440fc83

commit 2f9c09093118e2235d52ff38f36dfaed8440fc83
Author: Keith Haddow <haddowk@chromium.org>
Date: Tue Apr 25 23:50:16 2017

[autotest] Add setting to allow devices to be in dev mode.

A new check was added to the cros device repair to ensure all
devices must not be in dev mode.  This does not apply to autotest
so add a config setting that moblab can use to bypass this repair
check.

TEST=dev build flashed to moblab and cts test run.
BUG= chromium:712374 

Change-Id: I455c3ca8b9a0a1b3bb1a04f3b94983d206e0e6ce
Reviewed-on: https://chromium-review.googlesource.com/480912
Commit-Ready: Keith Haddow <haddowk@chromium.org>
Tested-by: Keith Haddow <haddowk@chromium.org>
Reviewed-by: Keith Haddow <haddowk@chromium.org>
Reviewed-by: Michael Tang <ntang@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/487222
Commit-Queue: Keith Haddow <haddowk@chromium.org>

[modify] https://crrev.com/2f9c09093118e2235d52ff38f36dfaed8440fc83/moblab_config.ini
[modify] https://crrev.com/2f9c09093118e2235d52ff38f36dfaed8440fc83/server/hosts/cros_repair.py

Project Member

Comment 10 by bugdroid1@chromium.org, Apr 25 2017

Labels: merge-merged-release-R59-9460.B
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/2f9c09093118e2235d52ff38f36dfaed8440fc83

commit 2f9c09093118e2235d52ff38f36dfaed8440fc83
Author: Keith Haddow <haddowk@chromium.org>
Date: Tue Apr 25 23:50:16 2017

[autotest] Add setting to allow devices to be in dev mode.

A new check was added to the cros device repair to ensure all
devices must not be in dev mode.  This does not apply to autotest
so add a config setting that moblab can use to bypass this repair
check.

TEST=dev build flashed to moblab and cts test run.
BUG= chromium:712374 

Change-Id: I455c3ca8b9a0a1b3bb1a04f3b94983d206e0e6ce
Reviewed-on: https://chromium-review.googlesource.com/480912
Commit-Ready: Keith Haddow <haddowk@chromium.org>
Tested-by: Keith Haddow <haddowk@chromium.org>
Reviewed-by: Keith Haddow <haddowk@chromium.org>
Reviewed-by: Michael Tang <ntang@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/487222
Commit-Queue: Keith Haddow <haddowk@chromium.org>

[modify] https://crrev.com/2f9c09093118e2235d52ff38f36dfaed8440fc83/moblab_config.ini
[modify] https://crrev.com/2f9c09093118e2235d52ff38f36dfaed8440fc83/server/hosts/cros_repair.py

Status: Fixed (was: Assigned)

Comment 12 by dchan@google.com, May 30 2017

Labels: VerifyIn-60
Labels: VerifyIn-61

Comment 14 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Sign in to add a comment