Issue metadata
Sign in to add a comment
|
Stop sessions from flaring on startup before real changes occur |
||||||||||||||||||||||
Issue descriptionI'm suspicious this was a regression from https://codereview.chromium.org/2753753005. We try to delay sync initialization by ~9 seconds from Chrome launch. If a model type needs sync to be active it can flare. But we shouldn't be flaring immediately on all startups. I haven't tested this on any platforms other than Linux. I'd assume this is at least the case for all desktop. I'm worried this may a significant start up regression, may need to be merged into M59.
,
Apr 20 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e8227a0e1c5fc7f230fe575086e1816a4e9fa6ae commit e8227a0e1c5fc7f230fe575086e1816a4e9fa6ae Author: pnoland <pnoland@chromium.org> Date: Thu Apr 20 20:47:45 2017 [sync] Prevent sessions flare on startup SyncSessionsWebContents router triggered its flare for any notification it received, no matter what. This caused it to trigger a flare more or less immediately upon startup. This change caused the flare to trigger only if the notification is meaningful; i.e. it's for a valid tab's load completed event. This is a change from the past behavior, which wouldn't flare for tabs that shouldn't sync, like the new tab page, but would flare for any event type. R=skym@chromium.org BUG= 712372 Review-Url: https://codereview.chromium.org/2824073002 Cr-Commit-Position: refs/heads/master@{#466119} [modify] https://crrev.com/e8227a0e1c5fc7f230fe575086e1816a4e9fa6ae/chrome/browser/sync/sessions/browser_list_router_helper.cc [modify] https://crrev.com/e8227a0e1c5fc7f230fe575086e1816a4e9fa6ae/chrome/browser/sync/sessions/sync_sessions_router_tab_helper.cc [modify] https://crrev.com/e8227a0e1c5fc7f230fe575086e1816a4e9fa6ae/chrome/browser/sync/sessions/sync_sessions_router_tab_helper.h [modify] https://crrev.com/e8227a0e1c5fc7f230fe575086e1816a4e9fa6ae/chrome/browser/sync/sessions/sync_sessions_web_contents_router.cc [modify] https://crrev.com/e8227a0e1c5fc7f230fe575086e1816a4e9fa6ae/chrome/browser/sync/sessions/sync_sessions_web_contents_router.h [add] https://crrev.com/e8227a0e1c5fc7f230fe575086e1816a4e9fa6ae/chrome/browser/sync/sessions/sync_sessions_web_contents_router_unittest.cc [modify] https://crrev.com/e8227a0e1c5fc7f230fe575086e1816a4e9fa6ae/chrome/test/BUILD.gn [modify] https://crrev.com/e8227a0e1c5fc7f230fe575086e1816a4e9fa6ae/components/sync/model/syncable_service.h
,
Apr 21 2017
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by zea@chromium.org
, Apr 17 2017