New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 712366 link

Starred by 1 user
Status: Verified
Owner:
kathrelk...@chromium.org
Closed: Jul 2017
Cc:
█ krishna...@chromium.org
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Enterprise autotests failing due to MD settings changes

Project Member Reported by kathrelk...@chromium.org, Apr 17 2017 
Offshoot of  issue 694081 

The MD Settings page breaks the following Enterprise tests:
policy_AutoFillEnabled
policy_BlockThirdPartyCookies
policy_ChromeOsLockOnIdleSuspend
policy_SearchSuggestEnabled
policy_SpellCheckServiceEnabled

Fix should be:
1. disable this part of the autotests (short term)
2. make the setting values available through autotest_private (long term)

Comment 1 by kathrelk...@chromium.org, Apr 17 2017

Labels: ent-autotest

Comment 2 by kathrelk...@chromium.org, Apr 19 2017 

All of these tests (other than policy_ChromeOsLockOnIdleSuspend) do nothing besides check the setting value.  Since getting the setting values through autotest_private would require a rewrite of the existing code anyway, I'm going to delete these tests.

The policy_prefs_browsertest is sufficient for checking setting values.  If we later decide it's not, we could create a similarly organized autotest.  Either way, we lose nothing by deleting these tests.
Project Member

Comment 3 by bugdroid1@chromium.org, Apr 22 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/b41f374c38a9ac8f9b5813161588ce445eb571bb

commit b41f374c38a9ac8f9b5813161588ce445eb571bb
Author: Katherine Threlkeld <kathrelkeld@chromium.org>
Date: Sat Apr 22 04:57:53 2017

[Autotest] Remove ebuild entry for deleted tests.

As part of deleting several autotests, remove their ebuild entries.

TEST=None
BUG= chromium:712366 

Change-Id: I62e5fd777d1535fe520bb6c0c86cf5e8915c0209
Reviewed-on: https://chromium-review.googlesource.com/482185
Commit-Ready: Katherine Threlkeld <kathrelkeld@chromium.org>
Tested-by: Katherine Threlkeld <kathrelkeld@chromium.org>
Reviewed-by: Krishna Gavini <krishnargv@chromium.org>

[modify] https://crrev.com/b41f374c38a9ac8f9b5813161588ce445eb571bb/chromeos-base/autotest-chrome/autotest-chrome-9999.ebuild
Project Member

Comment 4 by bugdroid1@chromium.org, Apr 25 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/1400dd77037bf9ee47f86feb81f7d314069f3d58

commit 1400dd77037bf9ee47f86feb81f7d314069f3d58
Author: Katherine Threlkeld <kathrelkeld@chromium.org>
Date: Tue Apr 25 21:03:49 2017

[Autotest] Remove policy_ tests failing due to settings page changes.

See bug for context.  Remove tests which only check the settings page
value and not Chrome OS behavior.  Remove code which scrapes the
settings page - it doesn't work with MD settings page and we should
get rid of this UI dependency.

TEST=ran remaining test
BUG= chromium:712366 
CQ-DEPEND=CL:482185

Change-Id: I9ade14ef949a16896609afc277fe591e007f02b5
Reviewed-on: https://chromium-review.googlesource.com/481925
Commit-Ready: Katherine Threlkeld <kathrelkeld@chromium.org>
Tested-by: Katherine Threlkeld <kathrelkeld@chromium.org>
Reviewed-by: Krishna Gavini <krishnargv@chromium.org>

[delete] https://crrev.com/8a93beb6aecbd0c4aaa1335b14c0e611cbd30bd4/client/site_tests/policy_AutoFillEnabled/control.notset_enable
[delete] https://crrev.com/8a93beb6aecbd0c4aaa1335b14c0e611cbd30bd4/client/site_tests/policy_SearchSuggestEnabled/control
[delete] https://crrev.com/8a93beb6aecbd0c4aaa1335b14c0e611cbd30bd4/client/site_tests/policy_BlockThirdPartyCookies/control
[delete] https://crrev.com/8a93beb6aecbd0c4aaa1335b14c0e611cbd30bd4/client/site_tests/policy_SpellCheckServiceEnabled/control.true_enable
[delete] https://crrev.com/8a93beb6aecbd0c4aaa1335b14c0e611cbd30bd4/client/site_tests/policy_SpellCheckServiceEnabled/src/Makefile
[delete] https://crrev.com/8a93beb6aecbd0c4aaa1335b14c0e611cbd30bd4/client/site_tests/policy_BlockThirdPartyCookies/control.notset_allow
[modify] https://crrev.com/1400dd77037bf9ee47f86feb81f7d314069f3d58/client/cros/enterprise/enterprise_policy_base.py
[delete] https://crrev.com/8a93beb6aecbd0c4aaa1335b14c0e611cbd30bd4/client/site_tests/policy_BlockThirdPartyCookies/control.false_allow
[delete] https://crrev.com/8a93beb6aecbd0c4aaa1335b14c0e611cbd30bd4/client/site_tests/policy_AutoFillEnabled/policy_AutoFillEnabled.py
[delete] https://crrev.com/8a93beb6aecbd0c4aaa1335b14c0e611cbd30bd4/client/site_tests/policy_BlockThirdPartyCookies/policy_BlockThirdPartyCookies.py
[delete] https://crrev.com/8a93beb6aecbd0c4aaa1335b14c0e611cbd30bd4/client/site_tests/policy_SearchSuggestEnabled/control.false_disable
[delete] https://crrev.com/8a93beb6aecbd0c4aaa1335b14c0e611cbd30bd4/client/site_tests/policy_SpellCheckServiceEnabled/control.false_disable
[delete] https://crrev.com/8a93beb6aecbd0c4aaa1335b14c0e611cbd30bd4/client/site_tests/policy_BlockThirdPartyCookies/control.true_block
[delete] https://crrev.com/8a93beb6aecbd0c4aaa1335b14c0e611cbd30bd4/client/site_tests/policy_SearchSuggestEnabled/control.true_enable
[delete] https://crrev.com/8a93beb6aecbd0c4aaa1335b14c0e611cbd30bd4/client/site_tests/policy_AutoFillEnabled/control.false_disable
[delete] https://crrev.com/8a93beb6aecbd0c4aaa1335b14c0e611cbd30bd4/client/site_tests/policy_AutoFillEnabled/control
[delete] https://crrev.com/8a93beb6aecbd0c4aaa1335b14c0e611cbd30bd4/client/site_tests/policy_SearchSuggestEnabled/src/Makefile
[delete] https://crrev.com/8a93beb6aecbd0c4aaa1335b14c0e611cbd30bd4/client/site_tests/policy_BlockThirdPartyCookies/src/Makefile
[delete] https://crrev.com/8a93beb6aecbd0c4aaa1335b14c0e611cbd30bd4/client/site_tests/policy_SearchSuggestEnabled/control.notset_enable
[delete] https://crrev.com/8a93beb6aecbd0c4aaa1335b14c0e611cbd30bd4/client/site_tests/policy_AutoFillEnabled/control.true_enable
[modify] https://crrev.com/1400dd77037bf9ee47f86feb81f7d314069f3d58/client/site_tests/policy_ChromeOsLockOnIdleSuspend/policy_ChromeOsLockOnIdleSuspend.py
[delete] https://crrev.com/8a93beb6aecbd0c4aaa1335b14c0e611cbd30bd4/client/site_tests/policy_SpellCheckServiceEnabled/control
[delete] https://crrev.com/8a93beb6aecbd0c4aaa1335b14c0e611cbd30bd4/client/site_tests/policy_SearchSuggestEnabled/policy_SearchSuggestEnabled.py
[delete] https://crrev.com/8a93beb6aecbd0c4aaa1335b14c0e611cbd30bd4/client/site_tests/policy_SpellCheckServiceEnabled/control.notset_editable
[delete] https://crrev.com/8a93beb6aecbd0c4aaa1335b14c0e611cbd30bd4/client/site_tests/policy_SpellCheckServiceEnabled/policy_SpellCheckServiceEnabled.py
[delete] https://crrev.com/8a93beb6aecbd0c4aaa1335b14c0e611cbd30bd4/client/site_tests/policy_AutoFillEnabled/src/Makefile
Project Member

Comment 5 by bugdroid1@chromium.org, Apr 25 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/1400dd77037bf9ee47f86feb81f7d314069f3d58

commit 1400dd77037bf9ee47f86feb81f7d314069f3d58
Author: Katherine Threlkeld <kathrelkeld@chromium.org>
Date: Tue Apr 25 21:03:49 2017

[Autotest] Remove policy_ tests failing due to settings page changes.

See bug for context.  Remove tests which only check the settings page
value and not Chrome OS behavior.  Remove code which scrapes the
settings page - it doesn't work with MD settings page and we should
get rid of this UI dependency.

TEST=ran remaining test
BUG= chromium:712366 
CQ-DEPEND=CL:482185

Change-Id: I9ade14ef949a16896609afc277fe591e007f02b5
Reviewed-on: https://chromium-review.googlesource.com/481925
Commit-Ready: Katherine Threlkeld <kathrelkeld@chromium.org>
Tested-by: Katherine Threlkeld <kathrelkeld@chromium.org>
Reviewed-by: Krishna Gavini <krishnargv@chromium.org>

[delete] https://crrev.com/8a93beb6aecbd0c4aaa1335b14c0e611cbd30bd4/client/site_tests/policy_AutoFillEnabled/control.notset_enable
[delete] https://crrev.com/8a93beb6aecbd0c4aaa1335b14c0e611cbd30bd4/client/site_tests/policy_SearchSuggestEnabled/control
[delete] https://crrev.com/8a93beb6aecbd0c4aaa1335b14c0e611cbd30bd4/client/site_tests/policy_BlockThirdPartyCookies/control
[delete] https://crrev.com/8a93beb6aecbd0c4aaa1335b14c0e611cbd30bd4/client/site_tests/policy_SpellCheckServiceEnabled/control.true_enable
[delete] https://crrev.com/8a93beb6aecbd0c4aaa1335b14c0e611cbd30bd4/client/site_tests/policy_SpellCheckServiceEnabled/src/Makefile
[delete] https://crrev.com/8a93beb6aecbd0c4aaa1335b14c0e611cbd30bd4/client/site_tests/policy_BlockThirdPartyCookies/control.notset_allow
[modify] https://crrev.com/1400dd77037bf9ee47f86feb81f7d314069f3d58/client/cros/enterprise/enterprise_policy_base.py
[delete] https://crrev.com/8a93beb6aecbd0c4aaa1335b14c0e611cbd30bd4/client/site_tests/policy_BlockThirdPartyCookies/control.false_allow
[delete] https://crrev.com/8a93beb6aecbd0c4aaa1335b14c0e611cbd30bd4/client/site_tests/policy_AutoFillEnabled/policy_AutoFillEnabled.py
[delete] https://crrev.com/8a93beb6aecbd0c4aaa1335b14c0e611cbd30bd4/client/site_tests/policy_BlockThirdPartyCookies/policy_BlockThirdPartyCookies.py
[delete] https://crrev.com/8a93beb6aecbd0c4aaa1335b14c0e611cbd30bd4/client/site_tests/policy_SearchSuggestEnabled/control.false_disable
[delete] https://crrev.com/8a93beb6aecbd0c4aaa1335b14c0e611cbd30bd4/client/site_tests/policy_SpellCheckServiceEnabled/control.false_disable
[delete] https://crrev.com/8a93beb6aecbd0c4aaa1335b14c0e611cbd30bd4/client/site_tests/policy_BlockThirdPartyCookies/control.true_block
[delete] https://crrev.com/8a93beb6aecbd0c4aaa1335b14c0e611cbd30bd4/client/site_tests/policy_SearchSuggestEnabled/control.true_enable
[delete] https://crrev.com/8a93beb6aecbd0c4aaa1335b14c0e611cbd30bd4/client/site_tests/policy_AutoFillEnabled/control.false_disable
[delete] https://crrev.com/8a93beb6aecbd0c4aaa1335b14c0e611cbd30bd4/client/site_tests/policy_AutoFillEnabled/control
[delete] https://crrev.com/8a93beb6aecbd0c4aaa1335b14c0e611cbd30bd4/client/site_tests/policy_SearchSuggestEnabled/src/Makefile
[delete] https://crrev.com/8a93beb6aecbd0c4aaa1335b14c0e611cbd30bd4/client/site_tests/policy_BlockThirdPartyCookies/src/Makefile
[delete] https://crrev.com/8a93beb6aecbd0c4aaa1335b14c0e611cbd30bd4/client/site_tests/policy_SearchSuggestEnabled/control.notset_enable
[delete] https://crrev.com/8a93beb6aecbd0c4aaa1335b14c0e611cbd30bd4/client/site_tests/policy_AutoFillEnabled/control.true_enable
[modify] https://crrev.com/1400dd77037bf9ee47f86feb81f7d314069f3d58/client/site_tests/policy_ChromeOsLockOnIdleSuspend/policy_ChromeOsLockOnIdleSuspend.py
[delete] https://crrev.com/8a93beb6aecbd0c4aaa1335b14c0e611cbd30bd4/client/site_tests/policy_SpellCheckServiceEnabled/control
[delete] https://crrev.com/8a93beb6aecbd0c4aaa1335b14c0e611cbd30bd4/client/site_tests/policy_SearchSuggestEnabled/policy_SearchSuggestEnabled.py
[delete] https://crrev.com/8a93beb6aecbd0c4aaa1335b14c0e611cbd30bd4/client/site_tests/policy_SpellCheckServiceEnabled/control.notset_editable
[delete] https://crrev.com/8a93beb6aecbd0c4aaa1335b14c0e611cbd30bd4/client/site_tests/policy_SpellCheckServiceEnabled/policy_SpellCheckServiceEnabled.py
[delete] https://crrev.com/8a93beb6aecbd0c4aaa1335b14c0e611cbd30bd4/client/site_tests/policy_AutoFillEnabled/src/Makefile

Comment 6 by kathrelk...@chromium.org, Jul 10 2017

Status: Verified (was: Assigned)

Comment 7 by kathrelk...@chromium.org, May 2 2018

Labels: -ent-autotest ent-automation
►

Sign in to add a comment