Whitelisting Google's Chrome Apps for Public Sessions |
||||||||||
Issue descriptionDespite our team’s investment in enabling apps/extensions for PS either by explicit whitelisting or by opening-up certain permissions for automatic app whitelisting, we still receive requests from our customers and partners to whitelist specific apps/extensions for PS. One of the common requests is the ability to run Google’s Chrome apps in PS - e.g. Google Input Tools, Google translate etc. Given that the app developer is Google, any app/extension by Google should always be whitelisted for PS. Please see the doc - https://docs.google.com/document/d/1kkq2LoPWwQlZdm3cr1qotBhizsL6ig_-JZV0ffKQ6g4/edit
,
Apr 24 2017
Dear isandrk, This review has now been inactive for over 3 days. Could you please take appropriate steps to finish the review? Your friendly privacy review bot.
,
Apr 26 2017
Hey Raj, I'll put this on your plate for now. If you want some apps to be whitelisted, I'll be happy to update the code - I'd just need a list of the apps id's.
,
Apr 26 2017
,
May 1 2017
Dear sduraisamy, This review has now been inactive for over 3 days. Could you please take appropriate steps to finish the review? Your friendly privacy review bot.
,
May 12 2017
,
May 12 2017
Sorry - what does PS stand for?
,
May 12 2017
PS = Public Sessions - updated the title
,
May 30 2017
Hi Ivan, please whitelist the apps/extensions (highlighted in yellow) for Public Session - https://docs.google.com/spreadsheets/d/1I3fUtUujjRZNBFd7suD1fzdsPJguZp4EESldHBo3IFw/edit#gid=0 Hi Kay, all the apps and extensions were developed by Google. Please let me know if you have any concerns. Thx.
,
May 30 2017
,
Jun 2 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/af0e93c93117f537e337e65fe47358778f8ad63b commit af0e93c93117f537e337e65fe47358778f8ad63b Author: isandrk <isandrk@chromium.org> Date: Fri Jun 02 12:39:02 2017 Whitelisted Google Apps for public session Expanded whitelist according to spreadsheet linked in the bug: https://docs.google.com/spreadsheets/d/1I3fUtUujjRZNBFd7suD1fzdsPJguZp4EESldHBo3IFw BUG= 712337 Review-Url: https://codereview.chromium.org/2918563003 Cr-Commit-Position: refs/heads/master@{#476622} [modify] https://crrev.com/af0e93c93117f537e337e65fe47358778f8ad63b/chrome/browser/chromeos/extensions/device_local_account_management_policy_provider.cc
,
Jun 2 2017
,
Jun 2 2017
Raj, I'm assuming this should be merged to M60. Waiting for your green light to do the merge.
,
Jun 3 2017
Your change meets the bar and is auto-approved for M60. Please go ahead and merge the CL to branch 3112 manually. Please contact milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), josafat@(ChromeOS), bustamante@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jun 6 2017
Kay, from Privacy perspective - do you see any concerns?
,
Jun 6 2017
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible! If all merges have been completed, please remove any remaining Merge-Approved labels from this issue. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jun 7 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/73c79c2437a78fb433d692e49e17696aae08963a commit 73c79c2437a78fb433d692e49e17696aae08963a Author: Ivan Sandrk <isandrk@google.com> Date: Wed Jun 07 13:05:01 2017 [Merge to M60] Whitelisted Google Apps for public session Expanded whitelist according to spreadsheet linked in the bug: https://docs.google.com/spreadsheets/d/1I3fUtUujjRZNBFd7suD1fzdsPJguZp4EESldHBo3IFw BUG= 712337 Review-Url: https://codereview.chromium.org/2918563003 Cr-Original-Commit-Position: refs/heads/master@{#476622} Review-Url: https://codereview.chromium.org/2931613002 . Cr-Commit-Position: refs/branch-heads/3112@{#220} Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897} [modify] https://crrev.com/73c79c2437a78fb433d692e49e17696aae08963a/chrome/browser/chromeos/extensions/device_local_account_management_policy_provider.cc
,
Jun 20 2017
Verified in M60.0.3112.39:9592.27.0 elm beta that the proposed Google apps and extensions for Public Session have been implemented according to the sheet https://docs.google.com/spreadsheets/d/1I3fUtUujjRZNBFd7suD1fzdsPJguZp4EESldHBo3IFw I have verified all the apps in the list and added comments to each of the app that is whitelisted along with the ChromeOS build version for record purpose. May I suggest adding a Google app to the list? Password Alert (noondiphcddnnabmjcihcjfbhfklnnep) is not on the list but would be useful to help protect against phishing attempt.
,
Jun 26 2017
Raj should we add this app to the list? > May I suggest adding a Google app to the list? Password Alert (noondiphcddnnabmjcihcjfbhfklnnep) is not on the list but would be useful to help protect against phishing attempt.
,
Jun 26 2017
Sure. Let us add that extension to our list. |
||||||||||
►
Sign in to add a comment |
||||||||||
Comment 1 by sduraisamy@chromium.org
, Apr 17 2017