New issue
Advanced search Search tips

Issue 712332 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 1
Type: Bug
Team-Accessibility



Sign in to add a comment

LayoutTests/accessibility/aom.html is flaky due to setting internals.runtimeFlags

Project Member Reported by dmazz...@chromium.org, Apr 17 2017

Issue description

When running aom.html serially it passes, but when run in batch it fails.

The problem seems to be that if you try to access Element.accessibleNode before enabling internals.runtimeFlags.accessibilityObjectModelEnabled, then future attempts to access Element.accessibleNode will always fail.

 
Summary: LayoutTests/accessibility/aom.html is flaky due to setting internals.runtimeFlags (was: LayoutTests/aom.html is flaky due to setting internals.runtimeFlags)
Project Member

Comment 2 by bugdroid1@chromium.org, Apr 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dc08a2b61ba62af5187cb9edb01b0ce57cf9d57f

commit dc08a2b61ba62af5187cb9edb01b0ce57cf9d57f
Author: dmazzoni <dmazzoni@chromium.org>
Date: Mon Apr 17 21:27:24 2017

Disable LayoutTests/accessibility/aom.html

It's been failing when run in parallel, and only passing on retry.

BUG= 712332 
NOTRY=true
TBR=aboxhall@chromium.org

Review-Url: https://codereview.chromium.org/2820133003
Cr-Commit-Position: refs/heads/master@{#465024}

[modify] https://crrev.com/dc08a2b61ba62af5187cb9edb01b0ce57cf9d57f/third_party/WebKit/LayoutTests/TestExpectations

Project Member

Comment 3 by bugdroid1@chromium.org, Apr 19 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1c58631e4fa8074280e1ba81d639db80fcd5df3c

commit 1c58631e4fa8074280e1ba81d639db80fcd5df3c
Author: dmazzoni <dmazzoni@chromium.org>
Date: Wed Apr 19 09:26:29 2017

Re-enable AccessibilityObjectModel tests by setting the status to "test".

By setting the status of the feature in RuntimeEnabledFeatures.json5 to "test"
instead of "experimental", it's automatically enabled in tests.

Previously when the mode was set to "experimental", it was being disabled
by the content feature.

If this is a reasonable fix, should we update the documentation at the top of
RuntimeEnabledFeatures.json5 to say that "test" can be used for features that
are controlled by a content flag but should be enabled for tests?

BUG= 712332 

Review-Url: https://codereview.chromium.org/2822313002
Cr-Commit-Position: refs/heads/master@{#465539}

[modify] https://crrev.com/1c58631e4fa8074280e1ba81d639db80fcd5df3c/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/1c58631e4fa8074280e1ba81d639db80fcd5df3c/third_party/WebKit/LayoutTests/accessibility/aom-string-properties.html
[modify] https://crrev.com/1c58631e4fa8074280e1ba81d639db80fcd5df3c/third_party/WebKit/LayoutTests/accessibility/aom.html
[modify] https://crrev.com/1c58631e4fa8074280e1ba81d639db80fcd5df3c/third_party/WebKit/LayoutTests/virtual/service-worker-navigation-preload-disabled/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/1c58631e4fa8074280e1ba81d639db80fcd5df3c/third_party/WebKit/LayoutTests/webexposed/element-instance-property-listing-expected.txt
[modify] https://crrev.com/1c58631e4fa8074280e1ba81d639db80fcd5df3c/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/1c58631e4fa8074280e1ba81d639db80fcd5df3c/third_party/WebKit/Source/platform/RuntimeEnabledFeatures.json5

Status: Fixed (was: Assigned)

Sign in to add a comment