SurfaceManager: consider a less verbose spew of LocalSurfaceId |
|||||||||||
Issue descriptioncc::LocalSurfaceIds hold a base::UnguessableToken for security purposes so that an untrusted client cannot embed the Chrome UI and intercept input by overlaying a transparent div for example. However, from a debugging perspective, the token is a meaningless set of bits. The LocalSurfaceId also has a local_id that is expected to be allocated by a LocalSurfaceIds store and be unique and monotonically increasing for a given fixed FrameSinkId. This, from a debugging perspective, we only care to see the local_id. We should only display that by default in LocalSurfaceId::ToString() unless we select more verbose spew.
,
Apr 18 2017
perhaps gratuitous: maybe each surface id "pretty-printed name" (like for tracing) could be the client name, size, sequence #.
,
Apr 19 2017
,
May 3 2017
,
May 23 2017
,
Jun 13 2017
,
Jun 13 2017
,
Oct 24 2017
,
Jan 4 2018
,
Jan 4 2018
,
Jan 8 2018
I think it's better to print the nonce like AB..CD instead of not printing at all.
,
Jan 9 2018
,
Feb 1 2018
Enable the 2 different format: If enable_logging then shows the complete LocalSufaceId; otherwise shows the shorter version. info on enable logging: https://www.chromium.org/for-testers/enable-logging example of usage: https://cs.chromium.org/chromium/src/base/i18n/build_utf8_validator_tables.cc?type=cs&sq=package:chromium&l=455
,
Feb 8 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7a0d0edfa21d531698de1ba2af53ba456bb1f627 commit 7a0d0edfa21d531698de1ba2af53ba456bb1f627 Author: Illia Martyniuk <illiam@google.com> Date: Thu Feb 08 01:38:14 2018 Updating Local_Surface_Id::ToString() If logging level is less that 1 (not verbose) we print LocalSurfaceId's corresponding UnguessableToken as ABCD...; otherwise, we print full 16-character UnguessableToken. Added TEST=LocalSurfaceIdTest.VerifyToString Bug: 712308 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: I577b15f23fc50643a8db4c555bdd95dcd0057755 Reviewed-on: https://chromium-review.googlesource.com/904855 Commit-Queue: Illia Martyniuk <illiam@google.com> Reviewed-by: Fady Samuel <fsamuel@chromium.org> Reviewed-by: Yi Xu <yiyix@chromium.org> Cr-Commit-Position: refs/heads/master@{#535241} [modify] https://crrev.com/7a0d0edfa21d531698de1ba2af53ba456bb1f627/components/viz/common/BUILD.gn [modify] https://crrev.com/7a0d0edfa21d531698de1ba2af53ba456bb1f627/components/viz/common/surfaces/local_surface_id.cc [add] https://crrev.com/7a0d0edfa21d531698de1ba2af53ba456bb1f627/components/viz/common/surfaces/local_surface_id_unittest.cc
,
Feb 21 2018
@illiam has fixed it |
|||||||||||
►
Sign in to add a comment |
|||||||||||
Comment 1 by danakj@chromium.org
, Apr 18 2017