notimplemented in IsInVR causes console spam |
|||||||||
Issue descriptionIn a trunk build of Chrome OS, I see a million messages like this as I wave my mouse around: [7832:7832:0417/141213.140488:ERROR:render_widget_host_view_base.cc(141)] Not implemented reached in virtual bool content::RenderWidgetHostViewBase::IsInVR() const
,
Apr 19 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/37db26e938b37edc885a50ab1aca3aee1cfefb0d commit 37db26e938b37edc885a50ab1aca3aee1cfefb0d Author: asimjour <asimjour@chromium.org> Date: Wed Apr 19 14:37:01 2017 Remove NotImplemented from IsInVR If a platform does not support VR, IsInVR should return false without spamming the console. BUG= 712306 Review-Url: https://codereview.chromium.org/2822223002 Cr-Commit-Position: refs/heads/master@{#465599} [modify] https://crrev.com/37db26e938b37edc885a50ab1aca3aee1cfefb0d/content/browser/renderer_host/render_widget_host_view_base.cc
,
Apr 25 2017
,
May 12 2017
Is there a plan for cherry-picking this back to M59? The current beta is spamming the console.
,
May 24 2017
Issue 713788 has been merged into this issue.
,
May 24 2017
,
May 24 2017
,
May 24 2017
Your change meets the bar and is auto-approved for M59. Please go ahead and merge the CL to branch 3071 manually. Please contact milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), gkihumba@(ChromeOS), Abdul Syed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
May 24 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cf2b7470eef6f2af442b63a8e6739e916212b8e3 commit cf2b7470eef6f2af442b63a8e6739e916212b8e3 Author: Amirhossein Simjour <asimjour@chromium.org> Date: Wed May 24 16:58:17 2017 Remove NotImplemented from IsInVR If a platform does not support VR, IsInVR should return false without spamming the console. BUG= 712306 Review-Url: https://codereview.chromium.org/2822223002 Cr-Original-Commit-Position: refs/heads/master@{#465599} Review-Url: https://codereview.chromium.org/2900163003 . Cr-Commit-Position: refs/branch-heads/3071@{#685} Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641} [modify] https://crrev.com/cf2b7470eef6f2af442b63a8e6739e916212b8e3/content/browser/renderer_host/render_widget_host_view_base.cc
,
May 26 2017
Can we confirm if this has been fixed?
,
May 26 2017
|
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by est...@chromium.org
, Apr 17 2017