Hmm. Since resetting the profile fixed this, then the banner block bit must have been tripped. We only block showing the banner on a valid page if:

 - the site has already been added to homescreen
 - the banner has previously been shown and was explicitly dismissed or ignored until the user navigated away

Otherwise, it's just about earning enough engagement to trigger. Is it possible that the "getting A2HS bits into place" step actually ended up triggering a banner, which wasn't noticed because of scrolling or a navigation? Since a banner was shown, that would have set the block bit in the A2HS system until the profile data was reset.

Just realised this was assigned to me. Dom, could you try and repro this or work with the reporters to find out what's going on?

Thanks Owen and team for opening this one.

I'm afraid that, for partners like the one that reported the issue (MercadoLibre), it will often be the case that a user has visited their site very often, before their team upgraded it to a PWA.

I think the obvious case would be that, if the user doesn't close the tab, the SW will never become active, and therefore they can refresh the page endlessly without seeing the A2HS.

Anyways, it doesn't seem that in this case the problem was solved only by closing and reopening the tab (we needed to clear the profile).

Is there any way we could help reproducing this?

Thank you.

A specific repro case would be extremely helpful. Like I mentioned in c#1, the fact that you had to reset the profile to get the banner to show means that the site got marked has having had a banner shown. I'm pretty sure we don't even get to that point if the site is missing any of a) active service worker, b) manifest, c) correct icon, etc., so if we are ending up with the system thinking that a site has gotten a banner (but it's not a PWA), there's a serious bug that's dodging our testing, so a repro to expose that bug is what we need so I can trace it and figure out what exactly is going wrong. :)

Even if a site is marked as having shown a banner, it will be permitted to show a banner again in the future after some amount of time has passed. If the user didn't respond to the banner that period of time is 2 weeks. So this shouldn't be a permanent problem either; it will go away as time passes (we never block a banner forever; the site always gets another chance down the line until the user adds the site to their homescreen).

Closing for lack of a repro that contradicts the expected behaviour in #1 and #4 (i.e. that this should work fine). Please reopen if you can provide some specific steps. Thanks!