ui/gl changes don't trigger optional gpu trybots |
||||
Issue descriptionSee for example this change: https://chromium-review.googlesource.com/c/479566/ gpu/PRESUBMIT.py adds a few optional gpu trybots to every change but ui/PRESUBMIT.py doesn't do that. We should make ui/gl/PRESUBMIT.py trigger the same trybots. There shouldn't be many ui/gl changes so we don't need more capacity.
,
Apr 18 2017
Thanks for filing this issue. This is a ~2 minute CL; Sunny, would you mind putting it up? Appreciate it.
,
Apr 18 2017
Yeah, I'm planning on doing this today.
,
Apr 18 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4b2894f1267ae935781d02057ab0ac01feae8d7e commit 4b2894f1267ae935781d02057ab0ac01feae8d7e Author: Sunny Sachanandani <sunnyps@chromium.org> Date: Tue Apr 18 20:22:59 2017 gpu: Automatically add optional gpu tests to ui/gl changes. ui/gl changes are likely to affect gpu tests so we should run these trybots. R=kbr BUG= 712303 Change-Id: Id8b89b4647b1b1926184ff55a8746adddc3b345b CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Id8b89b4647b1b1926184ff55a8746adddc3b345b Reviewed-on: https://chromium-review.googlesource.com/479802 Reviewed-by: Kenneth Russell <kbr@chromium.org> Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> Cr-Commit-Position: refs/heads/master@{#465347} [modify] https://crrev.com/4b2894f1267ae935781d02057ab0ac01feae8d7e/gpu/PRESUBMIT.py [add] https://crrev.com/4b2894f1267ae935781d02057ab0ac01feae8d7e/ui/gl/PRESUBMIT.py
,
Apr 18 2017
,
Apr 18 2017
Thanks Sunny for taking care of this! |
||||
►
Sign in to add a comment |
||||
Comment 1 by ericrk@chromium.org
, Apr 17 2017