New issue
Advanced search Search tips

Issue 712296 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug
Proj-Servicification

Blocking:
issue 598073



Sign in to add a comment

Remove MediaDeviceIDSalt from ProfileIOData

Project Member Reported by mmenke@chromium.org, Apr 17 2017

Issue description

This class used to be used on both the UI and IO thread, but now it looks to have DCHECKs that it's only used on the UI thread.  As a result, it shouldn't be owned by ProfileIOData, nor should it be part of ResourceContext (Which we want to remove, too).
 
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c0b2b8b1b919b0fcda51e691406d50a62f89771d

commit c0b2b8b1b919b0fcda51e691406d50a62f89771d
Author: mmenke <mmenke@chromium.org>
Date: Fri Apr 21 16:27:52 2017

Move MediaDeviceIDSalt from ProfileIOData to ProfileImpl.

The object is never used on the IO thread, and even had DCHECKs to
ensure that's the case, so it makes no sense in ProfileIOData.

It's also one of the few things exposed by ResourceContext, which we're
probably going to get rid of.

BUG= 712296 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2820163002
Cr-Commit-Position: refs/heads/master@{#466358}

[modify] https://crrev.com/c0b2b8b1b919b0fcda51e691406d50a62f89771d/chrome/browser/extensions/api/webrtc_audio_private/webrtc_audio_private_api.cc
[modify] https://crrev.com/c0b2b8b1b919b0fcda51e691406d50a62f89771d/chrome/browser/extensions/api/webrtc_audio_private/webrtc_audio_private_browsertest.cc
[modify] https://crrev.com/c0b2b8b1b919b0fcda51e691406d50a62f89771d/chrome/browser/media/media_device_id_salt.cc
[modify] https://crrev.com/c0b2b8b1b919b0fcda51e691406d50a62f89771d/chrome/browser/media/media_device_id_salt.h
[modify] https://crrev.com/c0b2b8b1b919b0fcda51e691406d50a62f89771d/chrome/browser/profiles/profile_impl.cc
[modify] https://crrev.com/c0b2b8b1b919b0fcda51e691406d50a62f89771d/chrome/browser/profiles/profile_impl.h
[modify] https://crrev.com/c0b2b8b1b919b0fcda51e691406d50a62f89771d/chrome/browser/profiles/profile_io_data.cc
[modify] https://crrev.com/c0b2b8b1b919b0fcda51e691406d50a62f89771d/chrome/browser/profiles/profile_io_data.h
[modify] https://crrev.com/c0b2b8b1b919b0fcda51e691406d50a62f89771d/content/browser/browser_context.cc
[modify] https://crrev.com/c0b2b8b1b919b0fcda51e691406d50a62f89771d/content/browser/frame_host/render_frame_host_impl.cc
[modify] https://crrev.com/c0b2b8b1b919b0fcda51e691406d50a62f89771d/content/browser/renderer_host/media/media_devices_dispatcher_host.cc
[modify] https://crrev.com/c0b2b8b1b919b0fcda51e691406d50a62f89771d/content/browser/renderer_host/media/media_devices_dispatcher_host_unittest.cc
[modify] https://crrev.com/c0b2b8b1b919b0fcda51e691406d50a62f89771d/content/browser/renderer_host/media/media_stream_dispatcher_host_unittest.cc
[modify] https://crrev.com/c0b2b8b1b919b0fcda51e691406d50a62f89771d/content/browser/renderer_host/media/video_capture_unittest.cc
[modify] https://crrev.com/c0b2b8b1b919b0fcda51e691406d50a62f89771d/content/browser/renderer_host/render_process_host_impl.cc
[modify] https://crrev.com/c0b2b8b1b919b0fcda51e691406d50a62f89771d/content/browser/resource_context_impl.cc
[modify] https://crrev.com/c0b2b8b1b919b0fcda51e691406d50a62f89771d/content/public/browser/browser_context.h
[modify] https://crrev.com/c0b2b8b1b919b0fcda51e691406d50a62f89771d/content/public/browser/resource_context.h
[modify] https://crrev.com/c0b2b8b1b919b0fcda51e691406d50a62f89771d/extensions/browser/api/webcam_private/webcam_private_api_chromeos.cc

Comment 2 by mmenke@chromium.org, Apr 21 2017

Status: Fixed (was: Assigned)

Comment 3 by laforge@google.com, Nov 7 2017

Components: Internals>Network>Service

Comment 4 by laforge@google.com, Nov 7 2017

Components: -Internals>Network>Service Internals>Services>Network
Apologies, applied the wrong component in bulk.

Sign in to add a comment