[MacViewsBrowser] Long bookmark names should show an ellipsis, not fade out |
||||||||
Issue descriptionChrome Version: 60.0.3072.0 (MacViews) OS: macOS 10.12 On the Mac, bookmark bar names that are too long to fit are truncated with an ellipsis rather than faded out at the end.
,
Feb 8 2018
[Bulk Edit] Applying M-68 milestone per email discussion with ellyjones@. Pls change it if milestone is incorrectly applied.
,
Feb 13 2018
,
Mar 23 2018
MacViews triage: erikchen@: let's target this at M-68.
,
Mar 27 2018
,
Mar 29 2018
** Bulk Edit ** FYI: Starting 04/13 M68 will be in canary, M68 Dev promotion will be on 04/26.
,
Apr 2 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/766cbabcd2a7a8d8abd29683d99cd655748f3881 commit 766cbabcd2a7a8d8abd29683d99cd655748f3881 Author: erikchen <erikchen@chromium.org> Date: Mon Apr 02 17:28:40 2018 [MacViewsBrowser] Long bookmark names should show an ellipsis Bug: 712278 Change-Id: I20d490373e46fc09a3763b23bfcb86358e0d8c92 Reviewed-on: https://chromium-review.googlesource.com/988592 Reviewed-by: Erik Chen <erikchen@chromium.org> Reviewed-by: Avi Drissman <avi@chromium.org> Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#547459} [modify] https://crrev.com/766cbabcd2a7a8d8abd29683d99cd655748f3881/chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc [modify] https://crrev.com/766cbabcd2a7a8d8abd29683d99cd655748f3881/ui/views/style/platform_style.cc [modify] https://crrev.com/766cbabcd2a7a8d8abd29683d99cd655748f3881/ui/views/style/platform_style.h [modify] https://crrev.com/766cbabcd2a7a8d8abd29683d99cd655748f3881/ui/views/style/platform_style_mac.mm
,
Apr 2 2018
,
Apr 3 2018
Tried checking the issue on reported chrome version 60.0.3072.0 and on the latest canary 67.0.3387.0 using Mac 10.12.6 with the below mentioned step(s). 1. Added a bookmark for a site which has long name. We observed similar behaviour i.e., ellipsis are seen on reported and latest canary. Attaching the screen shots of the same. @erikchen: Could you please have a look at the screenshots and Please help us in confirming the fix and let us know the expected behaviour. Thanks!
,
Apr 3 2018
|
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by tapted@chromium.org
, Jun 8 2017Labels: Phase4