New issue
Advanced search Search tips

Issue 712271 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner: ----
Closed: Mar 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 1
Type: Bug

Blocking:
issue 671916



Sign in to add a comment

[MacViewsBrowser] Toolbar draws wrong background color

Project Member Reported by shrike@chromium.org, Apr 17 2017

Issue description

Chrome Version: 60.0.3072.0 (MacViews)
OS: macOS 10.12

MacViewsBrowser windows draw the wrong background color (it's different from the tabs and bookmarks bar).

 
Screen Shot 2017-04-16 at 3.54.49 PM.png
36.2 KB View Download
Blocking: 671916
Labels: Phase4
May I work on this?

Comment 3 by tapted@chromium.org, Jul 17 2017

This is not a good first bug - there's much to consider. Some examples:
 - user themes,
 - NSVisualEffectView usage,
 - cross-platform code overlap (e.g. in ui::NativeTheme),
 - missing titlebar gradients (e.g. compared to safari),
 - missing subpixel AA for the profile switcher,
 - NSFullSizeContentView usage and "adding an unknown subview"
 - Specific code to support 10.9 properly
 - fullscreen behavior

The blocked bug -  issue 671916  - isn't on the roadmap yet.
I see. Thanks :)
Project Member

Comment 5 by bugdroid1@chromium.org, Aug 31 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bfb22fd5548521c3d9796ecfc1817e14151ab5d1

commit bfb22fd5548521c3d9796ecfc1817e14151ab5d1
Author: Elly Fong-Jones <ellyjones@google.com>
Date: Thu Aug 31 18:55:01 2017

views: remove BrowserNonClientFrameViewMac::PaintToolbarBackground

This method is painting the toolbar background incorrectly, and the parent
class's implementation does it correctly.

Bug:  712271 
Change-Id: Ib9fd3ef67799545ec6c826b0e2e9c3a4b3cc3486
Reviewed-on: https://chromium-review.googlesource.com/646451
Reviewed-by: Trent Apted <tapted@chromium.org>
Commit-Queue: Trent Apted <tapted@chromium.org>
Cr-Commit-Position: refs/heads/master@{#498938}
[modify] https://crrev.com/bfb22fd5548521c3d9796ecfc1817e14151ab5d1/chrome/browser/ui/views/frame/browser_non_client_frame_view_mac.h
[modify] https://crrev.com/bfb22fd5548521c3d9796ecfc1817e14151ab5d1/chrome/browser/ui/views/frame/browser_non_client_frame_view_mac.mm

Labels: M-68
[Bulk Edit]
Applying M-68 milestone per email discussion with ellyjones@. Pls change it if milestone is incorrectly applied. 
Status: Fixed (was: Available)
MacViews triage: this was fixed by #5.

Sign in to add a comment