[MacViewsBrowser] Toolbar draws wrong background color |
|||
Issue descriptionChrome Version: 60.0.3072.0 (MacViews) OS: macOS 10.12 MacViewsBrowser windows draw the wrong background color (it's different from the tabs and bookmarks bar).
,
Jul 17 2017
May I work on this?
,
Jul 17 2017
This is not a good first bug - there's much to consider. Some examples: - user themes, - NSVisualEffectView usage, - cross-platform code overlap (e.g. in ui::NativeTheme), - missing titlebar gradients (e.g. compared to safari), - missing subpixel AA for the profile switcher, - NSFullSizeContentView usage and "adding an unknown subview" - Specific code to support 10.9 properly - fullscreen behavior The blocked bug - issue 671916 - isn't on the roadmap yet.
,
Jul 17 2017
I see. Thanks :)
,
Aug 31 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bfb22fd5548521c3d9796ecfc1817e14151ab5d1 commit bfb22fd5548521c3d9796ecfc1817e14151ab5d1 Author: Elly Fong-Jones <ellyjones@google.com> Date: Thu Aug 31 18:55:01 2017 views: remove BrowserNonClientFrameViewMac::PaintToolbarBackground This method is painting the toolbar background incorrectly, and the parent class's implementation does it correctly. Bug: 712271 Change-Id: Ib9fd3ef67799545ec6c826b0e2e9c3a4b3cc3486 Reviewed-on: https://chromium-review.googlesource.com/646451 Reviewed-by: Trent Apted <tapted@chromium.org> Commit-Queue: Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#498938} [modify] https://crrev.com/bfb22fd5548521c3d9796ecfc1817e14151ab5d1/chrome/browser/ui/views/frame/browser_non_client_frame_view_mac.h [modify] https://crrev.com/bfb22fd5548521c3d9796ecfc1817e14151ab5d1/chrome/browser/ui/views/frame/browser_non_client_frame_view_mac.mm
,
Feb 8 2018
[Bulk Edit] Applying M-68 milestone per email discussion with ellyjones@. Pls change it if milestone is incorrectly applied.
,
Mar 23 2018
MacViews triage: this was fixed by #5. |
|||
►
Sign in to add a comment |
|||
Comment 1 by tapted@chromium.org
, Jun 8 2017Labels: Phase4