New issue
Advanced search Search tips

Issue 712265 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: May 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Android stack symbolization broken w/ packed relocations

Project Member Reported by jbudorick@chromium.org, Apr 17 2017

Issue description

//third_party/android_platform/development/scripts/stack et al don't properly work w/ packed relocations enabled. They attempt to look at the stripped lib in the top-level output directory rather than the packed lib & wind up w/ garbage symbolization as a result.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 29 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/276cc56b7c04cc3a28ec6315feb00f056ea8327b

commit 276cc56b7c04cc3a28ec6315feb00f056ea8327b
Author: jbudorick <jbudorick@chromium.org>
Date: Sat Apr 29 01:34:58 2017

[Android] Fix stack symbolization when packed relocations are on.

We had been looking in lib.stripped for the library when symbolizing
debuggerd traces. The libraries in lib.stripped are not the ones with
packed relocations, though, so the resulting symbolization was wrong.

This CL generates a wrapper script around the stack symbolization
script that points to the correct library to use for symbolization.
It also contains a few tests that intentionally crash in various ways.
These are all disabled by default and should only ever be run manually
for testing out instrumentation test crash tooling.

BUG= 712265 

Review-Url: https://codereview.chromium.org/2840193003
Cr-Commit-Position: refs/heads/master@{#468206}

[modify] https://crrev.com/276cc56b7c04cc3a28ec6315feb00f056ea8327b/PRESUBMIT.py
[add] https://crrev.com/276cc56b7c04cc3a28ec6315feb00f056ea8327b/build/android/gyp/create_stack_script.py
[modify] https://crrev.com/276cc56b7c04cc3a28ec6315feb00f056ea8327b/build/config/android/internal_rules.gni
[modify] https://crrev.com/276cc56b7c04cc3a28ec6315feb00f056ea8327b/build/config/android/rules.gni
[modify] https://crrev.com/276cc56b7c04cc3a28ec6315feb00f056ea8327b/build/print_python_deps.py
[add] https://crrev.com/276cc56b7c04cc3a28ec6315feb00f056ea8327b/build/secondary/third_party/android_platform/development/scripts/BUILD.gn
[add] https://crrev.com/276cc56b7c04cc3a28ec6315feb00f056ea8327b/build/secondary/third_party/android_platform/development/scripts/stack.pydeps
[modify] https://crrev.com/276cc56b7c04cc3a28ec6315feb00f056ea8327b/chrome/android/java_sources.gni
[add] https://crrev.com/276cc56b7c04cc3a28ec6315feb00f056ea8327b/chrome/android/javatests/src/org/chromium/chrome/test/crash/IntentionalCrashTest.java
[modify] https://crrev.com/276cc56b7c04cc3a28ec6315feb00f056ea8327b/third_party/android_platform/development/scripts/stack
[modify] https://crrev.com/276cc56b7c04cc3a28ec6315feb00f056ea8327b/third_party/android_platform/development/scripts/stack_libs.py

Status: Fixed (was: Started)

Sign in to add a comment