New issue
Advanced search Search tips

Issue 712224 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Jun 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

[WebPayments] Updates to Contact Info saving logic

Project Member Reported by tmartino@chromium.org, Apr 17 2017

Issue description

The ContactInfoEditorViewController logic for ValidateModelAndSave should be extracted into a base class and applied to the shipping address equivalent. We should then update that logic to add the new profile to the profile cache in state_.
 
Base class should call OnBlur on all fields prior to validation. (Currently subclasses have to do this themselves to ensure that untouched fields are validated.)
Cc: anthonyvd@chromium.org
 Issue 722471  has been merged into this issue.
Labels: -Pri-3 M-60 Merge-Request-60 Pri-1
Status: Verified (was: Assigned)
For posterity: This was scaled back to mostly focus on the new ValidateInputFields method and its interaction with the Done button.
Project Member

Comment 6 by sheriffbot@chromium.org, Jun 6 2017

Labels: -Merge-Request-60 Hotlist-Merge-Approved Merge-Approved-60
Your change meets the bar and is auto-approved for M60. Please go ahead and merge the CL to branch 3112 manually. Please contact milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), josafat@(ChromeOS), bustamante@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 7 by bugdroid1@chromium.org, Jun 6 2017

Labels: -merge-approved-60 merge-merged-3112
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ab6afe29d413288ecf007b3797b840c1a150d349

commit ab6afe29d413288ecf007b3797b840c1a150d349
Author: tmartino <tmartino@chromium.org>
Date: Tue Jun 06 18:08:25 2017

[WebPayments] Disabling done button when form invalid

BUG= 712224 
TBR=mathp@chromium.org
NOTRY=true
NOPRESUBMIT=true

Review-Url: https://codereview.chromium.org/2905733002
Cr-Original-Commit-Position: refs/heads/master@{#476345}
Review-Url: https://codereview.chromium.org/2927593003
Cr-Commit-Position: refs/branch-heads/3112@{#190}
Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897}

[modify] https://crrev.com/ab6afe29d413288ecf007b3797b840c1a150d349/chrome/browser/ui/views/payments/contact_info_editor_view_controller.cc
[modify] https://crrev.com/ab6afe29d413288ecf007b3797b840c1a150d349/chrome/browser/ui/views/payments/contact_info_editor_view_controller.h
[modify] https://crrev.com/ab6afe29d413288ecf007b3797b840c1a150d349/chrome/browser/ui/views/payments/credit_card_editor_view_controller.cc
[modify] https://crrev.com/ab6afe29d413288ecf007b3797b840c1a150d349/chrome/browser/ui/views/payments/credit_card_editor_view_controller_browsertest.cc
[modify] https://crrev.com/ab6afe29d413288ecf007b3797b840c1a150d349/chrome/browser/ui/views/payments/editor_view_controller.cc
[modify] https://crrev.com/ab6afe29d413288ecf007b3797b840c1a150d349/chrome/browser/ui/views/payments/editor_view_controller.h
[modify] https://crrev.com/ab6afe29d413288ecf007b3797b840c1a150d349/chrome/browser/ui/views/payments/payment_request_browsertest_base.cc

Labels: Needs-Feedback
tmartino@ Could you please help us with steps to verify this fix from TE-End.

Thank You...
Components: -UI>Browser>Autofill>Payments UI>Browser>Payments

Sign in to add a comment