revamp url::Origin |
||||
Issue descriptionurl::Origin and blink::SecurityOrigin should essentially be the same thing. The main issue is how to maintain identity for unique origins across mojo ipc, but the rest should be easily solvable
,
Jul 18 2017
Also strongly related: https://crbug.com/490074
,
Jul 18 2017
Just for some background, the reason I didn't land my original CL was because I was poking at how to make conversions fast. As this wasn't high priority at the time, I backgrounded the CL. If this is critical, I'm happy to bring the CL up-to-date and figure out the conversions, so we can land the unique/opaque origin tracking: this is actually important for me now as well (I don't care as much about the other bits, though I think we should fix them as well).
,
Jul 18 2017
That CL is crucial to getting feature-policy-controlled features working in sandboxed frames; right now there's no way for a sandboxed frame to know that the opaque origin mentioned in its feature policy refers to itself, and not some other opaque origin. I'd started changing both Origin and SecurityOrigin to use base::Optional<base::UnguessableToken>, and plumbing that id through IPC and frame creation, but I'm happy to let you pick up where you left off with that CL if you're motivated :)
,
Sep 21 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/75414dbfcaa569ee97864695259b5e137c82e508 commit 75414dbfcaa569ee97864695259b5e137c82e508 Author: Daniel Cheng <dcheng@chromium.org> Date: Thu Sep 21 02:33:21 2017 Only use url::Origin::UnsafelyCreateOriginWithoutNormalization for IPC Tests should just use the constructor from GURL. Bug: 712213 Change-Id: I38cd41b6fda1646074ac4620ce3c19cc2776fe3f Reviewed-on: https://chromium-review.googlesource.com/674944 Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Mike West <mkwst@google.com> Reviewed-by: Mike West <mkwst@chromium.org> Reviewed-by: Michael Nordman <michaeln@chromium.org> Cr-Commit-Position: refs/heads/master@{#503323} [modify] https://crrev.com/75414dbfcaa569ee97864695259b5e137c82e508/components/autofill/content/common/autofill_types_struct_traits_unittest.cc [modify] https://crrev.com/75414dbfcaa569ee97864695259b5e137c82e508/content/browser/dom_storage/local_storage_context_mojo_unittest.cc
,
Mar 29 2018
,
Apr 18 2018
,
Apr 18 2018
,
Jan 18
(5 days ago)
Ian, is this still to be addressed? |
||||
►
Sign in to add a comment |
||||
Comment 1 by iclell...@chromium.org
, Jul 18 2017Blocking: 690520
Cc: dcheng@chromium.org
Components: Blink>FeaturePolicy Blink>Network
Labels: -Pri-3 OS-All Pri-2
Owner: iclell...@chromium.org
Status: Assigned (was: Untriaged)