Download manager is displayed when opening invalid data: URLs |
||||||||||||||
Issue descriptionApp Version: 58.0.3029.76 beta iOS Version: 10.3.2, 10.2 Device: iPhone7, iPad URL: data:test Steps to reproduce: 1. Launch Google Chrome 2. Type data:test in omnibox and Go Observed results: Download Manager UI is displayed. Expected results: SIte cannot be reached error page should be displayed Number of times you were able to reproduce: 5/5 Bug reproducible after clean install: Yes Bug reproducible after clearing cache and cookies: Yes Bug reproducible on Chrome Mobile on Android: Not tested Bug reproducible on Safari/Firefox: Firefox: Firefox doesn't support downloads prompt is displayed, Safari: Page is in loading state forever. Bug reproducible on current stable build (App Version, iOS Version): M57 YES Bug reproducible on the current beta channel build (App Version, iOS Version): M58 YES Autofill bugs: Bug reproducible on Chrome desktop? Site Not reachable error page displayed. Link to video/image: https://drive.google.com/file/d/0B-xmXLQhjeKualY1cC1NMzNBMFU/view
,
Nov 2 2017
,
Dec 5 2017
,
Dec 5 2017
,
Dec 21 2017
Reassigning my bugs.
,
Dec 21 2017
,
Mar 19 2018
Technically the URL is invalid due to the lack of a comma (the shortest valid data uri is "data:,") but this doesn't seem like a worthwhile issue to fix.
,
May 4 2018
Will be fixed in New Download Manager UI in M67.
,
May 4 2018
,
May 21 2018
,
May 21 2018
,
May 30 2018
,
Aug 10
,
Sep 26
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/66265f84e4e76aa5db9a5fed90b1347cc04181e8 commit 66265f84e4e76aa5db9a5fed90b1347cc04181e8 Author: Eugene But <eugenebut@chromium.org> Date: Wed Sep 26 16:48:00 2018 Support data: URLs in iOS Download Manager. data: URLs can be used for Calendar events and Contacts. These URLs are supported by Safari and Chrome on other platforms. This change will regress crbug.com/712206 (which is a minor bug), so CRWWebControllerDownloadTest.DataUrlResponse test was removed. Also updated FakeDownloadTaskImplDelegate to set mock expectations earlier, because CreateSession is now called much later to avoid creating sessions for data:// URLs. Bug: 712206, 666211, 604533 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: Iddbd7b8e58b781c1d093e35539db8fe5ec8841c4 Reviewed-on: https://chromium-review.googlesource.com/1244976 Commit-Queue: Eugene But <eugenebut@chromium.org> Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#594346} [modify] https://crrev.com/66265f84e4e76aa5db9a5fed90b1347cc04181e8/ios/web/download/download_task_impl.h [modify] https://crrev.com/66265f84e4e76aa5db9a5fed90b1347cc04181e8/ios/web/download/download_task_impl.mm [modify] https://crrev.com/66265f84e4e76aa5db9a5fed90b1347cc04181e8/ios/web/download/download_task_impl_unittest.mm [modify] https://crrev.com/66265f84e4e76aa5db9a5fed90b1347cc04181e8/ios/web/web_state/ui/crw_web_controller.mm [modify] https://crrev.com/66265f84e4e76aa5db9a5fed90b1347cc04181e8/ios/web/web_state/ui/crw_web_controller_unittest.mm
,
Sep 26
This is now reproducible again. |
||||||||||||||
►
Sign in to add a comment |
||||||||||||||
Comment 1 by edchin@chromium.org
, Apr 17 2017Labels: M-60
Owner: gch...@chromium.org
Status: Assigned (was: Untriaged)