New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 712201 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug-Regression



Sign in to add a comment

Make telemetry_GpuTests run again

Project Member Reported by gurcheta...@chromium.org, Apr 17 2017

Issue description

run_gpu_test.py was removed with https://codereview.chromium.org/2618983004.  As a result, the tests having been failing:

https://wmatrix.googleplex.com/summary/unfiltered?tests=telemetry_GpuTests&days_back=50&releases=59&hide_missing=True 

We need to change telemetry_GpuTests to use whatever new test harness was introduced to get the tests back running again.  Here are some good instructions to get telemetry running on ChromeOS here:

https://www.chromium.org/developers/telemetry/running-telemetry-on-chrome-os
 
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 19 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/faf75e9565c213b68d12b5bb603cc94827f37cd4

commit faf75e9565c213b68d12b5bb603cc94827f37cd4
Author: Gurchetan Singh <gurchetansingh@google.com>
Date: Wed Apr 19 20:23:23 2017

telemetry: make telemetry_GpuTests run again

run_gpu_test.py was removed with crrev.com/2618983004. Additionally,
the wrapper to run_gpu_test.py was removed with CL:331795. We need
to create a new wrapper to the new script (run_gpu_integration_test.py).

BUG= chromium:712201 
TEST=test_that --args='local=True' $IP telemetry_GpuTests.screenshot_sync
     succeeds on Kevin

Change-Id: Id1ec31078f613cae848ca1dcf374cae41f4f60d5
Reviewed-on: https://chromium-review.googlesource.com/479470
Reviewed-by: Ilja H. Friedel <ihf@chromium.org>
Tested-by: Gurchetan Singh <gurchetansingh@chromium.org>

[modify] https://crrev.com/faf75e9565c213b68d12b5bb603cc94827f37cd4/server/site_tests/telemetry_GpuTests/telemetry_GpuTests.py
[modify] https://crrev.com/faf75e9565c213b68d12b5bb603cc94827f37cd4/server/cros/telemetry_runner.py

Comment 2 by ihf@chromium.org, Apr 21 2017

Owner: gurcheta...@chromium.org
Status: Started (was: Untriaged)
Whohoo! Tests are green again:
https://wmatrix.googleplex.com/unfiltered?hide_missing=True&releases=tot&tests=telemetry_GpuTests


Comment 4 by ihf@chromium.org, Apr 21 2017

Cc: haddowk@chromium.org
Mhh, that may be a lab problem. Maybe machines not labeled right:
https://wmatrix.googleplex.com/unfiltered?suites=crosbolt_perf_perbuild&releases=58&days_back=100

Keith, can you take a quick look to see why the crosbolt dashboard is so sad?
Cc: bccheng@chromium.org hctsai@chromium.org
Adding the TPE team - I will try to look also.

Comment 6 by ihf@chromium.org, Apr 21 2017

We checked and telemetry_Benchmarks.smoothness.top_25_smooth runs locally and passes.
Project Member

Comment 7 by bugdroid1@chromium.org, Apr 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/66a5d613ab5ed31b517894ce79b9beb68478bd01

commit 66a5d613ab5ed31b517894ce79b9beb68478bd01
Author: Gurchetan Singh <gurchetansingh@google.com>
Date: Fri Apr 21 23:46:50 2017

telemetry_GpuTests: remove webgl_robustness

It was removed with crrev.com/2375323002. Remove it here.

BUG= chromium:712201 
TEST=none

Change-Id: Idda12b01b1e364f26b7ebc8c5e57181d6156f23c
Reviewed-on: https://chromium-review.googlesource.com/479951
Reviewed-by: Gurchetan Singh <gurchetansingh@chromium.org>
Reviewed-by: Ilja H. Friedel <ihf@chromium.org>
Commit-Queue: Gurchetan Singh <gurchetansingh@chromium.org>
Tested-by: Gurchetan Singh <gurchetansingh@chromium.org>
Trybot-Ready: Gurchetan Singh <gurchetansingh@chromium.org>

[delete] https://crrev.com/bebf4195732999029a40c4a4d632fa1771258848/server/site_tests/telemetry_GpuTests/control.webgl_robustness
[modify] https://crrev.com/66a5d613ab5ed31b517894ce79b9beb68478bd01/server/site_tests/telemetry_GpuTests/generate_controlfiles.py

Comment 8 by ihf@chromium.org, Apr 22 2017

Cc: achuith@chromium.org
 Issue 603803  has been merged into this issue.

Comment 9 by hctsai@chromium.org, Apr 24 2017

top_25_smoothness failed due to this long standing bug :  crbug.com/667432 . The test would be shown as "Passed" but lack many metrics in the result file.
Status: Fixed (was: Started)

Sign in to add a comment