New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 712196 link

Starred by 23 users

Issue metadata

Status: Fixed
Owner:
not on Chrome anymore
Closed: May 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 1
Type: Bug



Sign in to add a comment

Translucent popups are invisible with Direct3D 9 renderer in Win 10 Creator Update

Reported by lo...@yandex-team.ru, Apr 17 2017

Issue description

UserAgent: Mozilla/5.0 (Windows NT 6.1; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/56.0.2924.87 YaBrowser/17.3.1.840 Yowser/2.5 Safari/537.36

Steps to reproduce the problem:
1. Install Win 10 Creator Update
2. Run chromium with flag --disable-d3d11
3. Try exec alert(1) in JS console

What is the expected behavior?
Pop-up

What went wrong?
Invisible pop-up

Did this work before? No 

Chrome version: 56.0.2924.87  Channel: n/a
OS Version: 6.1 (Windows 7, Windows Server 2008 R2)
Flash Version: Shockwave Flash 23.0 r0

It looks like d3d9 is broken in Win 10 Creator Update.

https://bugs.chromium.org/p/chromium/issues/detail?id=710783
https://bugs.chromium.org/p/chromium/issues/detail?id=710560
http://forums.opera.com/discussion/1883349/after-win-10-creator-update-vpn-icon-doesn039t-work#Item_18
 

Comment 1 by enne@chromium.org, Apr 17 2017

Cc: vmi...@chromium.org jbau...@chromium.org ericrk@chromium.org
Components: Internals>GPU
Labels: -Pri-2 Pri-1

Comment 2 by vmi...@chromium.org, Apr 17 2017

Thanks for the report.  Could you provide your GPU configuration from 'chrome://gpu'?


Comment 3 by vmi...@chromium.org, Apr 17 2017

Owner: ericrk@chromium.org
Status: Assigned (was: Unconfirmed)
ericrk@ is investigating.
Sorry, I am out of the office now. I will attach gpu info tomorrow. 
I have tested HD* and GMA* Intel GPUs, all of them are broken.
PS. Don't forget to use the flag —disable-d3d11
This works on my razer blade stealth, FWIW. I imagine the bug's connected to the steps documented at https://cs.chromium.org/chromium/src/ui/views/widget/widget_hwnd_utils.cc?type=cs&q=WS_EX_COMPOSITED+package:%5Echromium$&l=51 that we take to create transparent windows, but I don't know why they'd cause problems.
jbau...@chromium.org
You are right!
I have reverted this hack and bug disappeared.

I attached gpu info.
gpu.htm
103 KB View Download

Comment 7 by ericrk@chromium.org, Apr 18 2017

Just to add my data (nothing too useful unfortunately) - I can't repro on my desktop system (NVidia Quadro K2200) or a test laptop (Intel HD Graphics 400 Cherryview) while passing --disable-d3d11

Comment 8 by ericrk@chromium.org, Apr 18 2017

Looking through the reports, these all appear to be on older Intel systems (GMA or early HD Graphics). It sounds like HD4000+ at least is working. Will try to track down a machine.

Comment 9 by ericrk@chromium.org, Apr 18 2017

Owner: jbau...@chromium.org
jbauman@ may have a device that repros. Assigning to him - if not, please assign back and I'll work on tracking one down.
I can repro this on my machine with an Intel HD 4000. --disable-dwm-composition also fixes the problem, so we might need to use that (or something similar) as a workaround on these machines if we can't find a better fix.
I can repro on HD4000 too. My winver is 10.0.15063.
--disable-dwm-composition helps!

To repro this on canary with the "alert(1);" you may need to specify the "--disable-features=AutoDismissingDialogs" command-line flag, or else the dialog could be created in a way that doesn't cause the bug. With that flag I can repro it on both systems I have with Intel graphics cards.
Summary: Translucent popups are invisible with Direct3D 9 renderer in Win 10 Creator Update (was: Chromium under Direct3D 9 renderer is broken in Win 10 Creator Update )
Cc: brajkumar@chromium.org
 Issue 710560  has been merged into this issue.
Cc: msrchandra@chromium.org
 Issue 710783  has been merged into this issue.

Comment 16 by r...@goldstein.tel, Apr 20 2017

I'm also affected by this, and it started immediately after installing the Windows 10 Creators Update, with the then-current stable Chrome 57, and now on 58.

Specifications of the affected laptop, including switchable graphics, Intel onboard GPU and Radeon HD 7690M: https://support.hp.com/us-en/document/c03144648

Chrome doesn't crash; just dialogs, like from clicking the profile name at the top, or on the "Do you want to leave this site?" dialog, are not visible. I've found that those dialogs (such as in the attached screenshot) can be bypassed by pressing Enter, assuming the default selection is the desired one - in this case, 'Leave'.

Disabling hardware acceleration and restarting Chrome makes those dialogs visible again.

I'm happy to provide any other information that may be helpful.
dialog.png
5.7 KB View Download
Project Member

Comment 17 by bugdroid1@chromium.org, Apr 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fec5a00d881dcf85a1a4334af1369402e183a302

commit fec5a00d881dcf85a1a4334af1369402e183a302
Author: jbauman <jbauman@chromium.org>
Date: Fri Apr 21 01:10:49 2017

Remove use of WS_EX_COMPOSITED for translucent windows.

This style causes windows to display transparent on Windows 10 creators
update with some Intel drivers on D3D9.

The style itself is unnecessary, becasue based on its documentation it
doesn't affect top-level window rendering, but affects only how child
unredirected windows (which aren't used in Aura) render on top of their
parents.

BUG= 712196 

Review-Url: https://codereview.chromium.org/2826343002
Cr-Commit-Position: refs/heads/master@{#466207}

[modify] https://crrev.com/fec5a00d881dcf85a1a4334af1369402e183a302/content/browser/compositor/software_output_device_win.cc
[modify] https://crrev.com/fec5a00d881dcf85a1a4334af1369402e183a302/ui/base/win/internal_constants.cc
[modify] https://crrev.com/fec5a00d881dcf85a1a4334af1369402e183a302/ui/base/win/internal_constants.h
[modify] https://crrev.com/fec5a00d881dcf85a1a4334af1369402e183a302/ui/views/widget/desktop_aura/desktop_window_tree_host_win.cc
[modify] https://crrev.com/fec5a00d881dcf85a1a4334af1369402e183a302/ui/views/widget/widget_hwnd_utils.cc
[modify] https://crrev.com/fec5a00d881dcf85a1a4334af1369402e183a302/ui/views/win/hwnd_message_handler.cc
[modify] https://crrev.com/fec5a00d881dcf85a1a4334af1369402e183a302/ui/views/win/hwnd_message_handler.h

Do you plan to commit it in 59? (or may be 58?)
Yeah, though we'll need to wait a few days for it to bake in canary.

Comment 20 Deleted

Newest Canary seems to have the fix. Running on post-Creators build 16179.

A decision was made a while back to disable D3D11 on these AMD switchable systems. Is it time to revisit that? Drivers have gotten better since then.

There's no way to force enable D3D11 with either GPU, even if you rename the Chrome executable and run it on the AMD GPU.

https://bugs.chromium.org/p/chromium/issues/detail?id=451420
https://bugs.chromium.org/p/chromium/issues/detail?id=330271
@erapple.. try using --ignore-gpu-blacklist; this works with my AMD setup.
Labels: Merge-Request-59
Project Member

Comment 24 by sheriffbot@chromium.org, Apr 25 2017

Labels: -Merge-Request-59 Hotlist-Merge-Approved Merge-Approved-59
Your change meets the bar and is auto-approved for M59. Please go ahead and merge the CL to branch 3071 manually. Please contact milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), gkihumba@(ChromeOS), Abdul Syed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
@reupload The flag doesn't help. Stuck at DX9 with both GPUs. At least with these newest builds I can run in HW accel mode again. It was months.
Project Member

Comment 26 by bugdroid1@chromium.org, Apr 25 2017

Labels: -merge-approved-59 merge-merged-3071
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bfacd1e5e1f1db344364c6c7f56f89ce773b722a

commit bfacd1e5e1f1db344364c6c7f56f89ce773b722a
Author: John Bauman <jbauman@chromium.org>
Date: Tue Apr 25 20:12:59 2017

Remove use of WS_EX_COMPOSITED for translucent windows.

This style causes windows to display transparent on Windows 10 creators
update with some Intel drivers on D3D9.

The style itself is unnecessary, becasue based on its documentation it
doesn't affect top-level window rendering, but affects only how child
unredirected windows (which aren't used in Aura) render on top of their
parents.

BUG= 712196 

Review-Url: https://codereview.chromium.org/2826343002
Cr-Commit-Position: refs/heads/master@{#466207}
(cherry picked from commit fec5a00d881dcf85a1a4334af1369402e183a302)

Review-Url: https://codereview.chromium.org/2842853002 .
Cr-Commit-Position: refs/branch-heads/3071@{#202}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}

[modify] https://crrev.com/bfacd1e5e1f1db344364c6c7f56f89ce773b722a/content/browser/compositor/software_output_device_win.cc
[modify] https://crrev.com/bfacd1e5e1f1db344364c6c7f56f89ce773b722a/ui/base/win/internal_constants.cc
[modify] https://crrev.com/bfacd1e5e1f1db344364c6c7f56f89ce773b722a/ui/base/win/internal_constants.h
[modify] https://crrev.com/bfacd1e5e1f1db344364c6c7f56f89ce773b722a/ui/views/widget/desktop_aura/desktop_window_tree_host_win.cc
[modify] https://crrev.com/bfacd1e5e1f1db344364c6c7f56f89ce773b722a/ui/views/widget/widget_hwnd_utils.cc
[modify] https://crrev.com/bfacd1e5e1f1db344364c6c7f56f89ce773b722a/ui/views/win/hwnd_message_handler.cc
[modify] https://crrev.com/bfacd1e5e1f1db344364c6c7f56f89ce773b722a/ui/views/win/hwnd_message_handler.h

I tried on two machines where I wasn't able to reproduce the issue without the fix in comment#26, hence we are going ahead with M59 Beta launch.

Comment 28 Deleted

Labels: Merge-Request-58
As Creators update rolls out more this will hit more people, so we should consider merging to M58.
Labels: -Merge-Request-58
Ok, seems like this isn't quite critical enough for M58.
Status: Fixed (was: Assigned)

Comment 32 by b...@brinknet.us, May 9 2017

I also hate how my Intel gpu is limited because I have AMD switchable. The drivers don't let Chrome run on the AMD chip had Chrome reverts the Intel to software cause it sees the AMD end brute/blanket disables everything regardless. 
Still happening here after updating to W10 creators:

Google Chrome: 58.0.3029.110 (64 bits)
Revision: 691bdb490962d4e6ae7f25c6ab1fdd0faaf19cd0-refs/branch-heads/3029@{#830}
SO: Windows

Comment 34 by accel...@gmail.com, May 17 2017

How is this not 'critical'? This bug hasn't been fixed yet as of version 58.0.3029.110 (64-bit), and is directly affecting user experience. Most of my popup windows are still missing, and only render after randomly guessing where the buttons should be (such as the translation popup).

Sign in to add a comment