Replace explicitly supported Password Manager extensions with something easier to configure |
||||
Issue descriptionactivity_type_util.mm TypeFromString() function used to rely on a hardcoded list of supported extensions, included Password Management extensions. This makes it hard to extend support to more extensions. Change this to use a configuration file that can be easily extended by any third party.
,
Apr 17 2017
,
Apr 17 2017
,
Apr 19 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a07a8f7a373cc13ee2163341a1b9c8c813c49a1f commit a07a8f7a373cc13ee2163341a1b9c8c813c49a1f Author: pkl <pkl@chromium.org> Date: Wed Apr 19 13:02:37 2017 List Password Manager extensions in a static data structure Collected the necessary information for supported Password Manager Extensions in a static data structure. BUG= 712194 TEST=test with 1Password, Lastpass, and Dashlane extensions Review-Url: https://codereview.chromium.org/2823883002 Cr-Commit-Position: refs/heads/master@{#465567} [modify] https://crrev.com/a07a8f7a373cc13ee2163341a1b9c8c813c49a1f/ios/chrome/browser/ui/activity_services/activity_service_controller_unittest.mm [modify] https://crrev.com/a07a8f7a373cc13ee2163341a1b9c8c813c49a1f/ios/chrome/browser/ui/activity_services/activity_type_util.h [modify] https://crrev.com/a07a8f7a373cc13ee2163341a1b9c8c813c49a1f/ios/chrome/browser/ui/activity_services/activity_type_util.mm [modify] https://crrev.com/a07a8f7a373cc13ee2163341a1b9c8c813c49a1f/ios/chrome/browser/ui/activity_services/activity_type_util_unittest.mm [modify] https://crrev.com/a07a8f7a373cc13ee2163341a1b9c8c813c49a1f/ios/chrome/browser/ui/activity_services/appex_constants.h [modify] https://crrev.com/a07a8f7a373cc13ee2163341a1b9c8c813c49a1f/ios/chrome/browser/ui/activity_services/appex_constants.mm
,
Apr 19 2017
|
||||
►
Sign in to add a comment |
||||
Comment 1 by pkl@chromium.org
, Apr 17 2017