New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 712188 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: May 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

content_shell.exe is no longer running on Win 10

Project Member Reported by infe...@chromium.org, Apr 17 2017

Issue description

Something broke this on March 30.

When running ASANified content_shell.exe on Windows, I get "This app can't run on your PC" on our Windows Server 2012 R2 64-bit (Win 10) bots. I have tried running compatibility troubleshooter on this, but no success. Did anything change on the clang side to trigger this ? I don't see this issue on chrome.exe.

Are you guys able to run content_shell.exe fine ? Can you try with ASAN version.
 

Comment 1 by thakis@chromium.org, Apr 17 2017

There were clang rolls 3/27 (https://codereview.chromium.org/2771563002) and 4/12 (https://codereview.chromium.org/2816593003), nothing on 3/30.

Comment 2 by r...@chromium.org, May 3 2017

Is this still an issue? I never got to this.

Comment 3 by aarya@google.com, May 3 2017

The issue still exists. And it gives the same result for content_shell.exe when run locally on my win 10 desktop that "app can't run on my pc", followed by access denied message.

Comment 4 Deleted

Comment 5 Deleted

Comment 6 Deleted

I removed the /guard:cf flag on the linker command-line and the executable was running correctly. [asan-32 bit, windows-10]

There is something wrong with ASAN + guard.

I did a simple executable compiled with ASAN + guard and it was working fine.
So, there is something going wrong... somewhere...

This temporary patch is solving the problem:

diff --git a/build/config/BUILD.gn b/build/config/BUILD.gn
index 60c2bb7..35ea118 100644
--- a/build/config/BUILD.gn
+++ b/build/config/BUILD.gn
@@ -281,7 +281,7 @@ config("executable_config") {
     configs += _windows_linker_configs

     # Currently only turn on linker CFI for executables.
-    configs += [ "//build/config/win:cfi_linker" ]
+    # configs += [ "//build/config/win:cfi_linker" ]
   } else if (is_mac) {
     configs += [
       "//build/config/mac:mac_dynamic_flags",
That bug was fixed in llvm r301047. We yesterday rolled in a clang with that revision.

Comment 11 by aarya@google.com, May 12 2017

Status: Fixed (was: Assigned)
Nice, this is now fixed, see new crash on content_shell job type.
https://clusterfuzz.com/v2/testcase-detail/5853996169560064
https://clusterfuzz.com/v2/crash-stats?end=415168&hours=1&job=windows_asan_content_shell&order=total_count
Owner: h...@chromium.org
Since Hans wrote r301047, he fixed this.
เมื่อ 4 พ.ค. 2017 06:41 "ลียะ ดือเร๊ะ" <a0622408373@gmail.com> เขียนว่า
เมื่อ 12 พ.ค. 2017 22:54 "etien… via monorail" <
monorail+v2.1562186490@chromium.org> เขียนว่า

Sign in to add a comment