New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 712165 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug
Proj-XR



Sign in to add a comment

openvr_device.h and openvr/openvr_device_provider.h are not included in the BUILD.gn

Reported by ningxin...@intel.com, Apr 17 2017

Issue description

UserAgent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/60.0.3074.0 Safari/537.36

Steps to reproduce the problem:
Look at https://chromium.googlesource.com/chromium/src/+/9cba92ff883c28331c09b2e81e26373970333b1f/device/vr/BUILD.gn

What is the expected behavior?

What went wrong?
openvr_device.h and openvr/openvr_device_provider.h are not included in the BUILD.gn

Did this work before? N/A 

Does this work in other browsers? N/A

Chrome version: 60.0.3074.0  Channel: n/a
OS Version: 10.0
Flash Version:
 

Comment 1 by amp@chromium.org, Apr 17 2017

I see them on lines 88 and 89 of the BUILD.gn file you linked.  They require setting the 'enable_openvr' build flag since it is still under development.

Can you explain what you expected to happen?

Comment 2 by amp@chromium.org, Apr 17 2017

Status: Available (was: Unconfirmed)
Doh, just realized the problem after I looked at your cl. :)


Project Member

Comment 3 by bugdroid1@chromium.org, Apr 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e585f9bcd2189fbfa2e9bc8bdafad9c0af1f3047

commit e585f9bcd2189fbfa2e9bc8bdafad9c0af1f3047
Author: ningxin.hu <ningxin.hu@intel.com>
Date: Mon Apr 17 19:23:16 2017

Add openvr_device.h and openvr_device_provider.h into BUILD.gn

BUG= 712165 

Review-Url: https://codereview.chromium.org/2823843002
Cr-Commit-Position: refs/heads/master@{#464974}

[modify] https://crrev.com/e585f9bcd2189fbfa2e9bc8bdafad9c0af1f3047/device/vr/BUILD.gn

Labels: Proj-VR VR-Desktop
Cc: amp@chromium.org
Owner: billorr@chromium.org
Is this fixed now?
Status: Fixed (was: Available)
Labels: Test-Complete
Components: Blink>WebXR

Sign in to add a comment