New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 712130 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner: ----
Closed: Oct 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug-Regression



Sign in to add a comment

webGLSL: "return" ignored in "if"

Reported by fabrice....@gmail.com, Apr 17 2017

Issue description

UserAgent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/57.0.2987.133 Safari/537.36

Steps to reproduce the problem:
in webGLSL-ES : 
if (a) do A
if (!a) { do B; return;}
do C.

What is the expected behavior?
if !a, do B then return

What went wrong?
return ignored, thus C executed.

Did this work before? Yes webGl1

Chrome version: 57.0.2987.133  Channel: stable
OS Version: 14.04
Flash Version: Shockwave Flash 25.0 r0

This bug occurs in web GLSL ES since WebGl2.0 , on firefox, chrome and chromium.

in some configurations (probably: divergent branches with only some having a "return"), "return" in "if" is ignored.
see simple proof case here: https://www.shadertoy.com/view/MsScDm
(this is also the cause of several existing shaders no longer working since WebGl2.0 ).
 
Cc: jmukthavaram@chromium.org
Labels: Needs-Feedback
Thanks for filing the issue.
Could you please provide us a sample file/test case to triage the issue further.

Comment 2 Deleted

I did provide an URL in my description ;-)
(NB: the bug at least appears with nVIDIA GPUs).

Project Member

Comment 4 by sheriffbot@chromium.org, Apr 20 2017

Labels: -Needs-Feedback
Thank you for providing more feedback. Adding requester "jmukthavaram@chromium.org" to the cc list and removing "Needs-Feedback" label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Cc: brajkumar@chromium.org
Components: Internals>GPU
Labels: Needs-Feedback Needs-Milestone
Unable to reproduce this issue on Ubuntu 14.04 using chrome latest stable #61.0.3163.100. 

fabrice.neyret@ Could you please confirm is this issue still observed on latest stable #61.0.3163.100? If yes, provide chrome://gpu details for further triage.

Thanks!
seems to have been solved. Same for return in switch.

For many other glslES bugs (either on linux or all OS), see acid tests here: https://www.shadertoy.com/results?query=bug&sort=newest&filter=
(should I really fill a form for each ? moreover it's unclear to me where to do it, since chippers + drivers + OS + browsers are concerned. Besides, "web-glsl" seems to differ to desktop-glsl bugs. )
Project Member

Comment 7 by sheriffbot@chromium.org, Sep 28 2017

Labels: -Needs-Feedback
Thank you for providing more feedback. Adding requester "brajkumar@chromium.org" to the cc list and removing "Needs-Feedback" label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Cc: kbr@chromium.org
Components: Blink>WebGL
kbr@ do you think there are specific actions to take here?

Comment 9 by zmo@chromium.org, Oct 6 2017

Labels: Needs-Feedback
Can't reproduce on my Mac (AMD) and Linux (NVidia) in Chrome Stable (M61)

You will have to provide about:gpu from your Chrome on where you can reproduce this issue.

Either it's fixed already or it's a driver specific bug.
since it seems to be solved ( 6 month later), no, there is no action to do on this very bug.
Many more are acid tested here  https://www.shadertoy.com/results?query=bug&sort=newest , but they are most probably due to drivers than to the browser.
Project Member

Comment 11 by sheriffbot@chromium.org, Oct 6 2017

Cc: zmo@chromium.org
Labels: -Needs-Feedback
Thank you for providing more feedback. Adding requester "zmo@chromium.org" to the cc list and removing "Needs-Feedback" label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 12 by zmo@chromium.org, Oct 6 2017

Cc: kainino@chromium.org
Status: Fixed (was: Unconfirmed)
Thanks. I looked at a few of them, and I feel we should address these bugs, either work around them in browser (ANGLE's shader translator), or report them to driver vendors to get them fixed.

Do you think you are willing to file crbug.com bugs one for each these bugs? With shader source (reduced to minimum) in the bug report, and chrome's about:gpu content of the platform that can reproduce the bug. Especially when you discover new bugs.

That's the only way we can keep improving drivers and browsers conformance. On Chrome GPU team side, we don't have the bandwidth right now to keep track of client sites, so we can only react to bugs reported to us.

In the meantime, closing this as Fixed.
Ok, I just enter a bunch of them.

- it's never clear where to declare these bugs (so many layers involved ! ), so it's very cool if you can reroute where it should, depending on the very case.

- it was not easy to guess the right tags here. I opted for "Content". But "it's the browser" is ambiguous (are Angle and drivers considered part of it ?). And the question "is it ok on other browsers" stucks us when several yes and several no, typically when it's a windows vs linux+Mac(i.e. openGl) issue.

thanks !
Thanks Fabrice. Good tags to use are Internals>GPU, Blink>WebGL in components. I added those to your issues to make them more visible.
thanks for that (I didn't even saw where I could have set these :-) )

Sign in to add a comment