Issue metadata
Sign in to add a comment
|
Regression: OPTGROUP element isn't rendered correctly.
Reported by
sans...@etouch.net,
Apr 17 2017
|
||||||||||||||||||||||
Issue descriptionChrome Version: 60.0.3073.0 aadb33c433f1cf2eb17e4862215c9857c7e26dd1-refs/heads/master@{#464873} OS: Windows 10 (Laptop touch device) Steps: 1. Launch Chrome and open devtools on NTP, press ESC key to open console 2. Under Console tab, click on 'Info' drop down and observe Actual: Drop down list is not seen properly and blue hover highlight overlaps other options Expected: Drop down list should be seen properly and hover highlight should not overlap other options This is regression issue, broken in ‘M 59’ and below is bisect info : Good build:59.0.3067.0 Bad build: 59.0.3068.1 Narrow bisect: https://chromium.googlesource.com/chromium/src/+log/0bd89391dc79ae15c314d632f5829b0d430cf9af..7a16f508ad712bc38ff72e979dd5155a4015c320?pretty=fuller&n=100 Suspecting: r463194 ? Please help to re-assign if your change is not the cause for this issue. Note: 1. This is Windows 10 (Laptop device) specific issue and not seen other OS like Win 7, 8 monitor device, Mac and Linux 2. Issue is also seen for Network throttling drop down of Network conditions tab, Sensors,etc
,
Apr 17 2017
,
Apr 17 2017
,
Apr 18 2017
,
Apr 18 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/db9cef9964f34067223f3d95f8a0206a3d07254b commit db9cef9964f34067223f3d95f8a0206a3d07254b Author: tkent <tkent@chromium.org> Date: Tue Apr 18 08:00:54 2017 SELECT popup: Fix OPTGROUP rendering on a device with a touch-screen. We should not apply display:flex to OPTGROUP elements in popups. BUG= 712107 Review-Url: https://codereview.chromium.org/2824123002 Cr-Commit-Position: refs/heads/master@{#465174} [modify] https://crrev.com/db9cef9964f34067223f3d95f8a0206a3d07254b/third_party/WebKit/LayoutTests/TestExpectations [modify] https://crrev.com/db9cef9964f34067223f3d95f8a0206a3d07254b/third_party/WebKit/LayoutTests/fast/forms/select-popup/popup-menu-appearance-coarse.html [modify] https://crrev.com/db9cef9964f34067223f3d95f8a0206a3d07254b/third_party/WebKit/LayoutTests/platform/linux/fast/forms/select-popup/popup-menu-appearance-coarse-expected.png [modify] https://crrev.com/db9cef9964f34067223f3d95f8a0206a3d07254b/third_party/WebKit/Source/web/PopupMenuImpl.cpp
,
Apr 18 2017
,
Apr 18 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0c4c224d84bac1260a588596e95fecbc5eed8528 commit 0c4c224d84bac1260a588596e95fecbc5eed8528 Author: Rebaseline Bot <blink-rebaseline-bot@chromium.org> Date: Tue Apr 18 09:34:00 2017 Auto-rebaseline for r465174 Build: https://build.chromium.org/p/chromium.infra.cron/builders/rebaseline-o-matic/builds/665988 https://chromium.googlesource.com/chromium/src/+/db9cef9964f34 BUG= 712107 TBR=tkent@chromium.org Review-Url: https://codereview.chromium.org/2820333002 . Cr-Commit-Position: refs/heads/master@{#465187} [modify] https://crrev.com/0c4c224d84bac1260a588596e95fecbc5eed8528/third_party/WebKit/LayoutTests/TestExpectations [modify] https://crrev.com/0c4c224d84bac1260a588596e95fecbc5eed8528/third_party/WebKit/LayoutTests/platform/win/fast/forms/select-popup/popup-menu-appearance-coarse-expected.png
,
Apr 19 2017
Your change meets the bar and is auto-approved for M59. Please go ahead and merge the CL to branch 3071 manually. Please contact milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), gkihumba@(ChromeOS), Abdul Syed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Apr 20 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4c079a58c05a2b03aca24fdcfae77bcb5c7ceeb0 commit 4c079a58c05a2b03aca24fdcfae77bcb5c7ceeb0 Author: Kent Tamura <tkent@chromium.org> Date: Thu Apr 20 00:54:23 2017 Merge "SELECT popup: Fix OPTGROUP rendering on a device with a touch-screen." to M59 We should not apply display:flex to OPTGROUP elements in popups. BUG= 712107 Review-Url: https://codereview.chromium.org/2824123002 Cr-Commit-Position: refs/heads/master@{#465174} (cherry picked from commit db9cef9964f34067223f3d95f8a0206a3d07254b) Review-Url: https://codereview.chromium.org/2827183002 . Cr-Commit-Position: refs/branch-heads/3071@{#75} Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641} [modify] https://crrev.com/4c079a58c05a2b03aca24fdcfae77bcb5c7ceeb0/third_party/WebKit/LayoutTests/TestExpectations [modify] https://crrev.com/4c079a58c05a2b03aca24fdcfae77bcb5c7ceeb0/third_party/WebKit/LayoutTests/fast/forms/select-popup/popup-menu-appearance-coarse.html [modify] https://crrev.com/4c079a58c05a2b03aca24fdcfae77bcb5c7ceeb0/third_party/WebKit/LayoutTests/platform/linux/fast/forms/select-popup/popup-menu-appearance-coarse-expected.png [modify] https://crrev.com/4c079a58c05a2b03aca24fdcfae77bcb5c7ceeb0/third_party/WebKit/Source/web/PopupMenuImpl.cpp
,
Apr 22 2017
Issue 714068 has been merged into this issue.
,
Apr 25 2017
Rechecked this issue on chrome version 59.0.3071.25 on Windows 10 touch machine. Attached is a screen shot for the current behavior observed, Highlight is not overlapping with other options displayed in dev tool. Can this be considered as fixed. Please confirm
,
Apr 25 2017
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by tkent@chromium.org
, Apr 17 2017Labels: ReleaseBlock-Beta