New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 712094 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Jul 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows
Pri: 1
Type: Bug-Regression

Blocking:
issue 715889



Sign in to add a comment

Regression:Add language navigates to the top after selecting language

Project Member Reported by sahitya....@techmahindra.com, Apr 17 2017

Issue description

Chrome Version: 60.0.3072.0
OS: Ubuntu 14.04,Windows

What steps will reproduce the problem?
(1)Launch cvhrome and navigate to the chrome://md-settings and insrease font size to very large.
(2)Navigate to the add langugae and clcik on an language and press down arrow and select any language (refer video)

Expected Result:Page should stay even after selecting the language

Actual Result:Navigate to the top aftre selecting the language.

This is regression issue broken in M-60

Manual Bisect info:
====================
Good Build:59.0.3071.0
Bad Build:60.0.3072.0



 
Expectedautoscroll.ogv
3.7 MB View Download
Actual Languages issue.ogv
5.3 MB View Download
Cc: yosin@chromium.org
Owner: hu...@opera.com
Status: Assigned (was: Unconfirmed)
Bisect Information:
---------------------
You are probably looking for a change made after 464697 (known good), but no later than 464698 (first known bad).

Change Log URL:
------------------
 https://chromium.googlesource.com/chromium/src/+log/188c1056bbfb9c98eca691c12f5641d4204f6066..0f65d25a4097959d977dbb1077717323438240a6

From the above change log suspecting below change
Review-Url:https://codereview.chromium.org/2616623002+

@hugoh:Could you please look into the issue, pardon me if it has nothing to do with your changes and if possible please assign it to concern owner.

Thanks in Advance.!
Labels: -Needs-Bisect hasbisect

Comment 3 by hu...@opera.com, Apr 18 2017

Cc: dpa...@chromium.org
When I pick a language using Space bar -> no scroll to top.
When I pick a language using Enter key -> scroll to top.

dpapad@, can it be that this <form> gets "submitted" on Enter and that resets focus to top?

Comment 4 by hu...@opera.com, Apr 18 2017

Cc: -dpa...@chromium.org hu...@opera.com
Owner: dpa...@chromium.org
I'm assigning this over to you @dpapad because I hope this can be solved within md-settings.

Comment 5 by dpa...@chromium.org, Apr 18 2017

Cc: dbeam@chromium.org
Components: -UI UI>Settings
Labels: Proj-MaterialDesign-WebUI
Owner: ----
Status: Untriaged (was: Assigned)
@hugoh: There is no <form> involved in this code. It is just a series of checkboxes, see https://codereview.chromium.org/2616623002.

At first glance it does not seem that it is fixable within MD Settings. @hugoh, can you take a look? I read the CL description, but could not see the connection with the bug that is reported here. Do you have any insight?

Comment 6 by hu...@opera.com, Apr 19 2017

I don't see the connection either :/ I don't understand md-settings' WebComponents so it is hard for me to boil this down to a minimal test case. Do they listen for 'selectionchange'? If not, this might be something related to painting. I will take a look.

Comment 7 by hu...@opera.com, Apr 19 2017

If I re-introduce ClearSelectionIfNeeded() in FocusController.cpp I don't see the bug. That means md-settings assumes that selection is coupled with focus. After my CL, the frame's selection can reside in an element that doesn't have focus and this selection can be invisible. 

Here no text was selected, so FrameSelection represents the caret placed at the <settings-subpage-search>'s <paper-input-container>'s <input type="search">. Why does md-settings scroll back up to this selection on Enter? 

Comment 8 by dpa...@chromium.org, Apr 20 2017

Cc: dpa...@chromium.org
Owner: dpa...@chromium.org
Status: Started (was: Untriaged)
Strangely, I did not receive any email for your comment#6 and 7. I'll attempt to rule out a Polymer component misbehaving, or <settings-subpage-search> stealing focus and therefore forcing a scroll. Will post updates once I have any.

Comment 9 by hu...@opera.com, Apr 20 2017

 crbug.com/712986  is very similar, it's also shows a random "scroll jump" in md-settings after my CL. I wish we'd have smaller test cases for these bugs.
Minimal repro at https://jsfiddle.net/yfqdxo0b/2/. It only happens with paper-checkbox, but not with native checkbox element.

Notice that the native checkbox does not change state on "Enter", whereas the paper-checkbox does. I am suspecting that some of the many behaviors inherited by paper-checkbox might be the culprit?

Polymer.PaperCheckedElementBehavior
 - Polymer.PaperInkyFocusBehavior
   - Polymer.IronButtonState,
   - Polymer.IronControlState,
   - Polymer.PaperRippleBehavior,
   - Polymer.PaperInkyFocusBehaviorImpl
 - Polymer.IronCheckedElementBehavior,
   - Polymer.IronFormElementBehavior,
   - Polymer.IronValidatableBehavior,
   - Polymer.IronCheckedElementBehaviorImpl
 - Polymer.PaperCheckedElementBehaviorImpl

@dbeam: Maybe we should  consider rolling our own checkbox that does not inherit from so many behaviors. Current paper-checkbox seems that it has a lot of unnecessary code attached to it.

Labels: Hotlist-MD-Settings-General
dbeam, will your new checkbox fix this issue?
Cc: scottchen@chromium.org
@hugoh: I spotted one more regression happening because of the same original CL (see comment#1).

Repro steps:
1) Navigate to chrome://md-settings/searchEngines?search=search+engines
2) Wait for the spinner to finish.
3) Tab to the 1st element on the list.
4) press down arrow until reaching the end of the list (or some intermediate element)
5) press up arrow, 2-3 times.

Expected: Focus travels up.
Actual: Focus is lost!

It seems that the original change is breaking iron-list in some way we have not been able to explain yet.
unexpected_loss_of_focus.mp4
56.3 KB View Download

Comment 13 by hu...@opera.com, Apr 25 2017

dpapad@, since this bug involves random scrolling, this bug and  https://crbug.com/714535 , feel very related to  https://crbug.com/712986 . 

dpapad@, I cannot explain the lost focus either.

Comment 14 by hu...@opera.com, Apr 25 2017

 Issue 715000  has been merged into this issue.
@hugoh: Are you investigating the problem?

Should we revert r464698? There are at least 3 bugs caused by that revision, and no candidate fix has been proposed yet.

Comment 16 Deleted

Comment 17 by hu...@opera.com, Apr 26 2017

dpapad@, the problem you describe in #12 is a duplicate of  http://crbug.com/715038  (focus is not lost, but moved to the <input>-field).

I work at very low speed as I am allocated full time to internal projects. I let yosin@ decide if we should revert. 

Comment 18 by yosin@chromium.org, Apr 27 2017

Blocking: 715889

Comment 19 by hu...@opera.com, Jul 13 2017

Status: Fixed (was: Started)
I'm not reproducing this on 60.0.3112.66. Marking as Fixed to ease book keeping. 

dpapad@, tell me if you have any other information.

Sign in to add a comment