New issue
Advanced search Search tips

Issue 712077 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2017
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

flag --also-run-disabled-tests doesn't work for disabled system health story

Project Member Reported by vovoy@chromium.org, Apr 17 2017

Issue description

~/src/tools/perf$ ./run_benchmark system_health.memory_desktop --browser=reference --device=desktop --story-filter=multitab --also-run-disabled-tests
[ RUN      ] multitab:misc:typical24@{'case': 'multitab', 'group': 'misc'}
===== SKIPPING TEST multitab:misc:typical24: Skipped because story is not supported (SharedState.CanRunStory() returns False). =====
[       OK ] multitab:misc:typical24@{'case': 'multitab', 'group': 'misc'} (2960 ms)

 

Comment 1 by vovoy@chromium.org, Apr 17 2017

Owner: vovoy@chromium.org
Status: Started (was: Untriaged)
Project Member

Comment 2 by bugdroid1@chromium.org, Apr 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9dfab42426da70b9b8a8496800155194e0b77851

commit 9dfab42426da70b9b8a8496800155194e0b77851
Author: vovoy <vovoy@chromium.org>
Date: Tue Apr 18 02:29:47 2017

Support flag --also-run-disabled-tests for system health tests

BUG= 712077 

Review-Url: https://codereview.chromium.org/2819193002
Cr-Commit-Position: refs/heads/master@{#465103}

[modify] https://crrev.com/9dfab42426da70b9b8a8496800155194e0b77851/tools/perf/page_sets/system_health/system_health_story.py

I guess it's better to do than to just discuss about it. Thanks for fixing https://github.com/catapult-project/catapult/issues/3053 :)

Comment 4 by vovoy@chromium.org, Apr 25 2017

Status: Fixed (was: Started)

Sign in to add a comment