New issue
Advanced search Search tips

Issue 712074 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 3
Type: Bug


Participants' hotlists:
Payments-Maintenance

Show other hotlists

Other hotlists containing this issue:
Payment-Conversion


Sign in to add a comment

[Payments] Desktop: editor title should change if editing vs adding an item

Project Member Reported by ma...@chromium.org, Apr 17 2017

Issue description

In credit card/ shipping address editors we do not vary the titles depending on add vs edit, which is wrong.
 

Comment 1 by ma...@chromium.org, Apr 25 2017

Cc: bbergher@chromium.org
Spec that I have in mind for the title of editors.

* If the item is complete, "edit <item>" e.g. "edit card"
* If the item is missing one thing, "Add <thing>" e.g. "Add phone number"
* If the item is missing several things, "More information required"

Does that sound good Bruno?
Project Member

Comment 2 by bugdroid1@chromium.org, Apr 25 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/752dfc391d00506d24824d2a1b35c5224f265e4d

commit 752dfc391d00506d24824d2a1b35c5224f265e4d
Author: mathp <mathp@chromium.org>
Date: Tue Apr 25 13:38:01 2017

[Payments] Update some editor titles to reflect missing information

Title of editor should reflect missing information, or a more generic
message otherwise.

BUG=712074
TEST=manual

Review-Url: https://codereview.chromium.org/2841603004
Cr-Commit-Position: refs/heads/master@{#466972}

[modify] https://crrev.com/752dfc391d00506d24824d2a1b35c5224f265e4d/chrome/android/java/src/org/chromium/chrome/browser/payments/AddressEditor.java
[modify] https://crrev.com/752dfc391d00506d24824d2a1b35c5224f265e4d/chrome/android/java/src/org/chromium/chrome/browser/payments/AutofillAddress.java
[modify] https://crrev.com/752dfc391d00506d24824d2a1b35c5224f265e4d/chrome/android/java/src/org/chromium/chrome/browser/payments/CardEditor.java
[modify] https://crrev.com/752dfc391d00506d24824d2a1b35c5224f265e4d/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/SectionInformation.java
[modify] https://crrev.com/752dfc391d00506d24824d2a1b35c5224f265e4d/chrome/app/generated_resources.grd
[modify] https://crrev.com/752dfc391d00506d24824d2a1b35c5224f265e4d/chrome/browser/ui/views/payments/contact_info_editor_view_controller.cc
[modify] https://crrev.com/752dfc391d00506d24824d2a1b35c5224f265e4d/chrome/browser/ui/views/payments/credit_card_editor_view_controller.cc
[modify] https://crrev.com/752dfc391d00506d24824d2a1b35c5224f265e4d/chrome/browser/ui/views/payments/order_summary_view_controller.cc
[modify] https://crrev.com/752dfc391d00506d24824d2a1b35c5224f265e4d/chrome/browser/ui/views/payments/payment_sheet_view_controller.cc
[modify] https://crrev.com/752dfc391d00506d24824d2a1b35c5224f265e4d/chrome/browser/ui/views/payments/shipping_address_editor_view_controller.cc
[modify] https://crrev.com/752dfc391d00506d24824d2a1b35c5224f265e4d/components/payments_strings.grdp

Comment 3 by ma...@chromium.org, Apr 25 2017

Owner: tmartino@chromium.org
Assigning to Tommy for the remainder because he is working on completion messages for addresses.
SGTM!
Components: -UI>Browser>Autofill>Payments UI>Browser>Payments
Cc: -bbergher@chromium.org

Sign in to add a comment