No expected result for virtual/layout_ng/external/wpt/css/CSS2/linebox/inline-formatting-context-010b.xht |
|||
Issue descriptionSTEPS: 1. Change "[ Skip ]" to "[ Failure ]" for: virtual/layout_ng/external/wpt/css/CSS2/linebox/inline-formatting-context-010b.xht 2. Run tests RESULT: Tests that had no expected results: virtual/layout_ng/external/wpt/css/CSS2/linebox/inline-formatting-context-010b.xht Haven't looked into why yet, but looks strange, probably something wrong in the test runner.
,
Apr 17 2017
Ok, thank you for the info. So new ones are automatically added to skip to NeverFixTests, but existing ones need to be added manually? I can't find why we run this as a manual test while other manual tests such as vertical-align-118.xht doesn't show up. I can't find it in NeverFixTests nor in TestExpectations, unless I'm still missing something?
,
Apr 17 2017
WPT_BASE_MANIFEST.json differs for these two flies:
a. vertical-align-118.xht is listed under "reftest", but without ref files (what does this mean?)
"css/CSS2/linebox/vertical-align-118.xht": [
[
"/css/CSS2/linebox/vertical-align-118.xht",
{}
]
],
b. inline-formatting-context-010b.xht is listed under "manual":
"css/CSS2/linebox/inline-formatting-context-010b.xht": [
[
"/css/CSS2/linebox/inline-formatting-context-010b.xht",
{}
]
],
and under "paths":
"css/CSS2/linebox/inline-formatting-context-010b.xht": [
"aaf18f6578c080188562ef8dbbfcabb8d7a116b8",
"manual"
],
The source at wpt:
https://github.com/w3c/web-platform-tests/blob/master/css/CSS2/linebox/vertical-align-118.xht
https://github.com/w3c/web-platform-tests/blob/master/css/CSS2/linebox/inline-formatting-context-010b.xht
Both looks like manual tests to me, is this a manifest generator problem?
I'm still not sure where WPT_BASE_MANIFEST.json comes from, I can't find it in wpt. It's a file we generate, using a common tool?
,
Apr 18 2017
It looks like vertical-align-118.xht is under "visual", which means that it should be treated like a pixel test. I believe that we might ignore "visual" tests, or treat them as pixel tests. "css/CSS2/linebox/vertical-align-118.xht" The logic for where these tests belong is in: https://github.com/w3c/wpt-tools/blob/master/manifest/sourcefile.py and WPT_BASE_MANIFESt.json is a file we generate using the manifest generator tool from wpt :-)
,
Mar 26 2018
It's a manual test and has been marked as WontFix in NeverFixTests. Closing the bug. |
|||
►
Sign in to add a comment |
|||
Comment 1 by qyears...@chromium.org
, Apr 16 2017