New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 711994 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Apr 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug



Sign in to add a comment

Display the first item for list extensions notifications in mac native.

Project Member Reported by miguelg@chromium.org, Apr 16 2017

Issue description

This is just a placeholder bug to request the merge of https://codereview.chromium.org/2822453002 since it landed a few hours after branch point.


 
Components: UI>Notifications
Labels: Merge-Request-59
Already working as expected in canary
Project Member

Comment 3 by sheriffbot@chromium.org, Apr 19 2017

Labels: -Merge-Request-59 Hotlist-Merge-Approved Merge-Approved-59
Your change meets the bar and is auto-approved for M59. Please go ahead and merge the CL to branch 3071 manually. Please contact milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), gkihumba@(ChromeOS), Abdul Syed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 4 Deleted

 miguelg@ can you please merge request and then manually merge the Cl to M59 branch which is 3071, So that we can pick the Cl for next M59 release.
Project Member

Comment 6 by bugdroid1@chromium.org, Apr 21 2017

Labels: -merge-approved-59 merge-merged-3071
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9f156f070a947178211ebccf6b00611cb7f4ee99

commit 9f156f070a947178211ebccf6b00611cb7f4ee99
Author: Miguel Garcia <miguelg@chromium.org>
Date: Fri Apr 21 06:50:33 2017

Display the first item for list mac native notifications

BUG= 711994 

Review-Url: https://codereview.chromium.org/2822453002
Cr-Commit-Position: refs/heads/master@{#464874}
(cherry picked from commit c226012b866b916e187030737404c6ed6ccfe15a)

Review-Url: https://codereview.chromium.org/2836573002 .
Cr-Commit-Position: refs/branch-heads/3071@{#115}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}

[modify] https://crrev.com/9f156f070a947178211ebccf6b00611cb7f4ee99/chrome/browser/notifications/notification_platform_bridge_mac.mm

Status: Fixed (was: Assigned)

Sign in to add a comment