land of https://codereview.chromium.org/2801513002/ makes //components/webdata_services depends on //components/payments/content, however this is not allowed for ios, it would be better to break it
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b1b326893990633387f90546607ce8271d151a3a commit b1b326893990633387f90546607ce8271d151a3a Author: gogerald <gogerald@chromium.org> Date: Sun Apr 16 03:20:59 2017 move //components/payments/content/*.mojom files to //components/payments/mojom To break dependency of //components/webdata_services on //components/payments/content after landing https://codereview.chromium.org/2801513002/ BUG= 711952 Review-Url: https://codereview.chromium.org/2811593009 Cr-Commit-Position: refs/heads/master@{#464877} [modify] https://crrev.com/b1b326893990633387f90546607ce8271d151a3a/chrome/android/BUILD.gn [modify] https://crrev.com/b1b326893990633387f90546607ce8271d151a3a/chrome/browser/BUILD.gn [modify] https://crrev.com/b1b326893990633387f90546607ce8271d151a3a/chrome/browser/android/payments/service_worker_payment_app_bridge.cc [modify] https://crrev.com/b1b326893990633387f90546607ce8271d151a3a/chrome/browser/payments/payment_request_factory.h [modify] https://crrev.com/b1b326893990633387f90546607ce8271d151a3a/chrome/browser/ui/views/payments/payment_request_browsertest_base.h [modify] https://crrev.com/b1b326893990633387f90546607ce8271d151a3a/chrome/browser/ui/views/payments/payment_request_views_util.h [modify] https://crrev.com/b1b326893990633387f90546607ce8271d151a3a/components/payments/android/BUILD.gn [modify] https://crrev.com/b1b326893990633387f90546607ce8271d151a3a/components/payments/android/DEPS [modify] https://crrev.com/b1b326893990633387f90546607ce8271d151a3a/components/payments/android/web_app_manifest_section_table.h [modify] https://crrev.com/b1b326893990633387f90546607ce8271d151a3a/components/payments/content/BUILD.gn [modify] https://crrev.com/b1b326893990633387f90546607ce8271d151a3a/components/payments/content/android/BUILD.gn [modify] https://crrev.com/b1b326893990633387f90546607ce8271d151a3a/components/payments/content/android/payment_details_validation_android.cc [modify] https://crrev.com/b1b326893990633387f90546607ce8271d151a3a/components/payments/content/payment_details_validation.cc [modify] https://crrev.com/b1b326893990633387f90546607ce8271d151a3a/components/payments/content/payment_details_validation.h [modify] https://crrev.com/b1b326893990633387f90546607ce8271d151a3a/components/payments/content/payment_manifest_parser_host.h [modify] https://crrev.com/b1b326893990633387f90546607ce8271d151a3a/components/payments/content/payment_request.h [modify] https://crrev.com/b1b326893990633387f90546607ce8271d151a3a/components/payments/content/payment_request_spec.h [modify] https://crrev.com/b1b326893990633387f90546607ce8271d151a3a/components/payments/content/payment_request_spec_unittest.cc [modify] https://crrev.com/b1b326893990633387f90546607ce8271d151a3a/components/payments/content/payment_request_state.h [modify] https://crrev.com/b1b326893990633387f90546607ce8271d151a3a/components/payments/content/payment_request_state_unittest.cc [modify] https://crrev.com/b1b326893990633387f90546607ce8271d151a3a/components/payments/content/payment_request_web_contents_manager.h [modify] https://crrev.com/b1b326893990633387f90546607ce8271d151a3a/components/payments/content/payment_response_helper.h [modify] https://crrev.com/b1b326893990633387f90546607ce8271d151a3a/components/payments/content/payment_response_helper_unittest.cc [modify] https://crrev.com/b1b326893990633387f90546607ce8271d151a3a/components/payments/content/payments_validators.h [modify] https://crrev.com/b1b326893990633387f90546607ce8271d151a3a/components/payments/content/utility/BUILD.gn [modify] https://crrev.com/b1b326893990633387f90546607ce8271d151a3a/components/payments/content/utility/payment_manifest_parser.h [add] https://crrev.com/b1b326893990633387f90546607ce8271d151a3a/components/payments/mojom/BUILD.gn [rename] https://crrev.com/b1b326893990633387f90546607ce8271d151a3a/components/payments/mojom/OWNERS [rename] https://crrev.com/b1b326893990633387f90546607ce8271d151a3a/components/payments/mojom/payment_app.mojom [rename] https://crrev.com/b1b326893990633387f90546607ce8271d151a3a/components/payments/mojom/payment_manifest_parser.mojom [rename] https://crrev.com/b1b326893990633387f90546607ce8271d151a3a/components/payments/mojom/payment_request.mojom [modify] https://crrev.com/b1b326893990633387f90546607ce8271d151a3a/content/browser/BUILD.gn [modify] https://crrev.com/b1b326893990633387f90546607ce8271d151a3a/content/browser/payments/payment_app_browsertest.cc [modify] https://crrev.com/b1b326893990633387f90546607ce8271d151a3a/content/browser/payments/payment_app_content_unittest_base.h [modify] https://crrev.com/b1b326893990633387f90546607ce8271d151a3a/content/browser/payments/payment_app_context_impl.h [modify] https://crrev.com/b1b326893990633387f90546607ce8271d151a3a/content/browser/payments/payment_app_database.h [modify] https://crrev.com/b1b326893990633387f90546607ce8271d151a3a/content/browser/payments/payment_app_provider_impl_unittest.cc [modify] https://crrev.com/b1b326893990633387f90546607ce8271d151a3a/content/browser/payments/payment_manager.h [modify] https://crrev.com/b1b326893990633387f90546607ce8271d151a3a/content/browser/payments/payment_manager_unittest.cc [modify] https://crrev.com/b1b326893990633387f90546607ce8271d151a3a/content/common/BUILD.gn [modify] https://crrev.com/b1b326893990633387f90546607ce8271d151a3a/content/common/service_worker/service_worker_event_dispatcher.mojom [modify] https://crrev.com/b1b326893990633387f90546607ce8271d151a3a/content/public/browser/DEPS [modify] https://crrev.com/b1b326893990633387f90546607ce8271d151a3a/content/public/browser/payment_app_provider.h [modify] https://crrev.com/b1b326893990633387f90546607ce8271d151a3a/content/renderer/BUILD.gn [modify] https://crrev.com/b1b326893990633387f90546607ce8271d151a3a/content/renderer/service_worker/service_worker_context_client.h [modify] https://crrev.com/b1b326893990633387f90546607ce8271d151a3a/content/renderer/service_worker/service_worker_type_converters.h [modify] https://crrev.com/b1b326893990633387f90546607ce8271d151a3a/content/test/BUILD.gn [modify] https://crrev.com/b1b326893990633387f90546607ce8271d151a3a/third_party/WebKit/LayoutTests/payments/resources/payment-request-mock.js [modify] https://crrev.com/b1b326893990633387f90546607ce8271d151a3a/third_party/WebKit/Source/modules/BUILD.gn [modify] https://crrev.com/b1b326893990633387f90546607ce8271d151a3a/third_party/WebKit/Source/modules/payments/BUILD.gn [modify] https://crrev.com/b1b326893990633387f90546607ce8271d151a3a/third_party/WebKit/Source/modules/payments/PaymentAddress.h [modify] https://crrev.com/b1b326893990633387f90546607ce8271d151a3a/third_party/WebKit/Source/modules/payments/PaymentManager.h [modify] https://crrev.com/b1b326893990633387f90546607ce8271d151a3a/third_party/WebKit/Source/modules/payments/PaymentRequest.h [modify] https://crrev.com/b1b326893990633387f90546607ce8271d151a3a/third_party/WebKit/Source/modules/payments/PaymentResponse.h [modify] https://crrev.com/b1b326893990633387f90546607ce8271d151a3a/third_party/WebKit/Source/modules/payments/PaymentTestHelper.h [modify] https://crrev.com/b1b326893990633387f90546607ce8271d151a3a/third_party/WebKit/Source/modules/payments/PaymentsValidators.h [modify] https://crrev.com/b1b326893990633387f90546607ce8271d151a3a/third_party/WebKit/public/BUILD.gn
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/43e1aeed704fc42604340007034035808ac5bb16 commit 43e1aeed704fc42604340007034035808ac5bb16 Author: findit-for-me <findit-for-me@appspot.gserviceaccount.com> Date: Sun Apr 16 03:56:38 2017 Revert of [Payments] move //components/payments/content/*.mojom files to //components/payments/mojom (patchset #6 id:180001 of https://codereview.chromium.org/2811593009/ ) Reason for revert: Findit(https://goo.gl/kROfz5) identified CL at revision 464877 as the culprit for failures in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtL2IxYjMyNjg5Mzk5MDYzMzM4N2Y5MDU0NjYwN2NlODI3MWQxNTFhM2EM Original issue's description: > move //components/payments/content/*.mojom files to //components/payments/mojom > > To break dependency of //components/webdata_services on //components/payments/content after > landing https://codereview.chromium.org/2801513002/ > > BUG= 711952 > > Review-Url: https://codereview.chromium.org/2811593009 > Cr-Commit-Position: refs/heads/master@{#464877} > Committed: https://chromium.googlesource.com/chromium/src/+/b1b326893990633387f90546607ce8271d151a3a TBR=rouslan@chromium.org,cpu@chromium.org,dcheng@chromium.org,gogerald@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= 711952 Review-Url: https://codereview.chromium.org/2820033002 Cr-Commit-Position: refs/heads/master@{#464880} [modify] https://crrev.com/43e1aeed704fc42604340007034035808ac5bb16/chrome/android/BUILD.gn [modify] https://crrev.com/43e1aeed704fc42604340007034035808ac5bb16/chrome/browser/BUILD.gn [modify] https://crrev.com/43e1aeed704fc42604340007034035808ac5bb16/chrome/browser/android/payments/service_worker_payment_app_bridge.cc [modify] https://crrev.com/43e1aeed704fc42604340007034035808ac5bb16/chrome/browser/payments/payment_request_factory.h [modify] https://crrev.com/43e1aeed704fc42604340007034035808ac5bb16/chrome/browser/ui/views/payments/payment_request_browsertest_base.h [modify] https://crrev.com/43e1aeed704fc42604340007034035808ac5bb16/chrome/browser/ui/views/payments/payment_request_views_util.h [modify] https://crrev.com/43e1aeed704fc42604340007034035808ac5bb16/components/payments/android/BUILD.gn [modify] https://crrev.com/43e1aeed704fc42604340007034035808ac5bb16/components/payments/android/DEPS [modify] https://crrev.com/43e1aeed704fc42604340007034035808ac5bb16/components/payments/android/web_app_manifest_section_table.h [modify] https://crrev.com/43e1aeed704fc42604340007034035808ac5bb16/components/payments/content/BUILD.gn [rename] https://crrev.com/43e1aeed704fc42604340007034035808ac5bb16/components/payments/content/OWNERS [modify] https://crrev.com/43e1aeed704fc42604340007034035808ac5bb16/components/payments/content/android/BUILD.gn [modify] https://crrev.com/43e1aeed704fc42604340007034035808ac5bb16/components/payments/content/android/payment_details_validation_android.cc [rename] https://crrev.com/43e1aeed704fc42604340007034035808ac5bb16/components/payments/content/payment_app.mojom [modify] https://crrev.com/43e1aeed704fc42604340007034035808ac5bb16/components/payments/content/payment_details_validation.cc [modify] https://crrev.com/43e1aeed704fc42604340007034035808ac5bb16/components/payments/content/payment_details_validation.h [rename] https://crrev.com/43e1aeed704fc42604340007034035808ac5bb16/components/payments/content/payment_manifest_parser.mojom [modify] https://crrev.com/43e1aeed704fc42604340007034035808ac5bb16/components/payments/content/payment_manifest_parser_host.h [modify] https://crrev.com/43e1aeed704fc42604340007034035808ac5bb16/components/payments/content/payment_request.h [rename] https://crrev.com/43e1aeed704fc42604340007034035808ac5bb16/components/payments/content/payment_request.mojom [modify] https://crrev.com/43e1aeed704fc42604340007034035808ac5bb16/components/payments/content/payment_request_spec.h [modify] https://crrev.com/43e1aeed704fc42604340007034035808ac5bb16/components/payments/content/payment_request_spec_unittest.cc [modify] https://crrev.com/43e1aeed704fc42604340007034035808ac5bb16/components/payments/content/payment_request_state.h [modify] https://crrev.com/43e1aeed704fc42604340007034035808ac5bb16/components/payments/content/payment_request_state_unittest.cc [modify] https://crrev.com/43e1aeed704fc42604340007034035808ac5bb16/components/payments/content/payment_request_web_contents_manager.h [modify] https://crrev.com/43e1aeed704fc42604340007034035808ac5bb16/components/payments/content/payment_response_helper.h [modify] https://crrev.com/43e1aeed704fc42604340007034035808ac5bb16/components/payments/content/payment_response_helper_unittest.cc [modify] https://crrev.com/43e1aeed704fc42604340007034035808ac5bb16/components/payments/content/payments_validators.h [modify] https://crrev.com/43e1aeed704fc42604340007034035808ac5bb16/components/payments/content/utility/BUILD.gn [modify] https://crrev.com/43e1aeed704fc42604340007034035808ac5bb16/components/payments/content/utility/payment_manifest_parser.h [delete] https://crrev.com/37568714f8eba4d6ff7eaf2257e1a785a80753e6/components/payments/mojom/BUILD.gn [modify] https://crrev.com/43e1aeed704fc42604340007034035808ac5bb16/content/browser/BUILD.gn [modify] https://crrev.com/43e1aeed704fc42604340007034035808ac5bb16/content/browser/payments/payment_app_browsertest.cc [modify] https://crrev.com/43e1aeed704fc42604340007034035808ac5bb16/content/browser/payments/payment_app_content_unittest_base.h [modify] https://crrev.com/43e1aeed704fc42604340007034035808ac5bb16/content/browser/payments/payment_app_context_impl.h [modify] https://crrev.com/43e1aeed704fc42604340007034035808ac5bb16/content/browser/payments/payment_app_database.h [modify] https://crrev.com/43e1aeed704fc42604340007034035808ac5bb16/content/browser/payments/payment_app_provider_impl_unittest.cc [modify] https://crrev.com/43e1aeed704fc42604340007034035808ac5bb16/content/browser/payments/payment_manager.h [modify] https://crrev.com/43e1aeed704fc42604340007034035808ac5bb16/content/browser/payments/payment_manager_unittest.cc [modify] https://crrev.com/43e1aeed704fc42604340007034035808ac5bb16/content/common/BUILD.gn [modify] https://crrev.com/43e1aeed704fc42604340007034035808ac5bb16/content/common/service_worker/service_worker_event_dispatcher.mojom [modify] https://crrev.com/43e1aeed704fc42604340007034035808ac5bb16/content/public/browser/DEPS [modify] https://crrev.com/43e1aeed704fc42604340007034035808ac5bb16/content/public/browser/payment_app_provider.h [modify] https://crrev.com/43e1aeed704fc42604340007034035808ac5bb16/content/renderer/BUILD.gn [modify] https://crrev.com/43e1aeed704fc42604340007034035808ac5bb16/content/renderer/service_worker/service_worker_context_client.h [modify] https://crrev.com/43e1aeed704fc42604340007034035808ac5bb16/content/renderer/service_worker/service_worker_type_converters.h [modify] https://crrev.com/43e1aeed704fc42604340007034035808ac5bb16/content/test/BUILD.gn [modify] https://crrev.com/43e1aeed704fc42604340007034035808ac5bb16/third_party/WebKit/LayoutTests/payments/resources/payment-request-mock.js [modify] https://crrev.com/43e1aeed704fc42604340007034035808ac5bb16/third_party/WebKit/Source/modules/BUILD.gn [modify] https://crrev.com/43e1aeed704fc42604340007034035808ac5bb16/third_party/WebKit/Source/modules/payments/BUILD.gn [modify] https://crrev.com/43e1aeed704fc42604340007034035808ac5bb16/third_party/WebKit/Source/modules/payments/PaymentAddress.h [modify] https://crrev.com/43e1aeed704fc42604340007034035808ac5bb16/third_party/WebKit/Source/modules/payments/PaymentManager.h [modify] https://crrev.com/43e1aeed704fc42604340007034035808ac5bb16/third_party/WebKit/Source/modules/payments/PaymentRequest.h [modify] https://crrev.com/43e1aeed704fc42604340007034035808ac5bb16/third_party/WebKit/Source/modules/payments/PaymentResponse.h [modify] https://crrev.com/43e1aeed704fc42604340007034035808ac5bb16/third_party/WebKit/Source/modules/payments/PaymentTestHelper.h [modify] https://crrev.com/43e1aeed704fc42604340007034035808ac5bb16/third_party/WebKit/Source/modules/payments/PaymentsValidators.h [modify] https://crrev.com/43e1aeed704fc42604340007034035808ac5bb16/third_party/WebKit/public/BUILD.gn
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3e1cedb46b52e6c09243993671a5a0ddb7a4eeed commit 3e1cedb46b52e6c09243993671a5a0ddb7a4eeed Author: gogerald <gogerald@chromium.org> Date: Sun Apr 16 04:15:17 2017 move //components/payments/content/*.mojom files to //components/payments/mojom To break dependency of //components/webdata_services on //components/payments/content after landing https://codereview.chromium.org/2801513002/ BUG= 711952 Review-Url: https://codereview.chromium.org/2811593009 Cr-Original-Commit-Position: refs/heads/master@{#464877} Committed: https://chromium.googlesource.com/chromium/src/+/b1b326893990633387f90546607ce8271d151a3a Review-Url: https://codereview.chromium.org/2811593009 Cr-Commit-Position: refs/heads/master@{#464882} [modify] https://crrev.com/3e1cedb46b52e6c09243993671a5a0ddb7a4eeed/chrome/android/BUILD.gn [modify] https://crrev.com/3e1cedb46b52e6c09243993671a5a0ddb7a4eeed/chrome/browser/BUILD.gn [modify] https://crrev.com/3e1cedb46b52e6c09243993671a5a0ddb7a4eeed/chrome/browser/android/payments/service_worker_payment_app_bridge.cc [modify] https://crrev.com/3e1cedb46b52e6c09243993671a5a0ddb7a4eeed/chrome/browser/payments/payment_request_factory.h [modify] https://crrev.com/3e1cedb46b52e6c09243993671a5a0ddb7a4eeed/chrome/browser/ui/views/payments/payment_request_browsertest_base.h [modify] https://crrev.com/3e1cedb46b52e6c09243993671a5a0ddb7a4eeed/chrome/browser/ui/views/payments/payment_request_views_util.h [modify] https://crrev.com/3e1cedb46b52e6c09243993671a5a0ddb7a4eeed/components/payments/android/BUILD.gn [modify] https://crrev.com/3e1cedb46b52e6c09243993671a5a0ddb7a4eeed/components/payments/android/DEPS [modify] https://crrev.com/3e1cedb46b52e6c09243993671a5a0ddb7a4eeed/components/payments/android/web_app_manifest_section_table.h [modify] https://crrev.com/3e1cedb46b52e6c09243993671a5a0ddb7a4eeed/components/payments/content/BUILD.gn [modify] https://crrev.com/3e1cedb46b52e6c09243993671a5a0ddb7a4eeed/components/payments/content/android/BUILD.gn [modify] https://crrev.com/3e1cedb46b52e6c09243993671a5a0ddb7a4eeed/components/payments/content/android/payment_details_validation_android.cc [modify] https://crrev.com/3e1cedb46b52e6c09243993671a5a0ddb7a4eeed/components/payments/content/payment_details_validation.cc [modify] https://crrev.com/3e1cedb46b52e6c09243993671a5a0ddb7a4eeed/components/payments/content/payment_details_validation.h [modify] https://crrev.com/3e1cedb46b52e6c09243993671a5a0ddb7a4eeed/components/payments/content/payment_manifest_parser_host.h [modify] https://crrev.com/3e1cedb46b52e6c09243993671a5a0ddb7a4eeed/components/payments/content/payment_request.h [modify] https://crrev.com/3e1cedb46b52e6c09243993671a5a0ddb7a4eeed/components/payments/content/payment_request_spec.h [modify] https://crrev.com/3e1cedb46b52e6c09243993671a5a0ddb7a4eeed/components/payments/content/payment_request_spec_unittest.cc [modify] https://crrev.com/3e1cedb46b52e6c09243993671a5a0ddb7a4eeed/components/payments/content/payment_request_state.h [modify] https://crrev.com/3e1cedb46b52e6c09243993671a5a0ddb7a4eeed/components/payments/content/payment_request_state_unittest.cc [modify] https://crrev.com/3e1cedb46b52e6c09243993671a5a0ddb7a4eeed/components/payments/content/payment_request_web_contents_manager.h [modify] https://crrev.com/3e1cedb46b52e6c09243993671a5a0ddb7a4eeed/components/payments/content/payment_response_helper.h [modify] https://crrev.com/3e1cedb46b52e6c09243993671a5a0ddb7a4eeed/components/payments/content/payment_response_helper_unittest.cc [modify] https://crrev.com/3e1cedb46b52e6c09243993671a5a0ddb7a4eeed/components/payments/content/payments_validators.h [modify] https://crrev.com/3e1cedb46b52e6c09243993671a5a0ddb7a4eeed/components/payments/content/utility/BUILD.gn [modify] https://crrev.com/3e1cedb46b52e6c09243993671a5a0ddb7a4eeed/components/payments/content/utility/payment_manifest_parser.h [add] https://crrev.com/3e1cedb46b52e6c09243993671a5a0ddb7a4eeed/components/payments/mojom/BUILD.gn [rename] https://crrev.com/3e1cedb46b52e6c09243993671a5a0ddb7a4eeed/components/payments/mojom/OWNERS [rename] https://crrev.com/3e1cedb46b52e6c09243993671a5a0ddb7a4eeed/components/payments/mojom/payment_app.mojom [rename] https://crrev.com/3e1cedb46b52e6c09243993671a5a0ddb7a4eeed/components/payments/mojom/payment_manifest_parser.mojom [rename] https://crrev.com/3e1cedb46b52e6c09243993671a5a0ddb7a4eeed/components/payments/mojom/payment_request.mojom [modify] https://crrev.com/3e1cedb46b52e6c09243993671a5a0ddb7a4eeed/content/browser/BUILD.gn [modify] https://crrev.com/3e1cedb46b52e6c09243993671a5a0ddb7a4eeed/content/browser/payments/payment_app_browsertest.cc [modify] https://crrev.com/3e1cedb46b52e6c09243993671a5a0ddb7a4eeed/content/browser/payments/payment_app_content_unittest_base.h [modify] https://crrev.com/3e1cedb46b52e6c09243993671a5a0ddb7a4eeed/content/browser/payments/payment_app_context_impl.h [modify] https://crrev.com/3e1cedb46b52e6c09243993671a5a0ddb7a4eeed/content/browser/payments/payment_app_database.h [modify] https://crrev.com/3e1cedb46b52e6c09243993671a5a0ddb7a4eeed/content/browser/payments/payment_app_provider_impl_unittest.cc [modify] https://crrev.com/3e1cedb46b52e6c09243993671a5a0ddb7a4eeed/content/browser/payments/payment_manager.h [modify] https://crrev.com/3e1cedb46b52e6c09243993671a5a0ddb7a4eeed/content/browser/payments/payment_manager_unittest.cc [modify] https://crrev.com/3e1cedb46b52e6c09243993671a5a0ddb7a4eeed/content/common/BUILD.gn [modify] https://crrev.com/3e1cedb46b52e6c09243993671a5a0ddb7a4eeed/content/common/service_worker/service_worker_event_dispatcher.mojom [modify] https://crrev.com/3e1cedb46b52e6c09243993671a5a0ddb7a4eeed/content/public/browser/DEPS [modify] https://crrev.com/3e1cedb46b52e6c09243993671a5a0ddb7a4eeed/content/public/browser/payment_app_provider.h [modify] https://crrev.com/3e1cedb46b52e6c09243993671a5a0ddb7a4eeed/content/renderer/BUILD.gn [modify] https://crrev.com/3e1cedb46b52e6c09243993671a5a0ddb7a4eeed/content/renderer/service_worker/service_worker_context_client.h [modify] https://crrev.com/3e1cedb46b52e6c09243993671a5a0ddb7a4eeed/content/renderer/service_worker/service_worker_type_converters.h [modify] https://crrev.com/3e1cedb46b52e6c09243993671a5a0ddb7a4eeed/content/test/BUILD.gn [modify] https://crrev.com/3e1cedb46b52e6c09243993671a5a0ddb7a4eeed/third_party/WebKit/LayoutTests/payments/resources/payment-request-mock.js [modify] https://crrev.com/3e1cedb46b52e6c09243993671a5a0ddb7a4eeed/third_party/WebKit/Source/modules/BUILD.gn [modify] https://crrev.com/3e1cedb46b52e6c09243993671a5a0ddb7a4eeed/third_party/WebKit/Source/modules/payments/BUILD.gn [modify] https://crrev.com/3e1cedb46b52e6c09243993671a5a0ddb7a4eeed/third_party/WebKit/Source/modules/payments/PaymentAddress.h [modify] https://crrev.com/3e1cedb46b52e6c09243993671a5a0ddb7a4eeed/third_party/WebKit/Source/modules/payments/PaymentManager.h [modify] https://crrev.com/3e1cedb46b52e6c09243993671a5a0ddb7a4eeed/third_party/WebKit/Source/modules/payments/PaymentRequest.h [modify] https://crrev.com/3e1cedb46b52e6c09243993671a5a0ddb7a4eeed/third_party/WebKit/Source/modules/payments/PaymentResponse.h [modify] https://crrev.com/3e1cedb46b52e6c09243993671a5a0ddb7a4eeed/third_party/WebKit/Source/modules/payments/PaymentTestHelper.h [modify] https://crrev.com/3e1cedb46b52e6c09243993671a5a0ddb7a4eeed/third_party/WebKit/Source/modules/payments/PaymentsValidators.h [modify] https://crrev.com/3e1cedb46b52e6c09243993671a5a0ddb7a4eeed/third_party/WebKit/public/BUILD.gn
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b3ca3e8898d05b02952d42b1fa873b71dcdaf15b commit b3ca3e8898d05b02952d42b1fa873b71dcdaf15b Author: gogerald <gogerald@chromium.org> Date: Sun Apr 16 04:42:40 2017 Revert of [Payments] move //components/payments/content/*.mojom files to //components/payments/mojom (patchset #6 id:180001 of https://codereview.chromium.org/2811593009/ ) Reason for revert: broke android build Original issue's description: > move //components/payments/content/*.mojom files to //components/payments/mojom > > To break dependency of //components/webdata_services on //components/payments/content after > landing https://codereview.chromium.org/2801513002/ > > BUG= 711952 > > Review-Url: https://codereview.chromium.org/2811593009 > Cr-Original-Commit-Position: refs/heads/master@{#464877} > Committed: https://chromium.googlesource.com/chromium/src/+/b1b326893990633387f90546607ce8271d151a3a > Review-Url: https://codereview.chromium.org/2811593009 > Cr-Commit-Position: refs/heads/master@{#464882} > Committed: https://chromium.googlesource.com/chromium/src/+/3e1cedb46b52e6c09243993671a5a0ddb7a4eeed TBR=rouslan@chromium.org,cpu@chromium.org,dcheng@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= 711952 Review-Url: https://codereview.chromium.org/2816303003 Cr-Commit-Position: refs/heads/master@{#464884} [modify] https://crrev.com/b3ca3e8898d05b02952d42b1fa873b71dcdaf15b/chrome/android/BUILD.gn [modify] https://crrev.com/b3ca3e8898d05b02952d42b1fa873b71dcdaf15b/chrome/browser/BUILD.gn [modify] https://crrev.com/b3ca3e8898d05b02952d42b1fa873b71dcdaf15b/chrome/browser/android/payments/service_worker_payment_app_bridge.cc [modify] https://crrev.com/b3ca3e8898d05b02952d42b1fa873b71dcdaf15b/chrome/browser/payments/payment_request_factory.h [modify] https://crrev.com/b3ca3e8898d05b02952d42b1fa873b71dcdaf15b/chrome/browser/ui/views/payments/payment_request_browsertest_base.h [modify] https://crrev.com/b3ca3e8898d05b02952d42b1fa873b71dcdaf15b/chrome/browser/ui/views/payments/payment_request_views_util.h [modify] https://crrev.com/b3ca3e8898d05b02952d42b1fa873b71dcdaf15b/components/payments/android/BUILD.gn [modify] https://crrev.com/b3ca3e8898d05b02952d42b1fa873b71dcdaf15b/components/payments/android/DEPS [modify] https://crrev.com/b3ca3e8898d05b02952d42b1fa873b71dcdaf15b/components/payments/android/web_app_manifest_section_table.h [modify] https://crrev.com/b3ca3e8898d05b02952d42b1fa873b71dcdaf15b/components/payments/content/BUILD.gn [rename] https://crrev.com/b3ca3e8898d05b02952d42b1fa873b71dcdaf15b/components/payments/content/OWNERS [modify] https://crrev.com/b3ca3e8898d05b02952d42b1fa873b71dcdaf15b/components/payments/content/android/BUILD.gn [modify] https://crrev.com/b3ca3e8898d05b02952d42b1fa873b71dcdaf15b/components/payments/content/android/payment_details_validation_android.cc [rename] https://crrev.com/b3ca3e8898d05b02952d42b1fa873b71dcdaf15b/components/payments/content/payment_app.mojom [modify] https://crrev.com/b3ca3e8898d05b02952d42b1fa873b71dcdaf15b/components/payments/content/payment_details_validation.cc [modify] https://crrev.com/b3ca3e8898d05b02952d42b1fa873b71dcdaf15b/components/payments/content/payment_details_validation.h [rename] https://crrev.com/b3ca3e8898d05b02952d42b1fa873b71dcdaf15b/components/payments/content/payment_manifest_parser.mojom [modify] https://crrev.com/b3ca3e8898d05b02952d42b1fa873b71dcdaf15b/components/payments/content/payment_manifest_parser_host.h [modify] https://crrev.com/b3ca3e8898d05b02952d42b1fa873b71dcdaf15b/components/payments/content/payment_request.h [rename] https://crrev.com/b3ca3e8898d05b02952d42b1fa873b71dcdaf15b/components/payments/content/payment_request.mojom [modify] https://crrev.com/b3ca3e8898d05b02952d42b1fa873b71dcdaf15b/components/payments/content/payment_request_spec.h [modify] https://crrev.com/b3ca3e8898d05b02952d42b1fa873b71dcdaf15b/components/payments/content/payment_request_spec_unittest.cc [modify] https://crrev.com/b3ca3e8898d05b02952d42b1fa873b71dcdaf15b/components/payments/content/payment_request_state.h [modify] https://crrev.com/b3ca3e8898d05b02952d42b1fa873b71dcdaf15b/components/payments/content/payment_request_state_unittest.cc [modify] https://crrev.com/b3ca3e8898d05b02952d42b1fa873b71dcdaf15b/components/payments/content/payment_request_web_contents_manager.h [modify] https://crrev.com/b3ca3e8898d05b02952d42b1fa873b71dcdaf15b/components/payments/content/payment_response_helper.h [modify] https://crrev.com/b3ca3e8898d05b02952d42b1fa873b71dcdaf15b/components/payments/content/payment_response_helper_unittest.cc [modify] https://crrev.com/b3ca3e8898d05b02952d42b1fa873b71dcdaf15b/components/payments/content/payments_validators.h [modify] https://crrev.com/b3ca3e8898d05b02952d42b1fa873b71dcdaf15b/components/payments/content/utility/BUILD.gn [modify] https://crrev.com/b3ca3e8898d05b02952d42b1fa873b71dcdaf15b/components/payments/content/utility/payment_manifest_parser.h [delete] https://crrev.com/7b81dd151531dcd6b5cdbbd078fbf37e4b102adf/components/payments/mojom/BUILD.gn [modify] https://crrev.com/b3ca3e8898d05b02952d42b1fa873b71dcdaf15b/content/browser/BUILD.gn [modify] https://crrev.com/b3ca3e8898d05b02952d42b1fa873b71dcdaf15b/content/browser/payments/payment_app_browsertest.cc [modify] https://crrev.com/b3ca3e8898d05b02952d42b1fa873b71dcdaf15b/content/browser/payments/payment_app_content_unittest_base.h [modify] https://crrev.com/b3ca3e8898d05b02952d42b1fa873b71dcdaf15b/content/browser/payments/payment_app_context_impl.h [modify] https://crrev.com/b3ca3e8898d05b02952d42b1fa873b71dcdaf15b/content/browser/payments/payment_app_database.h [modify] https://crrev.com/b3ca3e8898d05b02952d42b1fa873b71dcdaf15b/content/browser/payments/payment_app_provider_impl_unittest.cc [modify] https://crrev.com/b3ca3e8898d05b02952d42b1fa873b71dcdaf15b/content/browser/payments/payment_manager.h [modify] https://crrev.com/b3ca3e8898d05b02952d42b1fa873b71dcdaf15b/content/browser/payments/payment_manager_unittest.cc [modify] https://crrev.com/b3ca3e8898d05b02952d42b1fa873b71dcdaf15b/content/common/BUILD.gn [modify] https://crrev.com/b3ca3e8898d05b02952d42b1fa873b71dcdaf15b/content/common/service_worker/service_worker_event_dispatcher.mojom [modify] https://crrev.com/b3ca3e8898d05b02952d42b1fa873b71dcdaf15b/content/public/browser/DEPS [modify] https://crrev.com/b3ca3e8898d05b02952d42b1fa873b71dcdaf15b/content/public/browser/payment_app_provider.h [modify] https://crrev.com/b3ca3e8898d05b02952d42b1fa873b71dcdaf15b/content/renderer/BUILD.gn [modify] https://crrev.com/b3ca3e8898d05b02952d42b1fa873b71dcdaf15b/content/renderer/service_worker/service_worker_context_client.h [modify] https://crrev.com/b3ca3e8898d05b02952d42b1fa873b71dcdaf15b/content/renderer/service_worker/service_worker_type_converters.h [modify] https://crrev.com/b3ca3e8898d05b02952d42b1fa873b71dcdaf15b/content/test/BUILD.gn [modify] https://crrev.com/b3ca3e8898d05b02952d42b1fa873b71dcdaf15b/third_party/WebKit/LayoutTests/payments/resources/payment-request-mock.js [modify] https://crrev.com/b3ca3e8898d05b02952d42b1fa873b71dcdaf15b/third_party/WebKit/Source/modules/BUILD.gn [modify] https://crrev.com/b3ca3e8898d05b02952d42b1fa873b71dcdaf15b/third_party/WebKit/Source/modules/payments/BUILD.gn [modify] https://crrev.com/b3ca3e8898d05b02952d42b1fa873b71dcdaf15b/third_party/WebKit/Source/modules/payments/PaymentAddress.h [modify] https://crrev.com/b3ca3e8898d05b02952d42b1fa873b71dcdaf15b/third_party/WebKit/Source/modules/payments/PaymentManager.h [modify] https://crrev.com/b3ca3e8898d05b02952d42b1fa873b71dcdaf15b/third_party/WebKit/Source/modules/payments/PaymentRequest.h [modify] https://crrev.com/b3ca3e8898d05b02952d42b1fa873b71dcdaf15b/third_party/WebKit/Source/modules/payments/PaymentResponse.h [modify] https://crrev.com/b3ca3e8898d05b02952d42b1fa873b71dcdaf15b/third_party/WebKit/Source/modules/payments/PaymentTestHelper.h [modify] https://crrev.com/b3ca3e8898d05b02952d42b1fa873b71dcdaf15b/third_party/WebKit/Source/modules/payments/PaymentsValidators.h [modify] https://crrev.com/b3ca3e8898d05b02952d42b1fa873b71dcdaf15b/third_party/WebKit/public/BUILD.gn
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7ea59a953395e7a90ba8dce7f908cd06a69f180f commit 7ea59a953395e7a90ba8dce7f908cd06a69f180f Author: gogerald <gogerald@chromium.org> Date: Sun Apr 16 22:33:27 2017 move //components/payments/content/*.mojom files to //components/payments/mojom To break dependency of //components/webdata_services on //components/payments/content after landing https://codereview.chromium.org/2801513002/ BUG= 711952 Review-Url: https://codereview.chromium.org/2811593009 Cr-Original-Original-Commit-Position: refs/heads/master@{#464877} Committed: https://chromium.googlesource.com/chromium/src/+/b1b326893990633387f90546607ce8271d151a3a Review-Url: https://codereview.chromium.org/2811593009 Cr-Original-Commit-Position: refs/heads/master@{#464882} Committed: https://chromium.googlesource.com/chromium/src/+/3e1cedb46b52e6c09243993671a5a0ddb7a4eeed Review-Url: https://codereview.chromium.org/2811593009 Cr-Commit-Position: refs/heads/master@{#464892} [modify] https://crrev.com/7ea59a953395e7a90ba8dce7f908cd06a69f180f/chrome/android/BUILD.gn [modify] https://crrev.com/7ea59a953395e7a90ba8dce7f908cd06a69f180f/chrome/browser/BUILD.gn [modify] https://crrev.com/7ea59a953395e7a90ba8dce7f908cd06a69f180f/chrome/browser/android/payments/service_worker_payment_app_bridge.cc [modify] https://crrev.com/7ea59a953395e7a90ba8dce7f908cd06a69f180f/chrome/browser/chrome_content_browser_client.cc [modify] https://crrev.com/7ea59a953395e7a90ba8dce7f908cd06a69f180f/chrome/browser/payments/payment_request_factory.h [modify] https://crrev.com/7ea59a953395e7a90ba8dce7f908cd06a69f180f/chrome/browser/ui/views/payments/payment_request_browsertest_base.h [modify] https://crrev.com/7ea59a953395e7a90ba8dce7f908cd06a69f180f/chrome/browser/ui/views/payments/payment_request_views_util.h [modify] https://crrev.com/7ea59a953395e7a90ba8dce7f908cd06a69f180f/components/payments/android/BUILD.gn [modify] https://crrev.com/7ea59a953395e7a90ba8dce7f908cd06a69f180f/components/payments/android/DEPS [modify] https://crrev.com/7ea59a953395e7a90ba8dce7f908cd06a69f180f/components/payments/android/web_app_manifest_section_table.h [modify] https://crrev.com/7ea59a953395e7a90ba8dce7f908cd06a69f180f/components/payments/content/BUILD.gn [modify] https://crrev.com/7ea59a953395e7a90ba8dce7f908cd06a69f180f/components/payments/content/android/BUILD.gn [modify] https://crrev.com/7ea59a953395e7a90ba8dce7f908cd06a69f180f/components/payments/content/android/payment_details_validation_android.cc [modify] https://crrev.com/7ea59a953395e7a90ba8dce7f908cd06a69f180f/components/payments/content/payment_details_validation.cc [modify] https://crrev.com/7ea59a953395e7a90ba8dce7f908cd06a69f180f/components/payments/content/payment_details_validation.h [modify] https://crrev.com/7ea59a953395e7a90ba8dce7f908cd06a69f180f/components/payments/content/payment_manifest_parser_host.h [modify] https://crrev.com/7ea59a953395e7a90ba8dce7f908cd06a69f180f/components/payments/content/payment_request.h [modify] https://crrev.com/7ea59a953395e7a90ba8dce7f908cd06a69f180f/components/payments/content/payment_request_spec.h [modify] https://crrev.com/7ea59a953395e7a90ba8dce7f908cd06a69f180f/components/payments/content/payment_request_spec_unittest.cc [modify] https://crrev.com/7ea59a953395e7a90ba8dce7f908cd06a69f180f/components/payments/content/payment_request_state.h [modify] https://crrev.com/7ea59a953395e7a90ba8dce7f908cd06a69f180f/components/payments/content/payment_request_state_unittest.cc [modify] https://crrev.com/7ea59a953395e7a90ba8dce7f908cd06a69f180f/components/payments/content/payment_request_web_contents_manager.h [modify] https://crrev.com/7ea59a953395e7a90ba8dce7f908cd06a69f180f/components/payments/content/payment_response_helper.h [modify] https://crrev.com/7ea59a953395e7a90ba8dce7f908cd06a69f180f/components/payments/content/payment_response_helper_unittest.cc [modify] https://crrev.com/7ea59a953395e7a90ba8dce7f908cd06a69f180f/components/payments/content/payments_validators.h [modify] https://crrev.com/7ea59a953395e7a90ba8dce7f908cd06a69f180f/components/payments/content/utility/BUILD.gn [modify] https://crrev.com/7ea59a953395e7a90ba8dce7f908cd06a69f180f/components/payments/content/utility/payment_manifest_parser.h [add] https://crrev.com/7ea59a953395e7a90ba8dce7f908cd06a69f180f/components/payments/mojom/BUILD.gn [rename] https://crrev.com/7ea59a953395e7a90ba8dce7f908cd06a69f180f/components/payments/mojom/OWNERS [rename] https://crrev.com/7ea59a953395e7a90ba8dce7f908cd06a69f180f/components/payments/mojom/payment_app.mojom [rename] https://crrev.com/7ea59a953395e7a90ba8dce7f908cd06a69f180f/components/payments/mojom/payment_manifest_parser.mojom [rename] https://crrev.com/7ea59a953395e7a90ba8dce7f908cd06a69f180f/components/payments/mojom/payment_request.mojom [modify] https://crrev.com/7ea59a953395e7a90ba8dce7f908cd06a69f180f/content/browser/BUILD.gn [modify] https://crrev.com/7ea59a953395e7a90ba8dce7f908cd06a69f180f/content/browser/payments/payment_app_browsertest.cc [modify] https://crrev.com/7ea59a953395e7a90ba8dce7f908cd06a69f180f/content/browser/payments/payment_app_content_unittest_base.h [modify] https://crrev.com/7ea59a953395e7a90ba8dce7f908cd06a69f180f/content/browser/payments/payment_app_context_impl.h [modify] https://crrev.com/7ea59a953395e7a90ba8dce7f908cd06a69f180f/content/browser/payments/payment_app_database.h [modify] https://crrev.com/7ea59a953395e7a90ba8dce7f908cd06a69f180f/content/browser/payments/payment_app_provider_impl_unittest.cc [modify] https://crrev.com/7ea59a953395e7a90ba8dce7f908cd06a69f180f/content/browser/payments/payment_manager.h [modify] https://crrev.com/7ea59a953395e7a90ba8dce7f908cd06a69f180f/content/browser/payments/payment_manager_unittest.cc [modify] https://crrev.com/7ea59a953395e7a90ba8dce7f908cd06a69f180f/content/common/BUILD.gn [modify] https://crrev.com/7ea59a953395e7a90ba8dce7f908cd06a69f180f/content/common/service_worker/service_worker_event_dispatcher.mojom [modify] https://crrev.com/7ea59a953395e7a90ba8dce7f908cd06a69f180f/content/public/browser/DEPS [modify] https://crrev.com/7ea59a953395e7a90ba8dce7f908cd06a69f180f/content/public/browser/payment_app_provider.h [modify] https://crrev.com/7ea59a953395e7a90ba8dce7f908cd06a69f180f/content/renderer/BUILD.gn [modify] https://crrev.com/7ea59a953395e7a90ba8dce7f908cd06a69f180f/content/renderer/service_worker/service_worker_context_client.h [modify] https://crrev.com/7ea59a953395e7a90ba8dce7f908cd06a69f180f/content/renderer/service_worker/service_worker_type_converters.h [modify] https://crrev.com/7ea59a953395e7a90ba8dce7f908cd06a69f180f/content/test/BUILD.gn [modify] https://crrev.com/7ea59a953395e7a90ba8dce7f908cd06a69f180f/third_party/WebKit/LayoutTests/payments/resources/payment-request-mock.js [modify] https://crrev.com/7ea59a953395e7a90ba8dce7f908cd06a69f180f/third_party/WebKit/Source/modules/BUILD.gn [modify] https://crrev.com/7ea59a953395e7a90ba8dce7f908cd06a69f180f/third_party/WebKit/Source/modules/payments/BUILD.gn [modify] https://crrev.com/7ea59a953395e7a90ba8dce7f908cd06a69f180f/third_party/WebKit/Source/modules/payments/PaymentAddress.h [modify] https://crrev.com/7ea59a953395e7a90ba8dce7f908cd06a69f180f/third_party/WebKit/Source/modules/payments/PaymentManager.h [modify] https://crrev.com/7ea59a953395e7a90ba8dce7f908cd06a69f180f/third_party/WebKit/Source/modules/payments/PaymentRequest.h [modify] https://crrev.com/7ea59a953395e7a90ba8dce7f908cd06a69f180f/third_party/WebKit/Source/modules/payments/PaymentResponse.h [modify] https://crrev.com/7ea59a953395e7a90ba8dce7f908cd06a69f180f/third_party/WebKit/Source/modules/payments/PaymentTestHelper.h [modify] https://crrev.com/7ea59a953395e7a90ba8dce7f908cd06a69f180f/third_party/WebKit/Source/modules/payments/PaymentsValidators.h [modify] https://crrev.com/7ea59a953395e7a90ba8dce7f908cd06a69f180f/third_party/WebKit/public/BUILD.gn
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6ab92fb52c0b4e0fcb4dc9746e05189dc49b748b commit 6ab92fb52c0b4e0fcb4dc9746e05189dc49b748b Author: tobiasjs <tobiasjs@chromium.org> Date: Mon Apr 17 08:54:56 2017 Revert of [Payments] move //components/payments/content/*.mojom files to //components/payments/mojom (patchset #7 id:200001 of https://codereview.chromium.org/2811593009/ ) Reason for revert: I suspect this caused build failures: crbug.com/712120 Original issue's description: > move //components/payments/content/*.mojom files to //components/payments/mojom > > To break dependency of //components/webdata_services on //components/payments/content after > landing https://codereview.chromium.org/2801513002/ > > BUG= 711952 > > Review-Url: https://codereview.chromium.org/2811593009 > Cr-Original-Original-Commit-Position: refs/heads/master@{#464877} > Committed: https://chromium.googlesource.com/chromium/src/+/b1b326893990633387f90546607ce8271d151a3a > Review-Url: https://codereview.chromium.org/2811593009 > Cr-Original-Commit-Position: refs/heads/master@{#464882} > Committed: https://chromium.googlesource.com/chromium/src/+/3e1cedb46b52e6c09243993671a5a0ddb7a4eeed > Review-Url: https://codereview.chromium.org/2811593009 > Cr-Commit-Position: refs/heads/master@{#464892} > Committed: https://chromium.googlesource.com/chromium/src/+/7ea59a953395e7a90ba8dce7f908cd06a69f180f TBR=rouslan@chromium.org,cpu@chromium.org,dcheng@chromium.org,gogerald@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= 711952 Review-Url: https://codereview.chromium.org/2823823002 Cr-Commit-Position: refs/heads/master@{#464910} [modify] https://crrev.com/6ab92fb52c0b4e0fcb4dc9746e05189dc49b748b/chrome/android/BUILD.gn [modify] https://crrev.com/6ab92fb52c0b4e0fcb4dc9746e05189dc49b748b/chrome/browser/BUILD.gn [modify] https://crrev.com/6ab92fb52c0b4e0fcb4dc9746e05189dc49b748b/chrome/browser/android/payments/service_worker_payment_app_bridge.cc [modify] https://crrev.com/6ab92fb52c0b4e0fcb4dc9746e05189dc49b748b/chrome/browser/chrome_content_browser_client.cc [modify] https://crrev.com/6ab92fb52c0b4e0fcb4dc9746e05189dc49b748b/chrome/browser/payments/payment_request_factory.h [modify] https://crrev.com/6ab92fb52c0b4e0fcb4dc9746e05189dc49b748b/chrome/browser/ui/views/payments/payment_request_browsertest_base.h [modify] https://crrev.com/6ab92fb52c0b4e0fcb4dc9746e05189dc49b748b/chrome/browser/ui/views/payments/payment_request_views_util.h [modify] https://crrev.com/6ab92fb52c0b4e0fcb4dc9746e05189dc49b748b/components/payments/android/BUILD.gn [modify] https://crrev.com/6ab92fb52c0b4e0fcb4dc9746e05189dc49b748b/components/payments/android/DEPS [modify] https://crrev.com/6ab92fb52c0b4e0fcb4dc9746e05189dc49b748b/components/payments/android/web_app_manifest_section_table.h [modify] https://crrev.com/6ab92fb52c0b4e0fcb4dc9746e05189dc49b748b/components/payments/content/BUILD.gn [rename] https://crrev.com/6ab92fb52c0b4e0fcb4dc9746e05189dc49b748b/components/payments/content/OWNERS [modify] https://crrev.com/6ab92fb52c0b4e0fcb4dc9746e05189dc49b748b/components/payments/content/android/BUILD.gn [modify] https://crrev.com/6ab92fb52c0b4e0fcb4dc9746e05189dc49b748b/components/payments/content/android/payment_details_validation_android.cc [rename] https://crrev.com/6ab92fb52c0b4e0fcb4dc9746e05189dc49b748b/components/payments/content/payment_app.mojom [modify] https://crrev.com/6ab92fb52c0b4e0fcb4dc9746e05189dc49b748b/components/payments/content/payment_details_validation.cc [modify] https://crrev.com/6ab92fb52c0b4e0fcb4dc9746e05189dc49b748b/components/payments/content/payment_details_validation.h [rename] https://crrev.com/6ab92fb52c0b4e0fcb4dc9746e05189dc49b748b/components/payments/content/payment_manifest_parser.mojom [modify] https://crrev.com/6ab92fb52c0b4e0fcb4dc9746e05189dc49b748b/components/payments/content/payment_manifest_parser_host.h [modify] https://crrev.com/6ab92fb52c0b4e0fcb4dc9746e05189dc49b748b/components/payments/content/payment_request.h [rename] https://crrev.com/6ab92fb52c0b4e0fcb4dc9746e05189dc49b748b/components/payments/content/payment_request.mojom [modify] https://crrev.com/6ab92fb52c0b4e0fcb4dc9746e05189dc49b748b/components/payments/content/payment_request_spec.h [modify] https://crrev.com/6ab92fb52c0b4e0fcb4dc9746e05189dc49b748b/components/payments/content/payment_request_spec_unittest.cc [modify] https://crrev.com/6ab92fb52c0b4e0fcb4dc9746e05189dc49b748b/components/payments/content/payment_request_state.h [modify] https://crrev.com/6ab92fb52c0b4e0fcb4dc9746e05189dc49b748b/components/payments/content/payment_request_state_unittest.cc [modify] https://crrev.com/6ab92fb52c0b4e0fcb4dc9746e05189dc49b748b/components/payments/content/payment_request_web_contents_manager.h [modify] https://crrev.com/6ab92fb52c0b4e0fcb4dc9746e05189dc49b748b/components/payments/content/payment_response_helper.h [modify] https://crrev.com/6ab92fb52c0b4e0fcb4dc9746e05189dc49b748b/components/payments/content/payment_response_helper_unittest.cc [modify] https://crrev.com/6ab92fb52c0b4e0fcb4dc9746e05189dc49b748b/components/payments/content/payments_validators.h [modify] https://crrev.com/6ab92fb52c0b4e0fcb4dc9746e05189dc49b748b/components/payments/content/utility/BUILD.gn [modify] https://crrev.com/6ab92fb52c0b4e0fcb4dc9746e05189dc49b748b/components/payments/content/utility/payment_manifest_parser.h [delete] https://crrev.com/c82bb4760bc368ce89d3e30abe617f995fe7c6b5/components/payments/mojom/BUILD.gn [modify] https://crrev.com/6ab92fb52c0b4e0fcb4dc9746e05189dc49b748b/content/browser/BUILD.gn [modify] https://crrev.com/6ab92fb52c0b4e0fcb4dc9746e05189dc49b748b/content/browser/payments/payment_app_browsertest.cc [modify] https://crrev.com/6ab92fb52c0b4e0fcb4dc9746e05189dc49b748b/content/browser/payments/payment_app_content_unittest_base.h [modify] https://crrev.com/6ab92fb52c0b4e0fcb4dc9746e05189dc49b748b/content/browser/payments/payment_app_context_impl.h [modify] https://crrev.com/6ab92fb52c0b4e0fcb4dc9746e05189dc49b748b/content/browser/payments/payment_app_database.h [modify] https://crrev.com/6ab92fb52c0b4e0fcb4dc9746e05189dc49b748b/content/browser/payments/payment_app_provider_impl_unittest.cc [modify] https://crrev.com/6ab92fb52c0b4e0fcb4dc9746e05189dc49b748b/content/browser/payments/payment_manager.h [modify] https://crrev.com/6ab92fb52c0b4e0fcb4dc9746e05189dc49b748b/content/browser/payments/payment_manager_unittest.cc [modify] https://crrev.com/6ab92fb52c0b4e0fcb4dc9746e05189dc49b748b/content/common/BUILD.gn [modify] https://crrev.com/6ab92fb52c0b4e0fcb4dc9746e05189dc49b748b/content/common/service_worker/service_worker_event_dispatcher.mojom [modify] https://crrev.com/6ab92fb52c0b4e0fcb4dc9746e05189dc49b748b/content/public/browser/DEPS [modify] https://crrev.com/6ab92fb52c0b4e0fcb4dc9746e05189dc49b748b/content/public/browser/payment_app_provider.h [modify] https://crrev.com/6ab92fb52c0b4e0fcb4dc9746e05189dc49b748b/content/renderer/BUILD.gn [modify] https://crrev.com/6ab92fb52c0b4e0fcb4dc9746e05189dc49b748b/content/renderer/service_worker/service_worker_context_client.h [modify] https://crrev.com/6ab92fb52c0b4e0fcb4dc9746e05189dc49b748b/content/renderer/service_worker/service_worker_type_converters.h [modify] https://crrev.com/6ab92fb52c0b4e0fcb4dc9746e05189dc49b748b/content/test/BUILD.gn [modify] https://crrev.com/6ab92fb52c0b4e0fcb4dc9746e05189dc49b748b/third_party/WebKit/LayoutTests/payments/resources/payment-request-mock.js [modify] https://crrev.com/6ab92fb52c0b4e0fcb4dc9746e05189dc49b748b/third_party/WebKit/Source/modules/BUILD.gn [modify] https://crrev.com/6ab92fb52c0b4e0fcb4dc9746e05189dc49b748b/third_party/WebKit/Source/modules/payments/BUILD.gn [modify] https://crrev.com/6ab92fb52c0b4e0fcb4dc9746e05189dc49b748b/third_party/WebKit/Source/modules/payments/PaymentAddress.h [modify] https://crrev.com/6ab92fb52c0b4e0fcb4dc9746e05189dc49b748b/third_party/WebKit/Source/modules/payments/PaymentManager.h [modify] https://crrev.com/6ab92fb52c0b4e0fcb4dc9746e05189dc49b748b/third_party/WebKit/Source/modules/payments/PaymentRequest.h [modify] https://crrev.com/6ab92fb52c0b4e0fcb4dc9746e05189dc49b748b/third_party/WebKit/Source/modules/payments/PaymentResponse.h [modify] https://crrev.com/6ab92fb52c0b4e0fcb4dc9746e05189dc49b748b/third_party/WebKit/Source/modules/payments/PaymentTestHelper.h [modify] https://crrev.com/6ab92fb52c0b4e0fcb4dc9746e05189dc49b748b/third_party/WebKit/Source/modules/payments/PaymentsValidators.h [modify] https://crrev.com/6ab92fb52c0b4e0fcb4dc9746e05189dc49b748b/third_party/WebKit/public/BUILD.gn
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c66efdd28c39d5dbd8ce1dbba62296b7c215200d commit c66efdd28c39d5dbd8ce1dbba62296b7c215200d Author: tobiasjs <tobiasjs@chromium.org> Date: Mon Apr 17 13:38:59 2017 Reland of [Payments] move //components/payments/content/*.mojom files to //components/payments/mojom (patchset #1 id:1 of https://codereview.chromium.org/2823823002/ ) Reason for revert: The reason appears to have been a synchronization issue with the official builds. Undoing the revert. Original issue's description: > Revert of [Payments] move //components/payments/content/*.mojom files to //components/payments/mojom (patchset #7 id:200001 of https://codereview.chromium.org/2811593009/ ) > > Reason for revert: > I suspect this caused build failures: crbug.com/712120 > > Original issue's description: > > move //components/payments/content/*.mojom files to //components/payments/mojom > > > > To break dependency of //components/webdata_services on //components/payments/content after > > landing https://codereview.chromium.org/2801513002/ > > > > BUG= 711952 > > > > Review-Url: https://codereview.chromium.org/2811593009 > > Cr-Original-Original-Commit-Position: refs/heads/master@{#464877} > > Committed: https://chromium.googlesource.com/chromium/src/+/b1b326893990633387f90546607ce8271d151a3a > > Review-Url: https://codereview.chromium.org/2811593009 > > Cr-Original-Commit-Position: refs/heads/master@{#464882} > > Committed: https://chromium.googlesource.com/chromium/src/+/3e1cedb46b52e6c09243993671a5a0ddb7a4eeed > > Review-Url: https://codereview.chromium.org/2811593009 > > Cr-Commit-Position: refs/heads/master@{#464892} > > Committed: https://chromium.googlesource.com/chromium/src/+/7ea59a953395e7a90ba8dce7f908cd06a69f180f > > TBR=rouslan@chromium.org,cpu@chromium.org,dcheng@chromium.org,gogerald@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG= 711952 > > Review-Url: https://codereview.chromium.org/2823823002 > Cr-Commit-Position: refs/heads/master@{#464910} > Committed: https://chromium.googlesource.com/chromium/src/+/6ab92fb52c0b4e0fcb4dc9746e05189dc49b748b TBR=rouslan@chromium.org,cpu@chromium.org,dcheng@chromium.org,gogerald@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= 711952 Review-Url: https://codereview.chromium.org/2822973002 Cr-Commit-Position: refs/heads/master@{#464918} [modify] https://crrev.com/c66efdd28c39d5dbd8ce1dbba62296b7c215200d/chrome/android/BUILD.gn [modify] https://crrev.com/c66efdd28c39d5dbd8ce1dbba62296b7c215200d/chrome/browser/BUILD.gn [modify] https://crrev.com/c66efdd28c39d5dbd8ce1dbba62296b7c215200d/chrome/browser/android/payments/service_worker_payment_app_bridge.cc [modify] https://crrev.com/c66efdd28c39d5dbd8ce1dbba62296b7c215200d/chrome/browser/chrome_content_browser_client.cc [modify] https://crrev.com/c66efdd28c39d5dbd8ce1dbba62296b7c215200d/chrome/browser/payments/payment_request_factory.h [modify] https://crrev.com/c66efdd28c39d5dbd8ce1dbba62296b7c215200d/chrome/browser/ui/views/payments/payment_request_browsertest_base.h [modify] https://crrev.com/c66efdd28c39d5dbd8ce1dbba62296b7c215200d/chrome/browser/ui/views/payments/payment_request_views_util.h [modify] https://crrev.com/c66efdd28c39d5dbd8ce1dbba62296b7c215200d/components/payments/android/BUILD.gn [modify] https://crrev.com/c66efdd28c39d5dbd8ce1dbba62296b7c215200d/components/payments/android/DEPS [modify] https://crrev.com/c66efdd28c39d5dbd8ce1dbba62296b7c215200d/components/payments/android/web_app_manifest_section_table.h [modify] https://crrev.com/c66efdd28c39d5dbd8ce1dbba62296b7c215200d/components/payments/content/BUILD.gn [modify] https://crrev.com/c66efdd28c39d5dbd8ce1dbba62296b7c215200d/components/payments/content/android/BUILD.gn [modify] https://crrev.com/c66efdd28c39d5dbd8ce1dbba62296b7c215200d/components/payments/content/android/payment_details_validation_android.cc [modify] https://crrev.com/c66efdd28c39d5dbd8ce1dbba62296b7c215200d/components/payments/content/payment_details_validation.cc [modify] https://crrev.com/c66efdd28c39d5dbd8ce1dbba62296b7c215200d/components/payments/content/payment_details_validation.h [modify] https://crrev.com/c66efdd28c39d5dbd8ce1dbba62296b7c215200d/components/payments/content/payment_manifest_parser_host.h [modify] https://crrev.com/c66efdd28c39d5dbd8ce1dbba62296b7c215200d/components/payments/content/payment_request.h [modify] https://crrev.com/c66efdd28c39d5dbd8ce1dbba62296b7c215200d/components/payments/content/payment_request_spec.h [modify] https://crrev.com/c66efdd28c39d5dbd8ce1dbba62296b7c215200d/components/payments/content/payment_request_spec_unittest.cc [modify] https://crrev.com/c66efdd28c39d5dbd8ce1dbba62296b7c215200d/components/payments/content/payment_request_state.h [modify] https://crrev.com/c66efdd28c39d5dbd8ce1dbba62296b7c215200d/components/payments/content/payment_request_state_unittest.cc [modify] https://crrev.com/c66efdd28c39d5dbd8ce1dbba62296b7c215200d/components/payments/content/payment_request_web_contents_manager.h [modify] https://crrev.com/c66efdd28c39d5dbd8ce1dbba62296b7c215200d/components/payments/content/payment_response_helper.h [modify] https://crrev.com/c66efdd28c39d5dbd8ce1dbba62296b7c215200d/components/payments/content/payment_response_helper_unittest.cc [modify] https://crrev.com/c66efdd28c39d5dbd8ce1dbba62296b7c215200d/components/payments/content/payments_validators.h [modify] https://crrev.com/c66efdd28c39d5dbd8ce1dbba62296b7c215200d/components/payments/content/utility/BUILD.gn [modify] https://crrev.com/c66efdd28c39d5dbd8ce1dbba62296b7c215200d/components/payments/content/utility/payment_manifest_parser.h [add] https://crrev.com/c66efdd28c39d5dbd8ce1dbba62296b7c215200d/components/payments/mojom/BUILD.gn [rename] https://crrev.com/c66efdd28c39d5dbd8ce1dbba62296b7c215200d/components/payments/mojom/OWNERS [rename] https://crrev.com/c66efdd28c39d5dbd8ce1dbba62296b7c215200d/components/payments/mojom/payment_app.mojom [rename] https://crrev.com/c66efdd28c39d5dbd8ce1dbba62296b7c215200d/components/payments/mojom/payment_manifest_parser.mojom [rename] https://crrev.com/c66efdd28c39d5dbd8ce1dbba62296b7c215200d/components/payments/mojom/payment_request.mojom [modify] https://crrev.com/c66efdd28c39d5dbd8ce1dbba62296b7c215200d/content/browser/BUILD.gn [modify] https://crrev.com/c66efdd28c39d5dbd8ce1dbba62296b7c215200d/content/browser/payments/payment_app_browsertest.cc [modify] https://crrev.com/c66efdd28c39d5dbd8ce1dbba62296b7c215200d/content/browser/payments/payment_app_content_unittest_base.h [modify] https://crrev.com/c66efdd28c39d5dbd8ce1dbba62296b7c215200d/content/browser/payments/payment_app_context_impl.h [modify] https://crrev.com/c66efdd28c39d5dbd8ce1dbba62296b7c215200d/content/browser/payments/payment_app_database.h [modify] https://crrev.com/c66efdd28c39d5dbd8ce1dbba62296b7c215200d/content/browser/payments/payment_app_provider_impl_unittest.cc [modify] https://crrev.com/c66efdd28c39d5dbd8ce1dbba62296b7c215200d/content/browser/payments/payment_manager.h [modify] https://crrev.com/c66efdd28c39d5dbd8ce1dbba62296b7c215200d/content/browser/payments/payment_manager_unittest.cc [modify] https://crrev.com/c66efdd28c39d5dbd8ce1dbba62296b7c215200d/content/common/BUILD.gn [modify] https://crrev.com/c66efdd28c39d5dbd8ce1dbba62296b7c215200d/content/common/service_worker/service_worker_event_dispatcher.mojom [modify] https://crrev.com/c66efdd28c39d5dbd8ce1dbba62296b7c215200d/content/public/browser/DEPS [modify] https://crrev.com/c66efdd28c39d5dbd8ce1dbba62296b7c215200d/content/public/browser/payment_app_provider.h [modify] https://crrev.com/c66efdd28c39d5dbd8ce1dbba62296b7c215200d/content/renderer/BUILD.gn [modify] https://crrev.com/c66efdd28c39d5dbd8ce1dbba62296b7c215200d/content/renderer/service_worker/service_worker_context_client.h [modify] https://crrev.com/c66efdd28c39d5dbd8ce1dbba62296b7c215200d/content/renderer/service_worker/service_worker_type_converters.h [modify] https://crrev.com/c66efdd28c39d5dbd8ce1dbba62296b7c215200d/content/test/BUILD.gn [modify] https://crrev.com/c66efdd28c39d5dbd8ce1dbba62296b7c215200d/third_party/WebKit/LayoutTests/payments/resources/payment-request-mock.js [modify] https://crrev.com/c66efdd28c39d5dbd8ce1dbba62296b7c215200d/third_party/WebKit/Source/modules/BUILD.gn [modify] https://crrev.com/c66efdd28c39d5dbd8ce1dbba62296b7c215200d/third_party/WebKit/Source/modules/payments/BUILD.gn [modify] https://crrev.com/c66efdd28c39d5dbd8ce1dbba62296b7c215200d/third_party/WebKit/Source/modules/payments/PaymentAddress.h [modify] https://crrev.com/c66efdd28c39d5dbd8ce1dbba62296b7c215200d/third_party/WebKit/Source/modules/payments/PaymentManager.h [modify] https://crrev.com/c66efdd28c39d5dbd8ce1dbba62296b7c215200d/third_party/WebKit/Source/modules/payments/PaymentRequest.h [modify] https://crrev.com/c66efdd28c39d5dbd8ce1dbba62296b7c215200d/third_party/WebKit/Source/modules/payments/PaymentResponse.h [modify] https://crrev.com/c66efdd28c39d5dbd8ce1dbba62296b7c215200d/third_party/WebKit/Source/modules/payments/PaymentTestHelper.h [modify] https://crrev.com/c66efdd28c39d5dbd8ce1dbba62296b7c215200d/third_party/WebKit/Source/modules/payments/PaymentsValidators.h [modify] https://crrev.com/c66efdd28c39d5dbd8ce1dbba62296b7c215200d/third_party/WebKit/public/BUILD.gn
Comment 1 by bugdroid1@chromium.org
, Apr 16 2017