New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 711937 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: May 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug

Blocking:
issue 654664



Sign in to add a comment

CSS Motion Path: delete implementation of retired properties

Project Member Reported by ericwilligers@chromium.org, Apr 15 2017

Issue description

The Blink codebase can now be simplified by deleting support for
-motion-path
-motion-offset
-motion-rotation
-motion
-offset-rotation

These are disabled in M58.

M56, M57 and M58 can be removed from milestoneString in Deprecation.cpp



 
Labels: Hotlist-CodeHealth
Cc: shans@chromium.org
I received an email from Philip Jägenstedt <foolip@chromium.org>

We have now passed the M59 branch point, which means that things that were due for removal in M59 or earlier should be gone from https://cs.chromium.org/chromium/src/third_party/WebKit/Source/core/frame/Deprecation.cpp

Project Member

Comment 3 by bugdroid1@chromium.org, Apr 19 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e2d081bda60e36d5f51c270f809c896bbf473f72

commit e2d081bda60e36d5f51c270f809c896bbf473f72
Author: ericwilligers <ericwilligers@chromium.org>
Date: Wed Apr 19 07:45:19 2017

CSS Motion Path: delete implementation of motion shorthand

The 'motion' shorthand is among the properties disabled in M58.

Intent to remove: https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/o1C5NzGf9Q0/FgU5o52yBAAJ

BUG= 711937 

Review-Url: https://codereview.chromium.org/2828503002
Cr-Commit-Position: refs/heads/master@{#465520}

[delete] https://crrev.com/22b07a940d99a190bf2ccbf0c95ad66dff03526e/third_party/WebKit/LayoutTests/css3/motion-path/combine-motion-translation-and-rotation-expected.html
[delete] https://crrev.com/22b07a940d99a190bf2ccbf0c95ad66dff03526e/third_party/WebKit/LayoutTests/css3/motion-path/combine-motion-translation-and-rotation.html
[delete] https://crrev.com/22b07a940d99a190bf2ccbf0c95ad66dff03526e/third_party/WebKit/LayoutTests/css3/motion-path/motion-shorthand-deprecated-expected.txt
[delete] https://crrev.com/22b07a940d99a190bf2ccbf0c95ad66dff03526e/third_party/WebKit/LayoutTests/css3/motion-path/motion-shorthand-deprecated.html
[delete] https://crrev.com/22b07a940d99a190bf2ccbf0c95ad66dff03526e/third_party/WebKit/LayoutTests/css3/motion-path/motion.html
[delete] https://crrev.com/22b07a940d99a190bf2ccbf0c95ad66dff03526e/third_party/WebKit/LayoutTests/css3/motion-path/use-count-motion.html
[modify] https://crrev.com/e2d081bda60e36d5f51c270f809c896bbf473f72/third_party/WebKit/LayoutTests/transforms/combine-transforms-properties-motion-path.html
[modify] https://crrev.com/e2d081bda60e36d5f51c270f809c896bbf473f72/third_party/WebKit/LayoutTests/virtual/stable/webexposed/css-properties-as-js-properties-expected.txt
[modify] https://crrev.com/e2d081bda60e36d5f51c270f809c896bbf473f72/third_party/WebKit/LayoutTests/webexposed/css-properties-as-js-properties-expected.txt
[modify] https://crrev.com/e2d081bda60e36d5f51c270f809c896bbf473f72/third_party/WebKit/Source/core/css/CSSProperties.json5
[modify] https://crrev.com/e2d081bda60e36d5f51c270f809c896bbf473f72/third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp
[modify] https://crrev.com/e2d081bda60e36d5f51c270f809c896bbf473f72/third_party/WebKit/Source/core/css/StylePropertySerializer.cpp
[modify] https://crrev.com/e2d081bda60e36d5f51c270f809c896bbf473f72/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp
[modify] https://crrev.com/e2d081bda60e36d5f51c270f809c896bbf473f72/third_party/WebKit/Source/core/frame/Deprecation.cpp
[modify] https://crrev.com/e2d081bda60e36d5f51c270f809c896bbf473f72/third_party/WebKit/Source/core/frame/UseCounter.cpp

Cc: bugsnash@chromium.org
The next four CLs are ready for review and landing in sequence:
https://codereview.chromium.org/2827003002 motion-path
https://codereview.chromium.org/2840943003 motion-rotation
https://codereview.chromium.org/2842933003 offset-rotation
https://codereview.chromium.org/2841863005 motion-offset

Project Member

Comment 5 by bugdroid1@chromium.org, Apr 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cbe00006cf35aa25a33e45c6ad8cd68ddf774cb8

commit cbe00006cf35aa25a33e45c6ad8cd68ddf774cb8
Author: ericwilligers <ericwilligers@chromium.org>
Date: Thu Apr 27 06:30:00 2017

CSS Motion Path: delete implementation of motion-path property

The 'motion-path' property has been replaced by 'offset-path'.

'motion-path' is among the properties disabled in M58.

BUG= 711937 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2827003002
Cr-Commit-Position: refs/heads/master@{#467605}

[modify] https://crrev.com/cbe00006cf35aa25a33e45c6ad8cd68ddf774cb8/third_party/WebKit/LayoutTests/animations/interpolation/motion-offset-interpolation.html
[delete] https://crrev.com/ef74ec9973e071da2dc5813f0b93662a0f1497bf/third_party/WebKit/LayoutTests/css3/motion-path/motion-path.html
[modify] https://crrev.com/cbe00006cf35aa25a33e45c6ad8cd68ddf774cb8/third_party/WebKit/LayoutTests/css3/motion-path/motion-properties-deprecated-expected.txt
[modify] https://crrev.com/cbe00006cf35aa25a33e45c6ad8cd68ddf774cb8/third_party/WebKit/LayoutTests/css3/motion-path/motion-properties-deprecated.html
[delete] https://crrev.com/ef74ec9973e071da2dc5813f0b93662a0f1497bf/third_party/WebKit/LayoutTests/css3/motion-path/use-count-motion-path.html
[modify] https://crrev.com/cbe00006cf35aa25a33e45c6ad8cd68ddf774cb8/third_party/WebKit/LayoutTests/css3/motion-path/use-count-offset-path.html
[modify] https://crrev.com/cbe00006cf35aa25a33e45c6ad8cd68ddf774cb8/third_party/WebKit/LayoutTests/css3/motion-path/use-count-offset-position.html
[modify] https://crrev.com/cbe00006cf35aa25a33e45c6ad8cd68ddf774cb8/third_party/WebKit/LayoutTests/css3/motion-path/use-count-offset.html
[modify] https://crrev.com/cbe00006cf35aa25a33e45c6ad8cd68ddf774cb8/third_party/WebKit/ManualTests/animation/compositor-transform-fill-forwards-with-motion-path.html
[modify] https://crrev.com/cbe00006cf35aa25a33e45c6ad8cd68ddf774cb8/third_party/WebKit/ManualTests/animation/compositor-transform-prevented-by-motion-path.html
[modify] https://crrev.com/cbe00006cf35aa25a33e45c6ad8cd68ddf774cb8/third_party/WebKit/Source/core/css/CSSProperties.json5
[modify] https://crrev.com/cbe00006cf35aa25a33e45c6ad8cd68ddf774cb8/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp
[modify] https://crrev.com/cbe00006cf35aa25a33e45c6ad8cd68ddf774cb8/third_party/WebKit/Source/core/css/properties/CSSPropertyOffsetPathUtils.cpp
[modify] https://crrev.com/cbe00006cf35aa25a33e45c6ad8cd68ddf774cb8/third_party/WebKit/Source/core/css/properties/CSSPropertyOffsetPathUtils.h
[modify] https://crrev.com/cbe00006cf35aa25a33e45c6ad8cd68ddf774cb8/third_party/WebKit/Source/core/frame/Deprecation.cpp
[modify] https://crrev.com/cbe00006cf35aa25a33e45c6ad8cd68ddf774cb8/third_party/WebKit/Source/core/frame/UseCounter.cpp
[modify] https://crrev.com/cbe00006cf35aa25a33e45c6ad8cd68ddf774cb8/third_party/WebKit/Source/core/frame/UseCounter.h
[modify] https://crrev.com/cbe00006cf35aa25a33e45c6ad8cd68ddf774cb8/third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilderTest.cpp

Project Member

Comment 6 by bugdroid1@chromium.org, Apr 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9274fd6bfe4e948608f1b830d630438a077cef3d

commit 9274fd6bfe4e948608f1b830d630438a077cef3d
Author: ericwilligers <ericwilligers@chromium.org>
Date: Fri Apr 28 10:25:13 2017

CSS Motion Path: delete implementation of motion-rotation property

The 'motion-rotation' property has been replaced by 'offset-rotate'.

'motion-rotation' is among the properties disabled in M58.

BUG= 711937 

Review-Url: https://codereview.chromium.org/2840943003
Cr-Commit-Position: refs/heads/master@{#467952}

[modify] https://crrev.com/9274fd6bfe4e948608f1b830d630438a077cef3d/third_party/WebKit/LayoutTests/FlagExpectations/enable-blink-features=LayoutNG
[modify] https://crrev.com/9274fd6bfe4e948608f1b830d630438a077cef3d/third_party/WebKit/LayoutTests/SmokeTests
[delete] https://crrev.com/6273712b527b4e13ec0d854fcd11e0b5e034eb2a/third_party/WebKit/LayoutTests/animations/composition/motion-rotation-composition.html
[delete] https://crrev.com/6273712b527b4e13ec0d854fcd11e0b5e034eb2a/third_party/WebKit/LayoutTests/animations/interpolation/motion-rotation-interpolation.html
[delete] https://crrev.com/6273712b527b4e13ec0d854fcd11e0b5e034eb2a/third_party/WebKit/LayoutTests/animations/responsive/motion-rotation-responsive.html
[modify] https://crrev.com/9274fd6bfe4e948608f1b830d630438a077cef3d/third_party/WebKit/LayoutTests/css3/motion-path/motion-properties-deprecated-expected.txt
[modify] https://crrev.com/9274fd6bfe4e948608f1b830d630438a077cef3d/third_party/WebKit/LayoutTests/css3/motion-path/motion-properties-deprecated.html
[delete] https://crrev.com/6273712b527b4e13ec0d854fcd11e0b5e034eb2a/third_party/WebKit/LayoutTests/css3/motion-path/motion-rotation-overflow-crash.html
[delete] https://crrev.com/6273712b527b4e13ec0d854fcd11e0b5e034eb2a/third_party/WebKit/LayoutTests/css3/motion-path/motion-rotation.html
[delete] https://crrev.com/6273712b527b4e13ec0d854fcd11e0b5e034eb2a/third_party/WebKit/LayoutTests/css3/motion-path/property-use-count-motion-rotation.html
[modify] https://crrev.com/9274fd6bfe4e948608f1b830d630438a077cef3d/third_party/WebKit/LayoutTests/css3/motion-path/property-use-count-offset-rotate.html
[modify] https://crrev.com/9274fd6bfe4e948608f1b830d630438a077cef3d/third_party/WebKit/LayoutTests/css3/motion-path/property-use-count-offset-rotation.html
[add] https://crrev.com/9274fd6bfe4e948608f1b830d630438a077cef3d/third_party/WebKit/LayoutTests/css3/motion-path/rotation-overflow-crash.html
[modify] https://crrev.com/9274fd6bfe4e948608f1b830d630438a077cef3d/third_party/WebKit/Source/core/css/CSSProperties.json5
[modify] https://crrev.com/9274fd6bfe4e948608f1b830d630438a077cef3d/third_party/WebKit/Source/core/frame/Deprecation.cpp
[modify] https://crrev.com/9274fd6bfe4e948608f1b830d630438a077cef3d/third_party/WebKit/Source/core/frame/UseCounter.cpp

Project Member

Comment 7 by bugdroid1@chromium.org, Apr 30 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/25825f60c805cf300a29b915b5f16cb508afecf9

commit 25825f60c805cf300a29b915b5f16cb508afecf9
Author: ericwilligers <ericwilligers@chromium.org>
Date: Sun Apr 30 23:18:29 2017

CSS Motion Path: delete implementation of offset-rotation property

The 'offset-rotation' property has been replaced by 'offset-rotate'.

'offset-rotation' is among the properties disabled in M58.

The runtime flag to conditionally enable 'offset-rotate' is also
being retired, as offset-rotate has shipped.

Intent to Remove: https://groups.google.com/a/chromium.org/d/msg/blink-dev/o1C5NzGf9Q0/FgU5o52yBAAJ

BUG= 711937 

Review-Url: https://codereview.chromium.org/2842933003
Cr-Commit-Position: refs/heads/master@{#468258}

[modify] https://crrev.com/25825f60c805cf300a29b915b5f16cb508afecf9/third_party/WebKit/LayoutTests/FlagExpectations/enable-blink-features=LayoutNG
[delete] https://crrev.com/2a7adc3543e9b9b0bf44563830a3502ceba76650/third_party/WebKit/LayoutTests/animations/composition/offset-rotation-composition.html
[delete] https://crrev.com/2a7adc3543e9b9b0bf44563830a3502ceba76650/third_party/WebKit/LayoutTests/animations/interpolation/offset-rotation-interpolation.html
[delete] https://crrev.com/2a7adc3543e9b9b0bf44563830a3502ceba76650/third_party/WebKit/LayoutTests/animations/responsive/offset-rotation-responsive.html
[delete] https://crrev.com/2a7adc3543e9b9b0bf44563830a3502ceba76650/third_party/WebKit/LayoutTests/css3/motion-path/offset-rotation-deprecated-expected.txt
[delete] https://crrev.com/2a7adc3543e9b9b0bf44563830a3502ceba76650/third_party/WebKit/LayoutTests/css3/motion-path/offset-rotation-deprecated.html
[delete] https://crrev.com/2a7adc3543e9b9b0bf44563830a3502ceba76650/third_party/WebKit/LayoutTests/css3/motion-path/offset-rotation.html
[modify] https://crrev.com/25825f60c805cf300a29b915b5f16cb508afecf9/third_party/WebKit/LayoutTests/css3/motion-path/offset.html
[modify] https://crrev.com/25825f60c805cf300a29b915b5f16cb508afecf9/third_party/WebKit/LayoutTests/css3/motion-path/offsetParent.html
[modify] https://crrev.com/25825f60c805cf300a29b915b5f16cb508afecf9/third_party/WebKit/LayoutTests/css3/motion-path/property-use-count-offset-rotate.html
[delete] https://crrev.com/2a7adc3543e9b9b0bf44563830a3502ceba76650/third_party/WebKit/LayoutTests/css3/motion-path/property-use-count-offset-rotation.html
[modify] https://crrev.com/25825f60c805cf300a29b915b5f16cb508afecf9/third_party/WebKit/LayoutTests/fast/css/getComputedStyle/computed-style-listing-expected.txt
[modify] https://crrev.com/25825f60c805cf300a29b915b5f16cb508afecf9/third_party/WebKit/LayoutTests/fast/css/getComputedStyle/computed-style-without-renderer-listing-expected.txt
[modify] https://crrev.com/25825f60c805cf300a29b915b5f16cb508afecf9/third_party/WebKit/LayoutTests/svg/css/getComputedStyle-listing-expected.txt
[modify] https://crrev.com/25825f60c805cf300a29b915b5f16cb508afecf9/third_party/WebKit/LayoutTests/virtual/stable/webexposed/css-properties-as-js-properties-expected.txt
[modify] https://crrev.com/25825f60c805cf300a29b915b5f16cb508afecf9/third_party/WebKit/LayoutTests/webexposed/css-properties-as-js-properties-expected.txt
[modify] https://crrev.com/25825f60c805cf300a29b915b5f16cb508afecf9/third_party/WebKit/Source/core/animation/CSSInterpolationTypesMap.cpp
[modify] https://crrev.com/25825f60c805cf300a29b915b5f16cb508afecf9/third_party/WebKit/Source/core/animation/CSSOffsetRotateInterpolationType.cpp
[modify] https://crrev.com/25825f60c805cf300a29b915b5f16cb508afecf9/third_party/WebKit/Source/core/animation/CSSOffsetRotateInterpolationType.h
[modify] https://crrev.com/25825f60c805cf300a29b915b5f16cb508afecf9/third_party/WebKit/Source/core/animation/css/CSSAnimatableValueFactory.cpp
[modify] https://crrev.com/25825f60c805cf300a29b915b5f16cb508afecf9/third_party/WebKit/Source/core/css/CSSComputedStyleDeclaration.cpp
[modify] https://crrev.com/25825f60c805cf300a29b915b5f16cb508afecf9/third_party/WebKit/Source/core/css/CSSProperties.json5
[modify] https://crrev.com/25825f60c805cf300a29b915b5f16cb508afecf9/third_party/WebKit/Source/core/css/CSSPropertyEquality.cpp
[modify] https://crrev.com/25825f60c805cf300a29b915b5f16cb508afecf9/third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp
[modify] https://crrev.com/25825f60c805cf300a29b915b5f16cb508afecf9/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp
[modify] https://crrev.com/25825f60c805cf300a29b915b5f16cb508afecf9/third_party/WebKit/Source/core/frame/Deprecation.cpp
[modify] https://crrev.com/25825f60c805cf300a29b915b5f16cb508afecf9/third_party/WebKit/Source/core/frame/UseCounter.cpp
[modify] https://crrev.com/25825f60c805cf300a29b915b5f16cb508afecf9/third_party/WebKit/Source/core/style/ComputedStyle.h
[modify] https://crrev.com/25825f60c805cf300a29b915b5f16cb508afecf9/third_party/WebKit/Source/core/style/StyleTransformData.cpp
[modify] https://crrev.com/25825f60c805cf300a29b915b5f16cb508afecf9/third_party/WebKit/Source/platform/RuntimeEnabledFeatures.json5

Project Member

Comment 8 by bugdroid1@chromium.org, May 1 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/612ac411762985a97166c4144ff0d049716a80db

commit 612ac411762985a97166c4144ff0d049716a80db
Author: ericwilligers <ericwilligers@chromium.org>
Date: Mon May 01 05:05:19 2017

CSS Motion Path: delete implementation of motion-offset property

The 'motion-offset' property has been replaced by 'offset-distance'.

'motion-offset' is among the properties disabled in M58.

Intent to Remove: https://groups.google.com/a/chromium.org/d/msg/blink-dev/o1C5NzGf9Q0/sbaLF1MbAgAJ

BUG= 711937 

Review-Url: https://codereview.chromium.org/2841863005
Cr-Commit-Position: refs/heads/master@{#468287}

[rename] https://crrev.com/612ac411762985a97166c4144ff0d049716a80db/third_party/WebKit/LayoutTests/animations/animations-responsive-offsetDistance.html
[delete] https://crrev.com/91f64acccbfe592af367f79ae74649d520528f0b/third_party/WebKit/LayoutTests/animations/composition/motion-offset-composition.html
[delete] https://crrev.com/91f64acccbfe592af367f79ae74649d520528f0b/third_party/WebKit/LayoutTests/animations/interpolation/motion-offset-interpolation.html
[modify] https://crrev.com/612ac411762985a97166c4144ff0d049716a80db/third_party/WebKit/LayoutTests/animations/retain-zero-percent.html
[modify] https://crrev.com/612ac411762985a97166c4144ff0d049716a80db/third_party/WebKit/LayoutTests/css-parser/unitless-length-quirk.html
[delete] https://crrev.com/91f64acccbfe592af367f79ae74649d520528f0b/third_party/WebKit/LayoutTests/css3/motion-path/motion-offset.html
[delete] https://crrev.com/91f64acccbfe592af367f79ae74649d520528f0b/third_party/WebKit/LayoutTests/css3/motion-path/motion-properties-deprecated-expected.txt
[delete] https://crrev.com/91f64acccbfe592af367f79ae74649d520528f0b/third_party/WebKit/LayoutTests/css3/motion-path/motion-properties-deprecated.html
[modify] https://crrev.com/612ac411762985a97166c4144ff0d049716a80db/third_party/WebKit/ManualTests/animation/compositor-transform-fill-forwards-with-motion-path.html
[modify] https://crrev.com/612ac411762985a97166c4144ff0d049716a80db/third_party/WebKit/ManualTests/animation/compositor-transform-halted-by-motion-path.html
[modify] https://crrev.com/612ac411762985a97166c4144ff0d049716a80db/third_party/WebKit/ManualTests/animation/compositor-transform-prevented-by-motion-path.html
[modify] https://crrev.com/612ac411762985a97166c4144ff0d049716a80db/third_party/WebKit/Source/core/css/CSSProperties.json5
[modify] https://crrev.com/612ac411762985a97166c4144ff0d049716a80db/third_party/WebKit/Source/core/frame/Deprecation.cpp
[modify] https://crrev.com/612ac411762985a97166c4144ff0d049716a80db/third_party/WebKit/Source/core/frame/UseCounter.cpp

Status: Fixed (was: Assigned)
Project Member

Comment 10 by bugdroid1@chromium.org, May 1 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d62951aca80fa961d7feb4c05fe62b0893f59bfd

commit d62951aca80fa961d7feb4c05fe62b0893f59bfd
Author: suzyh <suzyh@chromium.org>
Date: Mon May 01 05:32:29 2017

Revert of CSS Motion Path: delete implementation of motion-offset property (patchset #2 id:40001 of https://codereview.chromium.org/2841863005/ )

Reason for revert:
Speculatively reverting due to build failure on Mac https://build.chromium.org/p/chromium/builders/Mac/builds/26841

Original issue's description:
> CSS Motion Path: delete implementation of motion-offset property
>
> The 'motion-offset' property has been replaced by 'offset-distance'.
>
> 'motion-offset' is among the properties disabled in M58.
>
> Intent to Remove: https://groups.google.com/a/chromium.org/d/msg/blink-dev/o1C5NzGf9Q0/sbaLF1MbAgAJ
>
> BUG= 711937 
>
> Review-Url: https://codereview.chromium.org/2841863005
> Cr-Commit-Position: refs/heads/master@{#468287}
> Committed: https://chromium.googlesource.com/chromium/src/+/612ac411762985a97166c4144ff0d049716a80db

TBR=bugsnash@chromium.org,meade@chromium.org,ericwilligers@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 711937 

Review-Url: https://codereview.chromium.org/2856513002
Cr-Commit-Position: refs/heads/master@{#468291}

[rename] https://crrev.com/d62951aca80fa961d7feb4c05fe62b0893f59bfd/third_party/WebKit/LayoutTests/animations/animations-responsive-motionOffset.html
[add] https://crrev.com/d62951aca80fa961d7feb4c05fe62b0893f59bfd/third_party/WebKit/LayoutTests/animations/composition/motion-offset-composition.html
[add] https://crrev.com/d62951aca80fa961d7feb4c05fe62b0893f59bfd/third_party/WebKit/LayoutTests/animations/interpolation/motion-offset-interpolation.html
[modify] https://crrev.com/d62951aca80fa961d7feb4c05fe62b0893f59bfd/third_party/WebKit/LayoutTests/animations/retain-zero-percent.html
[modify] https://crrev.com/d62951aca80fa961d7feb4c05fe62b0893f59bfd/third_party/WebKit/LayoutTests/css-parser/unitless-length-quirk.html
[add] https://crrev.com/d62951aca80fa961d7feb4c05fe62b0893f59bfd/third_party/WebKit/LayoutTests/css3/motion-path/motion-offset.html
[add] https://crrev.com/d62951aca80fa961d7feb4c05fe62b0893f59bfd/third_party/WebKit/LayoutTests/css3/motion-path/motion-properties-deprecated-expected.txt
[add] https://crrev.com/d62951aca80fa961d7feb4c05fe62b0893f59bfd/third_party/WebKit/LayoutTests/css3/motion-path/motion-properties-deprecated.html
[modify] https://crrev.com/d62951aca80fa961d7feb4c05fe62b0893f59bfd/third_party/WebKit/ManualTests/animation/compositor-transform-fill-forwards-with-motion-path.html
[modify] https://crrev.com/d62951aca80fa961d7feb4c05fe62b0893f59bfd/third_party/WebKit/ManualTests/animation/compositor-transform-halted-by-motion-path.html
[modify] https://crrev.com/d62951aca80fa961d7feb4c05fe62b0893f59bfd/third_party/WebKit/ManualTests/animation/compositor-transform-prevented-by-motion-path.html
[modify] https://crrev.com/d62951aca80fa961d7feb4c05fe62b0893f59bfd/third_party/WebKit/Source/core/css/CSSProperties.json5
[modify] https://crrev.com/d62951aca80fa961d7feb4c05fe62b0893f59bfd/third_party/WebKit/Source/core/frame/Deprecation.cpp
[modify] https://crrev.com/d62951aca80fa961d7feb4c05fe62b0893f59bfd/third_party/WebKit/Source/core/frame/UseCounter.cpp

Project Member

Comment 11 by bugdroid1@chromium.org, May 1 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/71f3bd1682b75efac412a7431adae78afb8a903b

commit 71f3bd1682b75efac412a7431adae78afb8a903b
Author: ericwilligers <ericwilligers@chromium.org>
Date: Mon May 01 06:57:22 2017

Reland of CSS Motion Path: delete implementation of motion-offset property (patchset #1 id:1 of https://codereview.chromium.org/2856513002/ )

Reason for revert:
https://codereview.chromium.org/2841863005 was extremely unlikely to be the root cause of Mac-specific failures.

Original issue's description:
> Revert of CSS Motion Path: delete implementation of motion-offset property (patchset #2 id:40001 of https://codereview.chromium.org/2841863005/ )
>
> Reason for revert:
> Speculatively reverting due to build failure on Mac https://build.chromium.org/p/chromium/builders/Mac/builds/26841
>
> Original issue's description:
> > CSS Motion Path: delete implementation of motion-offset property
> >
> > The 'motion-offset' property has been replaced by 'offset-distance'.
> >
> > 'motion-offset' is among the properties disabled in M58.
> >
> > Intent to Remove: https://groups.google.com/a/chromium.org/d/msg/blink-dev/o1C5NzGf9Q0/sbaLF1MbAgAJ
> >
> > BUG= 711937 
> >
> > Review-Url: https://codereview.chromium.org/2841863005
> > Cr-Commit-Position: refs/heads/master@{#468287}
> > Committed: https://chromium.googlesource.com/chromium/src/+/612ac411762985a97166c4144ff0d049716a80db
>
> TBR=bugsnash@chromium.org,meade@chromium.org,ericwilligers@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG= 711937 
>
> Review-Url: https://codereview.chromium.org/2856513002
> Cr-Commit-Position: refs/heads/master@{#468291}
> Committed: https://chromium.googlesource.com/chromium/src/+/d62951aca80fa961d7feb4c05fe62b0893f59bfd

TBR=bugsnash@chromium.org,meade@chromium.org,suzyh@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 711937 

Review-Url: https://codereview.chromium.org/2856523002
Cr-Commit-Position: refs/heads/master@{#468301}

[rename] https://crrev.com/71f3bd1682b75efac412a7431adae78afb8a903b/third_party/WebKit/LayoutTests/animations/animations-responsive-offsetDistance.html
[delete] https://crrev.com/78f1ed5b275c87a998bcb2c4d0d79af92316394d/third_party/WebKit/LayoutTests/animations/composition/motion-offset-composition.html
[delete] https://crrev.com/78f1ed5b275c87a998bcb2c4d0d79af92316394d/third_party/WebKit/LayoutTests/animations/interpolation/motion-offset-interpolation.html
[modify] https://crrev.com/71f3bd1682b75efac412a7431adae78afb8a903b/third_party/WebKit/LayoutTests/animations/retain-zero-percent.html
[modify] https://crrev.com/71f3bd1682b75efac412a7431adae78afb8a903b/third_party/WebKit/LayoutTests/css-parser/unitless-length-quirk.html
[delete] https://crrev.com/78f1ed5b275c87a998bcb2c4d0d79af92316394d/third_party/WebKit/LayoutTests/css3/motion-path/motion-offset.html
[delete] https://crrev.com/78f1ed5b275c87a998bcb2c4d0d79af92316394d/third_party/WebKit/LayoutTests/css3/motion-path/motion-properties-deprecated-expected.txt
[delete] https://crrev.com/78f1ed5b275c87a998bcb2c4d0d79af92316394d/third_party/WebKit/LayoutTests/css3/motion-path/motion-properties-deprecated.html
[modify] https://crrev.com/71f3bd1682b75efac412a7431adae78afb8a903b/third_party/WebKit/ManualTests/animation/compositor-transform-fill-forwards-with-motion-path.html
[modify] https://crrev.com/71f3bd1682b75efac412a7431adae78afb8a903b/third_party/WebKit/ManualTests/animation/compositor-transform-halted-by-motion-path.html
[modify] https://crrev.com/71f3bd1682b75efac412a7431adae78afb8a903b/third_party/WebKit/ManualTests/animation/compositor-transform-prevented-by-motion-path.html
[modify] https://crrev.com/71f3bd1682b75efac412a7431adae78afb8a903b/third_party/WebKit/Source/core/css/CSSProperties.json5
[modify] https://crrev.com/71f3bd1682b75efac412a7431adae78afb8a903b/third_party/WebKit/Source/core/frame/Deprecation.cpp
[modify] https://crrev.com/71f3bd1682b75efac412a7431adae78afb8a903b/third_party/WebKit/Source/core/frame/UseCounter.cpp

Sign in to add a comment