Issue metadata
Sign in to add a comment
|
Heap-buffer-overflow in GrBufferAllocPool::putBack |
||||||||||||||||||||||
Issue descriptionDetailed report: https://clusterfuzz.com/testcase?key=5573891214016512 Fuzzer: ifratric-browserfuzzer-v3 Job Type: mac_asan_chrome Platform Id: mac Crash Type: Heap-buffer-overflow READ 8 Crash Address: 0x60200005b2e8 Crash State: GrBufferAllocPool::putBack DefaultPathOp::onPrepareDraws GrMeshDrawOp::onPrepare Sanitizer: address (ASAN) Recommended Security Severity: Medium Regressed: https://clusterfuzz.com/revisions?job=mac_asan_chrome&range=463718:463770 Reproducer Testcase: https://clusterfuzz.com/download/AMIfv96TaEH6svYejZQBO_koYpm3P-u5-MRjcJVwYfErgafCOfW5GVaEIagLzV0vN1c1E38aADhcbAqjrNfzJygcPDj7sLNyAkNYrqfH4ikUkZSHB2faeiGbIsjBCUzDhUx678Gj0zMTAqAfyFTUwQVffi0WaeqgjERwoTP5H-D3ymo3mdJ-_oOdUfdZQ2eqLopkixRvsOjH6vxK2wicxv85JDJ5Dm2-DLzrpNyeuiBIG_j5mVSKqcsS7s-C_G5RUr7d8_o7ACoRd1325SidLPIEYC7QLm709b3MB5epsmMu-3A2PjViaq8BSEbRxSYj6py1K5F92625V_hovKMF_JFStTjtEgTxrYONDYuQ-UBfH-aUyjs3Eao?testcase_id=5573891214016512 Issue filed automatically. See https://dev.chromium.org/Home/chromium-security/bugs/reproducing-clusterfuzz-bugs for more information.
,
Apr 16 2017
This issue is a security regression. If you are not able to fix this quickly, please revert the change that introduced it. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Apr 16 2017
,
Apr 18 2017
msarett: your CL was the only one in the blame range for this one. It didn't look directly related, but can you please investigate and retriage if necessary?
,
Apr 18 2017
,
Apr 18 2017
,
Apr 18 2017
Moving some of the draw op work tickling something here? +Brian (though ooo) and Ganesh team/wrangler
,
Apr 18 2017
+robert, wrangler
,
Apr 18 2017
The following revision refers to this bug: https://skia.googlesource.com/skia/+/b712a85aea212cf5bfe5514a4fefc184545a8d3c commit b712a85aea212cf5bfe5514a4fefc184545a8d3c Author: Robert Phillips <robertphillips@google.com> Date: Tue Apr 18 21:38:30 2017 Fix missing tolerance in GrPathUtils::worstCasePointCount https://skia-review.googlesource.com/c/10752/ (Use correct tolerance for conic chopping in MSAA and default path renderers) changed the tolerance used in createGeom but didn't change the setting in worstCasePointCount. Bug: 711936 , 712749 Change-Id: I540d8bc8cfdebc3eae5204e1acfeba3cefc2b12e Reviewed-on: https://skia-review.googlesource.com/13768 Reviewed-by: Greg Daniel <egdaniel@google.com> Commit-Queue: Robert Phillips <robertphillips@google.com> [modify] https://crrev.com/b712a85aea212cf5bfe5514a4fefc184545a8d3c/src/gpu/GrPathUtils.cpp
,
Apr 19 2017
,
Apr 19 2017
ClusterFuzz has detected this issue as fixed in range 465462:465477. Detailed report: https://clusterfuzz.com/testcase?key=5573891214016512 Fuzzer: ifratric-browserfuzzer-v3 Job Type: mac_asan_chrome Platform Id: mac Crash Type: Heap-buffer-overflow READ 8 Crash Address: 0x60200005b2e8 Crash State: GrBufferAllocPool::putBack DefaultPathOp::onPrepareDraws GrMeshDrawOp::onPrepare Sanitizer: address (ASAN) Recommended Security Severity: Medium Regressed: https://clusterfuzz.com/revisions?job=mac_asan_chrome&range=463718:463770 Fixed: https://clusterfuzz.com/revisions?job=mac_asan_chrome&range=465462:465477 Reproducer Testcase: https://clusterfuzz.com/download/AMIfv96TaEH6svYejZQBO_koYpm3P-u5-MRjcJVwYfErgafCOfW5GVaEIagLzV0vN1c1E38aADhcbAqjrNfzJygcPDj7sLNyAkNYrqfH4ikUkZSHB2faeiGbIsjBCUzDhUx678Gj0zMTAqAfyFTUwQVffi0WaeqgjERwoTP5H-D3ymo3mdJ-_oOdUfdZQ2eqLopkixRvsOjH6vxK2wicxv85JDJ5Dm2-DLzrpNyeuiBIG_j5mVSKqcsS7s-C_G5RUr7d8_o7ACoRd1325SidLPIEYC7QLm709b3MB5epsmMu-3A2PjViaq8BSEbRxSYj6py1K5F92625V_hovKMF_JFStTjtEgTxrYONDYuQ-UBfH-aUyjs3Eao?testcase_id=5573891214016512 See https://dev.chromium.org/Home/chromium-security/bugs/reproducing-clusterfuzz-bugs for more information. If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
,
Apr 19 2017
ClusterFuzz testcase 5573891214016512 is verified as fixed, so closing issue. If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.
,
Apr 19 2017
Just for closure: the fix rolled into Chrome as 465473.
,
Apr 19 2017
This bug is in M59 and the fix is very simple.
,
Apr 19 2017
,
Apr 20 2017
Your change meets the bar and is auto-approved for M59. Please go ahead and merge the CL to branch 3071 manually. Please contact milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), gkihumba@(ChromeOS), Abdul Syed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Apr 20 2017
The following revision refers to this bug: https://skia.googlesource.com/skia/+/6a4c239e9da587c612a002b7d600598a478d63e8 commit 6a4c239e9da587c612a002b7d600598a478d63e8 Author: Robert Phillips <robertphillips@google.com> Date: Thu Apr 20 12:04:22 2017 [M59 cherrypick] Fix missing tolerance in GrPathUtils::worstCasePointCount https://skia-review.googlesource.com/c/10752/ (Use correct tolerance for conic chopping in MSAA and default path renderers) changed the tolerance used in createGeom but didn't change the setting in worstCasePointCount. NOTREECHECKS=true NOTRY=true NOPRESUBMIT=true Bug: 711936 , 712749 Change-Id: I554bdd637ee13c0d3ba77483763929dfcd9eb73a Reviewed-on: https://skia-review.googlesource.com/13960 Reviewed-by: Robert Phillips <robertphillips@google.com> [modify] https://crrev.com/6a4c239e9da587c612a002b7d600598a478d63e8/src/gpu/GrPathUtils.cpp
,
Apr 20 2017
,
Apr 21 2017
Please merge your change to M59 branch #3071 latest before 4:00 PM PT, Monday (04/24) so we can take it for next week last M59 dev release. Thank you.
,
Apr 24 2017
It was merged into Skia's M59 branch on 4/20 in https://skia-review.googlesource.com/c/13960/ ([M59 cherrypick] Fix missing tolerance in GrPathUtils::worstCasePointCount)
,
Apr 24 2017
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible! If all merges have been completed, please remove any remaining Merge-Approved labels from this issue. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Apr 24 2017
,
Jul 26 2017
This bug has been closed for more than 14 weeks. Removing security view restrictions. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by sheriffbot@chromium.org
, Apr 16 2017