New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 711895 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Last visit > 30 days ago
Closed: Apr 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Mac
Pri: 1
Type: Bug-Security



Sign in to add a comment

Heap-buffer-overflow in read_big_endian_u32

Project Member Reported by ClusterFuzz, Apr 15 2017

Issue description

Project Member

Comment 1 by ClusterFuzz, Apr 15 2017

Labels: OS-Linux
Project Member

Comment 2 by sheriffbot@chromium.org, Apr 15 2017

Labels: M-59
Project Member

Comment 3 by sheriffbot@chromium.org, Apr 15 2017

Labels: ReleaseBlock-Beta
This issue is a security regression. If you are not able to fix this quickly, please revert the change that introduced it.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 4 by sheriffbot@chromium.org, Apr 15 2017

Labels: Pri-1
Project Member

Comment 5 by sheriffbot@chromium.org, Apr 16 2017

Labels: M-59
Cc: msarett@chromium.org
Components: Internals>Skia
Owner: hcm@chromium.org
Status: Assigned (was: Untriaged)
Hi Skia folks, do you mind taking a look at this one? There was nothing interesting in the blame range for this.
Cc: -msarett@chromium.org hcm@chromium.org
Owner: msarett@chromium.org
Project Member

Comment 8 by bugdroid1@chromium.org, Apr 18 2017

The following revision refers to this bug:
  https://skia.googlesource.com/skia/+/6e834799946537370e6f3c10aa2745ed969b2a27

commit 6e834799946537370e6f3c10aa2745ed969b2a27
Author: Matt Sarett <msarett@google.com>
Date: Tue Apr 18 15:37:29 2017

Fix out of bounds read in SkColorSpace::MakeICC

Bug:  711895 
Change-Id: I8574289bda842cf1be3fb5bcf347a81b98fdc6b0
Reviewed-on: https://skia-review.googlesource.com/13690
Commit-Queue: Matt Sarett <msarett@google.com>
Reviewed-by: Mike Klein <mtklein@chromium.org>

[modify] https://crrev.com/6e834799946537370e6f3c10aa2745ed969b2a27/src/core/SkColorSpace_ICC.cpp

Project Member

Comment 9 by ClusterFuzz, Apr 19 2017

ClusterFuzz has detected this issue as fixed in range 465252:465271.

Detailed report: https://clusterfuzz.com/testcase?key=4581502580162560

Fuzzer: libfuzzer_skia_color_space_fuzzer
Job Type: mac_libfuzzer_chrome_asan
Platform Id: mac

Crash Type: Heap-buffer-overflow READ 1
Crash Address: 0x61c000001764
Crash State:
  read_big_endian_u32
  load_a2b0
  make_a2b
  
Sanitizer: address (ASAN)

Recommended Security Severity: Medium

Regressed: https://clusterfuzz.com/revisions?job=mac_libfuzzer_chrome_asan&range=463138:463173
Fixed: https://clusterfuzz.com/revisions?job=mac_libfuzzer_chrome_asan&range=465252:465271

Reproducer Testcase: https://clusterfuzz.com/download/AMIfv96FA8KfVSoZudCA8F_PgysIwGVtcgG7mMlqiILzaJ1o2SO6M1-zafRRS5F579ZEcalZG6snUQeN6X8jDGZ3oYRb86q2yWgcdoe-1TKdyZHqY75YcAyCRS468iDC5JW_jlunFOAgwQ0O6zbd2t4xWkALzVorxKZZznEKXPX8Bh6ax6WEZhPfJAluB864TPjSEwH8RbnOcfMcdUAjQuiAHxErVT2fvoBn_qbeSylIH0b_RJXVx6PLhwJaRwOOsxRYjb0_DgJErb3NlS_B86e1ZgoZEQxhdxxmlWkxxegd8DJluJ8BzCbj3CcdsHFWcYwK2en97Eev2s11_YIvNEsU4FyH33maWizXryUaBdkIIpH3N9iaC54?testcase_id=4581502580162560


See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reproducing.md for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 10 by ClusterFuzz, Apr 19 2017

Labels: ClusterFuzz-Verified
Status: Verified (was: Assigned)
ClusterFuzz testcase 4581502580162560 is verified as fixed, so closing issue.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.
Project Member

Comment 11 by sheriffbot@chromium.org, Apr 19 2017

Labels: -Restrict-View-SecurityTeam Restrict-View-SecurityNotify
Labels: Merge-Request-59
Project Member

Comment 13 by sheriffbot@chromium.org, Apr 21 2017

Labels: -Merge-Request-59 Hotlist-Merge-Approved Merge-Approved-59
Your change meets the bar and is auto-approved for M59. Please go ahead and merge the CL to branch 3071 manually. Please contact milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), gkihumba@(ChromeOS), Abdul Syed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 14 by bugdroid1@chromium.org, Apr 21 2017

Labels: merge-merged-m59
The following revision refers to this bug:
  https://skia.googlesource.com/skia/+/e0e50cfe755fe5a28706b98a721b9ebbc1ee84d7

commit e0e50cfe755fe5a28706b98a721b9ebbc1ee84d7
Author: Matt Sarett <msarett@google.com>
Date: Fri Apr 21 21:08:47 2017

Fix out of bounds read in SkColorSpace::MakeICC

Bug:  711895 
Change-Id: I8574289bda842cf1be3fb5bcf347a81b98fdc6b0
Reviewed-on: https://skia-review.googlesource.com/13690
Commit-Queue: Matt Sarett <msarett@google.com>
Reviewed-by: Mike Klein <mtklein@chromium.org>
(cherry picked from commit 6e834799946537370e6f3c10aa2745ed969b2a27)
Reviewed-on: https://skia-review.googlesource.com/14103
Reviewed-by: Matt Sarett <msarett@google.com>

[modify] https://crrev.com/e0e50cfe755fe5a28706b98a721b9ebbc1ee84d7/src/core/SkColorSpace_ICC.cpp

Please merge your change to M59 branch #3071 latest before 4:00 PM PT, Monday (04/24) so we can take it for next week last M59 dev release. Thank you.
It has been merged per #59.
Labels: -ReleaseBlock-Beta -Hotlist-Merge-Approved -Merge-Approved-59
Project Member

Comment 18 by sheriffbot@chromium.org, Jul 26 2017

Labels: -Restrict-View-SecurityNotify allpublic
This bug has been closed for more than 14 weeks. Removing security view restrictions.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Sign in to add a comment