New issue
Advanced search Search tips

Issue 711889 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Apr 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug-Security



Sign in to add a comment

Heap-buffer-overflow in CFX_SAXReader::ParseChar

Project Member Reported by ClusterFuzz, Apr 15 2017

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=5181539374858240

Fuzzer: afl_pdf_cfx_saxreader_fuzzer
Job Type: afl_chrome_asan
Platform Id: linux

Crash Type: Heap-buffer-overflow WRITE 1
Crash Address: 0x6150000007ae
Crash State:
  CFX_SAXReader::ParseChar
  CFX_SAXReader::ParseText
  CFX_SAXReader::ContinueParse
  
Sanitizer: address (ASAN)

Recommended Security Severity: High

Reproducer Testcase: https://clusterfuzz.com/download/AMIfv945fDuoyllzkCLHcagKsv4CD50iziHIUNRtZadJScg_KE9nRI8tqi17LC63OUpoHH1TAgWq_rTxmOzMaFXYNrib-GNoSaJEDsZTMhffINDUAELTWnWvPYar-s8I5evvQjwfdTCY5wJT4qsLIlSUt1E_3E7txt7rkgFA-RakmeIA5kesYKfazXwtWrbF1CBQrBCugojRQw-lDnMNXXwU3wyODYqFwsWwkfGIus7Hgtho4vqz5i1ycbNAiSBSaBcO8tBaBOZ4rx246EA6kwk35gBuYYdvNXy2j1y_81wS2nQTSF3HQkYFUl90mwJD9Z0j3B81OHxGo8lUZ94fX0KKEMoxNKOD5dfWkfyVE98GjDQqMoSwexM?testcase_id=5181539374858240


Issue filed automatically.

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reproducing.md for more information.
 
Project Member

Comment 1 by sheriffbot@chromium.org, Apr 15 2017

Labels: M-57
Project Member

Comment 2 by sheriffbot@chromium.org, Apr 15 2017

Labels: Pri-1
Components: Internals>Plugins>PDF
Owner: tsepez@chromium.org
Status: Assigned (was: Untriaged)
Hi Tom, do you mind having a look at this? Not sure if this component in PDFium is enabled in Chrome.

Comment 4 by est...@chromium.org, Apr 18 2017

tsepez, could you please help triage? Thank you!

Comment 5 by est...@chromium.org, Apr 18 2017

Doh, sheriffing collision :)
Project Member

Comment 6 by sheriffbot@chromium.org, Apr 20 2017

Labels: -M-57 M-58

Comment 7 by tsepez@chromium.org, Apr 20 2017

I would have expected https://pdfium-review.googlesource.com/4230 to have taken care of this.  I will see if it still repros following that.

Comment 8 by tsepez@chromium.org, Apr 20 2017

Aha.  The autoroller has been failing for some time and the above hasn't made it into chromium's DEPS yet.  I think this will auto-close when that happens.
Project Member

Comment 9 by ClusterFuzz, Apr 25 2017

ClusterFuzz has detected this issue as fixed in range 465939:466784.

Detailed report: https://clusterfuzz.com/testcase?key=5181539374858240

Fuzzer: afl_pdf_cfx_saxreader_fuzzer
Job Type: afl_chrome_asan
Platform Id: linux

Crash Type: Heap-buffer-overflow WRITE 1
Crash Address: 0x6150000007ae
Crash State:
  CFX_SAXReader::ParseChar
  CFX_SAXReader::ParseText
  CFX_SAXReader::ContinueParse
  
Sanitizer: address (ASAN)

Recommended Security Severity: High

Fixed: https://clusterfuzz.com/revisions?job=afl_chrome_asan&range=465939:466784

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5181539374858240


See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reproducing.md for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 10 by ClusterFuzz, Apr 25 2017

Labels: ClusterFuzz-Verified
Status: Verified (was: Assigned)
ClusterFuzz testcase 5181539374858240 is verified as fixed, so closing issue.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.
Project Member

Comment 11 by sheriffbot@chromium.org, Apr 25 2017

Labels: -Restrict-View-SecurityTeam Restrict-View-SecurityNotify
Project Member

Comment 12 by sheriffbot@chromium.org, Apr 28 2017

Labels: Merge-Request-59
Project Member

Comment 13 by sheriffbot@chromium.org, Apr 29 2017

Labels: -Merge-Request-59 Hotlist-Merge-Approved Merge-Approved-59
Your change meets the bar and is auto-approved for M59. Please go ahead and merge the CL to branch 3071 manually. Please contact milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), gkihumba@(ChromeOS), Abdul Syed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -M-58 M-60 M-59
Project Member

Comment 15 by sheriffbot@chromium.org, May 2 2017

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Merge-Approved-59 Merge-Rejected-59
XFA-only feature => not shipping => merge not required.
Labels: -Security_Impact-Stable -Hotlist-Merge-Approved Security_Impact-None
Project Member

Comment 18 by sheriffbot@chromium.org, Aug 1 2017

Labels: -Restrict-View-SecurityNotify allpublic
This bug has been closed for more than 14 weeks. Removing security view restrictions.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Sign in to add a comment