New issue
Advanced search Search tips

Issue 711879 link

Starred by 0 users
Status: Verified
Owner:
vapier@chromium.org
Closed: Apr 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Feature



Sign in to add a comment

nassh: omnibox support for "ssh" keyword

Project Member Reported by vapier@chromium.org, Apr 15 2017 
you could start typing "ssh" and then after that you could enter normal connection specs (like root@localhost:1234).  it'd also autocomplete to existing profiles and you could select them instead.

the downsides:
* if you're lazy with omnibox searching and you type "ssh asdf" expecting to do a Google search, that isn't going to work out :).  you need to type out "?ssh asdf", or select from the omnibox drop down to do a google search instead.
* i can't figure out a way to have it launch a new window, so all autocompletes will be in a tab.
* it doesn't seem to be possible to put omnibox integration behind a flag ... binding to "ssh" is done in the manifest.

i could use "nassh" instead, but i'm thinking the downsides wrt "ssh" google searches maybe isn't so bad.  and no one is going to discover "nassh" :).

public thread:
https://groups.google.com/a/chromium.org/d/topic/chromium-hterm/TFT1aD_3bc8/discussion
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 17 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/apps/libapps/+/153ce34eb7eb749ef97166f70e7b18a2ab7f119d

commit 153ce34eb7eb749ef97166f70e7b18a2ab7f119d
Author: Mike Frysinger <vapier@chromium.org>
Date: Mon Apr 17 18:37:40 2017

nassh: integrate with omniboxes via the "ssh" keyword

This let's people type "ssh root@host" into the omnibox to launch a ssh
session in a tab.  They can use alt+enter to open in a window instead.

The downside is that it overrides people who select the omnibox and do
a search that starts with "ssh" -- it'll now go to this app.  You can
still do an explicit search by using "?ssh", or by hitting ctrl+k.  It
isn't possible currently to make omnibox integration an option as the
keyword setting is in the extension manifest.

BUG= chromium:711879 

Change-Id: I8c8552186cb125e1532ed3906688d9e982cbaf8f
Reviewed-on: https://chromium-review.googlesource.com/479213
Reviewed-by: Rob Ginda <rginda@chromium.org>
Tested-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/153ce34eb7eb749ef97166f70e7b18a2ab7f119d/nassh/manifest.json
[modify] https://crrev.com/153ce34eb7eb749ef97166f70e7b18a2ab7f119d/nassh/_locales/en/messages.json
[modify] https://crrev.com/153ce34eb7eb749ef97166f70e7b18a2ab7f119d/nassh/js/nassh_background.js
[modify] https://crrev.com/153ce34eb7eb749ef97166f70e7b18a2ab7f119d/nassh/doc/FAQ.md
[modify] https://crrev.com/153ce34eb7eb749ef97166f70e7b18a2ab7f119d/nassh/js/nassh_app.js

Comment 2 by vapier@chromium.org, Apr 17 2017

Status: Fixed (was: Available)
this is part of the 0.8.36.2 release.  hopefully people like it.

Comment 3 by vapier@chromium.org, Apr 17 2017 

ftr, the idea was started by David Leadbeater with his extension:
https://chrome.google.com/webstore/detail/dingbhmhcnplmffokfmlhnlpapemdbbk

Comment 4 by abod...@chromium.org, May 9 2017

Status: Verified (was: Fixed)
Project Member

Comment 5 by bugdroid1@chromium.org, Aug 3 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/apps/libapps/+/18efe2bfa8f40061985f82c60880da4cfede61db

commit 18efe2bfa8f40061985f82c60880da4cfede61db
Author: Mike Frysinger <vapier@chromium.org>
Date: Thu Aug 03 17:27:47 2017

nassh: add another omnibox FAQ

BUG= chromium:711879 

Change-Id: If84a2fa7a4f3d5dd9f08e96246663a219f518ce3
Reviewed-on: https://chromium-review.googlesource.com/594853
Tested-by: Mike Frysinger <vapier@chromium.org>
Reviewed-by: Brandon Gilmore <varz@google.com>

[modify] https://crrev.com/18efe2bfa8f40061985f82c60880da4cfede61db/nassh/doc/FAQ.md
►

Sign in to add a comment