New issue
Advanced search Search tips

Issue 711877 link

Starred by 4 users

Issue metadata

Status: ExternalDependency
Owner: ----
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug



Sign in to add a comment

nassh: initial ssh:// uri handler prompt flashes when using a relay host

Project Member Reported by vapier@chromium.org, Apr 15 2017

Issue description

to reproduce:
(1) go to chrome://settings/handlers and delete ssh handlers
(2) load secure shell
(3) connect to a system via a relay
(4) watch ssh:// prompt pop up briefly, but then be dismissed by the redirect/page reload due to the relay
 

Comment 1 by vapier@chromium.org, May 25 2017

Issue 726219 has been merged into this issue.

Comment 2 by vapier@chromium.org, Nov 11 2017

Blockedon: 362725
i remember now why it's this way -- navigator.registerProtocolHandler works only if it's part of a user generated event code path.  the connect dialog is the last place where that signal exists so that's where we make the register call.

nassh.ConnectDialog.prototype.connect = function(name, argv) {
  this.maybeCopyPlaceholders_();
  this.save();

  // Since the user has initiated this connection, register the protocol.
  nassh.registerProtocolHandler();

  var items = {
    '/nassh/connectDialog/lastProfileId': this.currentProfileRecord_.id
  };
  chrome.storage.local.set(items);

  if (this.form_.checkValidity())
    this.postMessage('connectToProfile', [this.currentProfileRecord_.id]);
};

after we post the message, the main window gets that event and starts the actual connection, but Chrome doesn't have any of that tagged as user generated.

this will probably have to wait until we rework the connection dialog flow in issue 362725.

Comment 3 Deleted

Blockedon: -362725
i've filed b/122463446 to track adding support for method=direct to the Google relay servers.  once we have that, we don't need the redirect to the relay page anymore, so the terminal won't be reloaded at all, and the prompt would stay in place.

along those lines, it's not dependent upon the iframe change in the connection dialog.  i thought there might be another bug related to reworking the connect/relay flow, but that prob was fixed enough for the ssh-fe code (i.e. https://chromium-review.googlesource.com/c/1390222).
Status: ExternalDependency (was: Untriaged)

Sign in to add a comment