New issue
Advanced search Search tips

Issue 711825 link

Starred by 2 users
Status: Fixed
Owner:
emir...@chromium.org
Closed: Apr 2017
Cc:
braveyao@chromium.org
mcasas@chromium.org
niklase@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug



Sign in to add a comment

Avoid setting alpha mode for H264 webm container

Project Member Reported by emir...@chromium.org, Apr 14 2017 
In WebmMuxer we set alpha mode for all containers, see https://cs.chromium.org/chromium/src/media/muxers/webm_muxer.cc?rcl=c194280c502d5d001fd80fc8b547c5f9057a4bca&l=249. However, on demuxer side ffmpeg does not expect alpha mode for H264. Instead of the below change on demuxer side, we should skip setting alpha for H264 on the muxer side.
https://codereview.chromium.org/2801803002/diff/200001/media/ffmpeg/ffmpeg_common.cc
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 15 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/097db1d2d5de77aec5c32c710bd90b7a481deb09

commit 097db1d2d5de77aec5c32c710bd90b7a481deb09
Author: emircan <emircan@chromium.org>
Date: Sat Apr 15 02:48:37 2017

Avoid setting alpha mode for H264 webm containers

BUG= 711825 
TEST=Tested MediaRecorder H264 playback on Android.

Review-Url: https://codereview.chromium.org/2815303005
Cr-Commit-Position: refs/heads/master@{#464852}

[modify] https://crrev.com/097db1d2d5de77aec5c32c710bd90b7a481deb09/media/muxers/webm_muxer.cc

Comment 2 by mcasas@chromium.org, Apr 15 2017

Status: Fixed (was: Started)

Comment 3 by emir...@chromium.org, Apr 17 2017

Labels: Merge-Request-59
Project Member

Comment 4 by sheriffbot@chromium.org, Apr 17 2017

Labels: -Merge-Request-59 Hotlist-Merge-Approved Merge-Approved-59
Your change meets the bar and is auto-approved for M59. Please go ahead and merge the CL to branch 3071 manually. Please contact milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), gkihumba@(ChromeOS), Abdul Syed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 5 by bugdroid1@chromium.org, Apr 17 2017

Labels: -merge-approved-59 merge-merged-3071
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dd94f8db03cccb08ae148509a52981b3c6d16d3e

commit dd94f8db03cccb08ae148509a52981b3c6d16d3e
Author: emircan <emircan@chromium.org>
Date: Mon Apr 17 19:58:28 2017

Merge 59: Avoid setting alpha mode for H264 webm containers

BUG= 711825 
TEST=Tested MediaRecorder H264 playback on Android.

Review-Url: https://codereview.chromium.org/2815303005
Cr-Commit-Position: refs/heads/master@{#464852}
(cherry picked from commit 097db1d2d5de77aec5c32c710bd90b7a481deb09)
NOTRY=true
NOPRESUBMIT=true
TBR=mcasas@chromium.org

Review-Url: https://codereview.chromium.org/2823983002
Cr-Commit-Position: refs/branch-heads/3071@{#22}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}

[modify] https://crrev.com/dd94f8db03cccb08ae148509a52981b3c6d16d3e/media/muxers/webm_muxer.cc
►

Sign in to add a comment