New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 711822 link

Starred by 3 users

Issue metadata

Status: Verified
Owner:
Closed: May 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Display "Restart to update Adobe Flash Player for flash updates.

Project Member Reported by kerrnel@chromium.org, Apr 14 2017

Issue description

When Flash player is updated through component update on Chrome OS, users have been confused by clicking the "Update to restart" menu item, and not seeing the system version upgrade.

The UI Team has approved showing the text "Restart to update Adobe Flash Player" so that users understand what is actually being updated.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 20 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ed2af8b429def7ee0de3d62efe1f07e7d61c1ed8

commit ed2af8b429def7ee0de3d62efe1f07e7d61c1ed8
Author: kerrnel <kerrnel@chromium.org>
Date: Thu Apr 20 00:14:47 2017

Display "Restart to update Adobe Flash Player" for Flash updates.

This CL displays the text "Restart to update Adobe Flash Player" in the
system tray when a Flash player update is available.

BUG= 711822 

Review-Url: https://codereview.chromium.org/2816253002
Cr-Commit-Position: refs/heads/master@{#465818}

[modify] https://crrev.com/ed2af8b429def7ee0de3d62efe1f07e7d61c1ed8/ash/ash_strings.grd
[modify] https://crrev.com/ed2af8b429def7ee0de3d62efe1f07e7d61c1ed8/ash/public/interfaces/system_tray.mojom
[modify] https://crrev.com/ed2af8b429def7ee0de3d62efe1f07e7d61c1ed8/ash/public/interfaces/update.mojom
[modify] https://crrev.com/ed2af8b429def7ee0de3d62efe1f07e7d61c1ed8/ash/system/tray/system_tray_controller.cc
[modify] https://crrev.com/ed2af8b429def7ee0de3d62efe1f07e7d61c1ed8/ash/system/tray/system_tray_controller.h
[modify] https://crrev.com/ed2af8b429def7ee0de3d62efe1f07e7d61c1ed8/ash/system/update/tray_update.cc
[modify] https://crrev.com/ed2af8b429def7ee0de3d62efe1f07e7d61c1ed8/ash/system/update/tray_update.h
[modify] https://crrev.com/ed2af8b429def7ee0de3d62efe1f07e7d61c1ed8/ash/system/update/tray_update_unittest.cc
[modify] https://crrev.com/ed2af8b429def7ee0de3d62efe1f07e7d61c1ed8/chrome/browser/ui/ash/system_tray_client.cc

Labels: Merge-Request-59
Project Member

Comment 3 by sheriffbot@chromium.org, May 1 2017

Labels: -Merge-Request-59 Merge-Review-59 Hotlist-Merge-Review
This bug requires manual review: There is .grd file changes and we are only 35 days from stable.
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), gkihumba@(ChromeOS), Abdul Syed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Merge-Review-59 Merge-Approved-59
Approving merge to m59 Chrome OS.
Project Member

Comment 5 by bugdroid1@chromium.org, May 3 2017

Labels: -merge-approved-59 merge-merged-3071
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f72dbe393c389342e52b4a8002bba19c04fa4a5f

commit f72dbe393c389342e52b4a8002bba19c04fa4a5f
Author: Greg Kerr <kerrnel@chromium.org>
Date: Wed May 03 22:16:20 2017

Display "Restart to update Adobe Flash Player" for Flash updates.

This CL displays the text "Restart to update Adobe Flash Player" in the
system tray when a Flash player update is available.

BUG= 711822 

Review-Url: https://codereview.chromium.org/2816253002
Cr-Commit-Position: refs/heads/master@{#465818}
(cherry picked from commit ed2af8b429def7ee0de3d62efe1f07e7d61c1ed8)

Review-Url: https://codereview.chromium.org/2857193003 .
Cr-Commit-Position: refs/branch-heads/3071@{#384}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}

[modify] https://crrev.com/f72dbe393c389342e52b4a8002bba19c04fa4a5f/ash/ash_strings.grd
[modify] https://crrev.com/f72dbe393c389342e52b4a8002bba19c04fa4a5f/ash/public/interfaces/system_tray.mojom
[modify] https://crrev.com/f72dbe393c389342e52b4a8002bba19c04fa4a5f/ash/public/interfaces/update.mojom
[modify] https://crrev.com/f72dbe393c389342e52b4a8002bba19c04fa4a5f/ash/system/tray/system_tray_controller.cc
[modify] https://crrev.com/f72dbe393c389342e52b4a8002bba19c04fa4a5f/ash/system/tray/system_tray_controller.h
[modify] https://crrev.com/f72dbe393c389342e52b4a8002bba19c04fa4a5f/ash/system/update/tray_update.cc
[modify] https://crrev.com/f72dbe393c389342e52b4a8002bba19c04fa4a5f/ash/system/update/tray_update.h
[modify] https://crrev.com/f72dbe393c389342e52b4a8002bba19c04fa4a5f/ash/system/update/tray_update_unittest.cc
[modify] https://crrev.com/f72dbe393c389342e52b4a8002bba19c04fa4a5f/chrome/browser/ui/ash/system_tray_client.cc

Status: Fixed (was: Started)
Status: Verified (was: Fixed)
9460.42.0, 59.0.3071.57

Comment 8 by gkihumba@google.com, Jun 16 2017

Labels: -Hotlist-Merge-Review

Sign in to add a comment