New issue
Advanced search Search tips

Issue 711818 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug-Regression



Sign in to add a comment

chrome://media-internals player collation is broken.

Project Member Reported by dalecur...@chromium.org, Apr 14 2017

Issue description

https://codereview.chromium.org/2712983004 broke this by using a single RendererMediaLog instance for all RenderFrame's, this hoses watch time and log collection for media when there are multiple concurrent players in 
a page. Will add a test for this issue after fixing.
 
Labels: -Type-Bug Type-Bug-Regression
Fix here, https://codereview.chromium.org/2819973002 if we need to roll beta before that can be merged then we could try to revert 8aeee0b5c65d2ea16d2c52839cf80bcf99273555, but it's fairly huge.
Cc: chcunningham@chromium.org
Longer term xhwang@ points out that we should instead have the MediaLog object not be ref-counted and owned by WMPI since it's otherwise confusing.
Project Member

Comment 4 by bugdroid1@chromium.org, Apr 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f4f7b3aad31bbce44c84dd2cdbd2400a90f87d51

commit f4f7b3aad31bbce44c84dd2cdbd2400a90f87d51
Author: dalecurtis <dalecurtis@chromium.org>
Date: Sat Apr 15 01:22:05 2017

Fix incorrect collation of media logs.

http://crrev.com/463025 incorrectly started using a global MediaLog
instance for each RenderFrame. The RendererMediaLog uses an internal
counter for routing and collating player logs, so doing this causes
all logs for a render frame to end up in the same player.

This patch reverts that portion of the change; though it's questionable
if WebEncryptedMediaClientImpl() should actually be given a MediaLog
just for logging RAPPOR entries. Presumably there is another mechanism
that could accomplish this.

BUG= 695264 ,  711818 
TEST=unittest TBD, manually verified cnn.com, internetradio.com each create
a new button entry in chrome://media-internals. Watch time logs are properly
recorded.

Review-Url: https://codereview.chromium.org/2819973002
Cr-Commit-Position: refs/heads/master@{#464844}

[modify] https://crrev.com/f4f7b3aad31bbce44c84dd2cdbd2400a90f87d51/content/renderer/render_frame_impl.cc
[modify] https://crrev.com/f4f7b3aad31bbce44c84dd2cdbd2400a90f87d51/content/renderer/render_frame_impl.h

Labels: Merge-Request-59
Project Member

Comment 6 by sheriffbot@chromium.org, Apr 17 2017

Labels: -Merge-Request-59 Hotlist-Merge-Approved Merge-Approved-59
Your change meets the bar and is auto-approved for M59. Please go ahead and merge the CL to branch 3071 manually. Please contact milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), gkihumba@(ChromeOS), Abdul Syed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 7 by bugdroid1@chromium.org, Apr 17 2017

Labels: -merge-approved-59 merge-merged-3071
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0398002f42e790ba37023328f65fdfd5208feac7

commit 0398002f42e790ba37023328f65fdfd5208feac7
Author: Dale Curtis <dalecurtis@chromium.org>
Date: Mon Apr 17 18:15:53 2017

Merge M59: "Fix incorrect collation of media logs."

http://crrev.com/463025 incorrectly started using a global MediaLog
instance for each RenderFrame. The RendererMediaLog uses an internal
counter for routing and collating player logs, so doing this causes
all logs for a render frame to end up in the same player.

This patch reverts that portion of the change; though it's questionable
if WebEncryptedMediaClientImpl() should actually be given a MediaLog
just for logging RAPPOR entries. Presumably there is another mechanism
that could accomplish this.

BUG= 695264 ,  711818 
TEST=unittest TBD, manually verified cnn.com, internetradio.com each create
a new button entry in chrome://media-internals. Watch time logs are properly
recorded.

Review-Url: https://codereview.chromium.org/2819973002
Cr-Commit-Position: refs/heads/master@{#464844}
(cherry picked from commit f4f7b3aad31bbce44c84dd2cdbd2400a90f87d51)

Review-Url: https://codereview.chromium.org/2827483002 .
Cr-Commit-Position: refs/branch-heads/3071@{#20}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}

[modify] https://crrev.com/0398002f42e790ba37023328f65fdfd5208feac7/content/renderer/render_frame_impl.cc
[modify] https://crrev.com/0398002f42e790ba37023328f65fdfd5208feac7/content/renderer/render_frame_impl.h

Keeping open until I add a test for this; also working on changing the struct to be unique_ptr.
Labels: -Pri-1 -ReleaseBlock-Beta -M-59 M-60 Pri-2
Adjusting labels accordingly.
Project Member

Comment 10 by bugdroid1@chromium.org, Apr 19 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9cddc0b9cd174242d365e9d64615687384b73c89

commit 9cddc0b9cd174242d365e9d64615687384b73c89
Author: dalecurtis <dalecurtis@chromium.org>
Date: Wed Apr 19 21:23:38 2017

Convert MediaLog from being ref counted to owned by WebMediaPlayer.

MediaLog instances are always bound to a specific player, so there's
no reason for having it be ref-counted other than to confuse folk
into thinking it can be reused.

There seems to be no reason why this was ref counted. There were a
couple questionable places, WebSourceBufferImpl and
WebMediaPlayerMSCompositor, but neither is really using the MediaLog
so I either removed it or replaced it with a dummy log.

The RendererFactories are a bit questionable too, but they are owned
by the WebMediaPlayerImpl so should be fine.

BUG= 711818 ,712310
TEST=compiles, nothing crashes, existing tests still pass.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2815303006
Cr-Commit-Position: refs/heads/master@{#465753}

[modify] https://crrev.com/9cddc0b9cd174242d365e9d64615687384b73c89/chromecast/media/cma/decoder/cast_audio_decoder_linux.cc
[modify] https://crrev.com/9cddc0b9cd174242d365e9d64615687384b73c89/chromecast/media/cma/test/frame_segmenter_for_test.cc
[modify] https://crrev.com/9cddc0b9cd174242d365e9d64615687384b73c89/chromecast/media/service/cast_mojo_media_client.cc
[modify] https://crrev.com/9cddc0b9cd174242d365e9d64615687384b73c89/chromecast/media/service/cast_mojo_media_client.h
[modify] https://crrev.com/9cddc0b9cd174242d365e9d64615687384b73c89/content/browser/media/media_internals_unittest.cc
[modify] https://crrev.com/9cddc0b9cd174242d365e9d64615687384b73c89/content/renderer/media/render_media_log.cc
[modify] https://crrev.com/9cddc0b9cd174242d365e9d64615687384b73c89/content/renderer/media/render_media_log.h
[modify] https://crrev.com/9cddc0b9cd174242d365e9d64615687384b73c89/content/renderer/media/render_media_log_unittest.cc
[modify] https://crrev.com/9cddc0b9cd174242d365e9d64615687384b73c89/content/renderer/media/webmediaplayer_ms.cc
[modify] https://crrev.com/9cddc0b9cd174242d365e9d64615687384b73c89/content/renderer/media/webmediaplayer_ms.h
[modify] https://crrev.com/9cddc0b9cd174242d365e9d64615687384b73c89/content/renderer/media/webmediaplayer_ms_compositor.cc
[modify] https://crrev.com/9cddc0b9cd174242d365e9d64615687384b73c89/content/renderer/media/webmediaplayer_ms_compositor.h
[modify] https://crrev.com/9cddc0b9cd174242d365e9d64615687384b73c89/content/renderer/media/webmediaplayer_ms_unittest.cc
[modify] https://crrev.com/9cddc0b9cd174242d365e9d64615687384b73c89/content/renderer/media_capture_from_element/html_audio_element_capturer_source_unittest.cc
[modify] https://crrev.com/9cddc0b9cd174242d365e9d64615687384b73c89/content/renderer/pepper/video_decoder_shim.cc
[modify] https://crrev.com/9cddc0b9cd174242d365e9d64615687384b73c89/content/renderer/render_frame_impl.cc
[modify] https://crrev.com/9cddc0b9cd174242d365e9d64615687384b73c89/media/base/demuxer_perftest.cc
[modify] https://crrev.com/9cddc0b9cd174242d365e9d64615687384b73c89/media/base/media_log.cc
[modify] https://crrev.com/9cddc0b9cd174242d365e9d64615687384b73c89/media/base/media_log.h
[modify] https://crrev.com/9cddc0b9cd174242d365e9d64615687384b73c89/media/base/mock_filters.h
[modify] https://crrev.com/9cddc0b9cd174242d365e9d64615687384b73c89/media/base/mock_media_log.h
[modify] https://crrev.com/9cddc0b9cd174242d365e9d64615687384b73c89/media/base/pipeline_impl.cc
[modify] https://crrev.com/9cddc0b9cd174242d365e9d64615687384b73c89/media/base/pipeline_impl.h
[modify] https://crrev.com/9cddc0b9cd174242d365e9d64615687384b73c89/media/base/pipeline_impl_unittest.cc
[modify] https://crrev.com/9cddc0b9cd174242d365e9d64615687384b73c89/media/base/stream_parser.h
[modify] https://crrev.com/9cddc0b9cd174242d365e9d64615687384b73c89/media/blink/multibuffer_data_source.h
[modify] https://crrev.com/9cddc0b9cd174242d365e9d64615687384b73c89/media/blink/multibuffer_data_source_unittest.cc
[modify] https://crrev.com/9cddc0b9cd174242d365e9d64615687384b73c89/media/blink/watch_time_reporter.cc
[modify] https://crrev.com/9cddc0b9cd174242d365e9d64615687384b73c89/media/blink/watch_time_reporter.h
[modify] https://crrev.com/9cddc0b9cd174242d365e9d64615687384b73c89/media/blink/watch_time_reporter_unittest.cc
[modify] https://crrev.com/9cddc0b9cd174242d365e9d64615687384b73c89/media/blink/webaudiosourceprovider_impl.cc
[modify] https://crrev.com/9cddc0b9cd174242d365e9d64615687384b73c89/media/blink/webaudiosourceprovider_impl.h
[modify] https://crrev.com/9cddc0b9cd174242d365e9d64615687384b73c89/media/blink/webaudiosourceprovider_impl_unittest.cc
[modify] https://crrev.com/9cddc0b9cd174242d365e9d64615687384b73c89/media/blink/webencryptedmediaclient_impl.cc
[modify] https://crrev.com/9cddc0b9cd174242d365e9d64615687384b73c89/media/blink/webencryptedmediaclient_impl.h
[modify] https://crrev.com/9cddc0b9cd174242d365e9d64615687384b73c89/media/blink/webmediaplayer_impl.cc
[modify] https://crrev.com/9cddc0b9cd174242d365e9d64615687384b73c89/media/blink/webmediaplayer_impl.h
[modify] https://crrev.com/9cddc0b9cd174242d365e9d64615687384b73c89/media/blink/webmediaplayer_impl_unittest.cc
[modify] https://crrev.com/9cddc0b9cd174242d365e9d64615687384b73c89/media/blink/webmediaplayer_params.cc
[modify] https://crrev.com/9cddc0b9cd174242d365e9d64615687384b73c89/media/blink/webmediaplayer_params.h
[modify] https://crrev.com/9cddc0b9cd174242d365e9d64615687384b73c89/media/blink/webmediaplayer_util.cc
[modify] https://crrev.com/9cddc0b9cd174242d365e9d64615687384b73c89/media/blink/webmediaplayer_util.h
[modify] https://crrev.com/9cddc0b9cd174242d365e9d64615687384b73c89/media/blink/webmediasource_impl.cc
[modify] https://crrev.com/9cddc0b9cd174242d365e9d64615687384b73c89/media/blink/webmediasource_impl.h
[modify] https://crrev.com/9cddc0b9cd174242d365e9d64615687384b73c89/media/cast/sender/h264_vt_encoder_unittest.cc
[modify] https://crrev.com/9cddc0b9cd174242d365e9d64615687384b73c89/media/filters/audio_decoder_selector_unittest.cc
[modify] https://crrev.com/9cddc0b9cd174242d365e9d64615687384b73c89/media/filters/audio_decoder_unittest.cc
[modify] https://crrev.com/9cddc0b9cd174242d365e9d64615687384b73c89/media/filters/audio_timestamp_validator.cc
[modify] https://crrev.com/9cddc0b9cd174242d365e9d64615687384b73c89/media/filters/audio_timestamp_validator.h
[modify] https://crrev.com/9cddc0b9cd174242d365e9d64615687384b73c89/media/filters/audio_timestamp_validator_unittest.cc
[modify] https://crrev.com/9cddc0b9cd174242d365e9d64615687384b73c89/media/filters/chunk_demuxer.cc
[modify] https://crrev.com/9cddc0b9cd174242d365e9d64615687384b73c89/media/filters/chunk_demuxer.h
[modify] https://crrev.com/9cddc0b9cd174242d365e9d64615687384b73c89/media/filters/chunk_demuxer_unittest.cc
[modify] https://crrev.com/9cddc0b9cd174242d365e9d64615687384b73c89/media/filters/decoder_selector.cc
[modify] https://crrev.com/9cddc0b9cd174242d365e9d64615687384b73c89/media/filters/decoder_selector.h
[modify] https://crrev.com/9cddc0b9cd174242d365e9d64615687384b73c89/media/filters/decoder_stream.cc
[modify] https://crrev.com/9cddc0b9cd174242d365e9d64615687384b73c89/media/filters/decoder_stream.h
[modify] https://crrev.com/9cddc0b9cd174242d365e9d64615687384b73c89/media/filters/decoder_stream_traits.cc
[modify] https://crrev.com/9cddc0b9cd174242d365e9d64615687384b73c89/media/filters/decoder_stream_traits.h
[modify] https://crrev.com/9cddc0b9cd174242d365e9d64615687384b73c89/media/filters/decrypting_audio_decoder.cc
[modify] https://crrev.com/9cddc0b9cd174242d365e9d64615687384b73c89/media/filters/decrypting_audio_decoder.h
[modify] https://crrev.com/9cddc0b9cd174242d365e9d64615687384b73c89/media/filters/decrypting_audio_decoder_unittest.cc
[modify] https://crrev.com/9cddc0b9cd174242d365e9d64615687384b73c89/media/filters/decrypting_demuxer_stream.cc
[modify] https://crrev.com/9cddc0b9cd174242d365e9d64615687384b73c89/media/filters/decrypting_demuxer_stream.h
[modify] https://crrev.com/9cddc0b9cd174242d365e9d64615687384b73c89/media/filters/decrypting_demuxer_stream_unittest.cc
[modify] https://crrev.com/9cddc0b9cd174242d365e9d64615687384b73c89/media/filters/decrypting_video_decoder.cc
[modify] https://crrev.com/9cddc0b9cd174242d365e9d64615687384b73c89/media/filters/decrypting_video_decoder.h
[modify] https://crrev.com/9cddc0b9cd174242d365e9d64615687384b73c89/media/filters/decrypting_video_decoder_unittest.cc
[modify] https://crrev.com/9cddc0b9cd174242d365e9d64615687384b73c89/media/filters/ffmpeg_audio_decoder.cc
[modify] https://crrev.com/9cddc0b9cd174242d365e9d64615687384b73c89/media/filters/ffmpeg_audio_decoder.h
[modify] https://crrev.com/9cddc0b9cd174242d365e9d64615687384b73c89/media/filters/ffmpeg_demuxer.cc
[modify] https://crrev.com/9cddc0b9cd174242d365e9d64615687384b73c89/media/filters/ffmpeg_demuxer.h
[modify] https://crrev.com/9cddc0b9cd174242d365e9d64615687384b73c89/media/filters/ffmpeg_demuxer_unittest.cc
[modify] https://crrev.com/9cddc0b9cd174242d365e9d64615687384b73c89/media/filters/ffmpeg_video_decoder.cc
[modify] https://crrev.com/9cddc0b9cd174242d365e9d64615687384b73c89/media/filters/ffmpeg_video_decoder.h
[modify] https://crrev.com/9cddc0b9cd174242d365e9d64615687384b73c89/media/filters/ffmpeg_video_decoder_unittest.cc
[modify] https://crrev.com/9cddc0b9cd174242d365e9d64615687384b73c89/media/filters/frame_processor.cc
[modify] https://crrev.com/9cddc0b9cd174242d365e9d64615687384b73c89/media/filters/frame_processor.h
[modify] https://crrev.com/9cddc0b9cd174242d365e9d64615687384b73c89/media/filters/frame_processor_unittest.cc
[modify] https://crrev.com/9cddc0b9cd174242d365e9d64615687384b73c89/media/filters/gpu_video_decoder.cc
[modify] https://crrev.com/9cddc0b9cd174242d365e9d64615687384b73c89/media/filters/gpu_video_decoder.h
[modify] https://crrev.com/9cddc0b9cd174242d365e9d64615687384b73c89/media/filters/source_buffer_state.cc
[modify] https://crrev.com/9cddc0b9cd174242d365e9d64615687384b73c89/media/filters/source_buffer_state.h
[modify] https://crrev.com/9cddc0b9cd174242d365e9d64615687384b73c89/media/filters/source_buffer_state_unittest.cc
[modify] https://crrev.com/9cddc0b9cd174242d365e9d64615687384b73c89/media/filters/source_buffer_stream.cc
[modify] https://crrev.com/9cddc0b9cd174242d365e9d64615687384b73c89/media/filters/source_buffer_stream.h
[modify] https://crrev.com/9cddc0b9cd174242d365e9d64615687384b73c89/media/filters/source_buffer_stream_unittest.cc
[modify] https://crrev.com/9cddc0b9cd174242d365e9d64615687384b73c89/media/filters/stream_parser_factory.cc
[modify] https://crrev.com/9cddc0b9cd174242d365e9d64615687384b73c89/media/filters/stream_parser_factory.h
[modify] https://crrev.com/9cddc0b9cd174242d365e9d64615687384b73c89/media/filters/video_decoder_selector_unittest.cc
[modify] https://crrev.com/9cddc0b9cd174242d365e9d64615687384b73c89/media/filters/video_frame_stream_unittest.cc
[modify] https://crrev.com/9cddc0b9cd174242d365e9d64615687384b73c89/media/filters/video_renderer_algorithm.cc
[modify] https://crrev.com/9cddc0b9cd174242d365e9d64615687384b73c89/media/filters/video_renderer_algorithm.h
[modify] https://crrev.com/9cddc0b9cd174242d365e9d64615687384b73c89/media/filters/video_renderer_algorithm_unittest.cc
[modify] https://crrev.com/9cddc0b9cd174242d365e9d64615687384b73c89/media/formats/common/stream_parser_test_base.cc
[modify] https://crrev.com/9cddc0b9cd174242d365e9d64615687384b73c89/media/formats/common/stream_parser_test_base.h
[modify] https://crrev.com/9cddc0b9cd174242d365e9d64615687384b73c89/media/formats/mp2t/es_parser_mpeg1audio.cc
[modify] https://crrev.com/9cddc0b9cd174242d365e9d64615687384b73c89/media/formats/mp2t/es_parser_mpeg1audio.h
[modify] https://crrev.com/9cddc0b9cd174242d365e9d64615687384b73c89/media/formats/mp2t/es_parser_mpeg1audio_unittest.cc
[modify] https://crrev.com/9cddc0b9cd174242d365e9d64615687384b73c89/media/formats/mp2t/mp2t_stream_parser.cc
[modify] https://crrev.com/9cddc0b9cd174242d365e9d64615687384b73c89/media/formats/mp2t/mp2t_stream_parser.h
[modify] https://crrev.com/9cddc0b9cd174242d365e9d64615687384b73c89/media/formats/mp2t/mp2t_stream_parser_unittest.cc
[modify] https://crrev.com/9cddc0b9cd174242d365e9d64615687384b73c89/media/formats/mp4/aac.cc
[modify] https://crrev.com/9cddc0b9cd174242d365e9d64615687384b73c89/media/formats/mp4/aac.h
[modify] https://crrev.com/9cddc0b9cd174242d365e9d64615687384b73c89/media/formats/mp4/aac_unittest.cc
[modify] https://crrev.com/9cddc0b9cd174242d365e9d64615687384b73c89/media/formats/mp4/box_definitions.cc
[modify] https://crrev.com/9cddc0b9cd174242d365e9d64615687384b73c89/media/formats/mp4/box_definitions.h
[modify] https://crrev.com/9cddc0b9cd174242d365e9d64615687384b73c89/media/formats/mp4/box_reader.cc
[modify] https://crrev.com/9cddc0b9cd174242d365e9d64615687384b73c89/media/formats/mp4/box_reader.h
[modify] https://crrev.com/9cddc0b9cd174242d365e9d64615687384b73c89/media/formats/mp4/box_reader_unittest.cc
[modify] https://crrev.com/9cddc0b9cd174242d365e9d64615687384b73c89/media/formats/mp4/dolby_vision.cc
[modify] https://crrev.com/9cddc0b9cd174242d365e9d64615687384b73c89/media/formats/mp4/dolby_vision.h
[modify] https://crrev.com/9cddc0b9cd174242d365e9d64615687384b73c89/media/formats/mp4/dolby_vision_unittest.cc
[modify] https://crrev.com/9cddc0b9cd174242d365e9d64615687384b73c89/media/formats/mp4/hevc.cc
[modify] https://crrev.com/9cddc0b9cd174242d365e9d64615687384b73c89/media/formats/mp4/hevc.h
[modify] https://crrev.com/9cddc0b9cd174242d365e9d64615687384b73c89/media/formats/mp4/mp4_stream_parser.cc
[modify] https://crrev.com/9cddc0b9cd174242d365e9d64615687384b73c89/media/formats/mp4/mp4_stream_parser.h
[modify] https://crrev.com/9cddc0b9cd174242d365e9d64615687384b73c89/media/formats/mp4/mp4_stream_parser_unittest.cc
[modify] https://crrev.com/9cddc0b9cd174242d365e9d64615687384b73c89/media/formats/mp4/track_run_iterator.cc
[modify] https://crrev.com/9cddc0b9cd174242d365e9d64615687384b73c89/media/formats/mp4/track_run_iterator.h
[modify] https://crrev.com/9cddc0b9cd174242d365e9d64615687384b73c89/media/formats/mp4/track_run_iterator_unittest.cc
[modify] https://crrev.com/9cddc0b9cd174242d365e9d64615687384b73c89/media/formats/mpeg/mpeg1_audio_stream_parser.cc
[modify] https://crrev.com/9cddc0b9cd174242d365e9d64615687384b73c89/media/formats/mpeg/mpeg1_audio_stream_parser.h
[modify] https://crrev.com/9cddc0b9cd174242d365e9d64615687384b73c89/media/formats/mpeg/mpeg_audio_stream_parser_base.cc
[modify] https://crrev.com/9cddc0b9cd174242d365e9d64615687384b73c89/media/formats/mpeg/mpeg_audio_stream_parser_base.h
[modify] https://crrev.com/9cddc0b9cd174242d365e9d64615687384b73c89/media/formats/webm/webm_audio_client.cc
[modify] https://crrev.com/9cddc0b9cd174242d365e9d64615687384b73c89/media/formats/webm/webm_audio_client.h
[modify] https://crrev.com/9cddc0b9cd174242d365e9d64615687384b73c89/media/formats/webm/webm_cluster_parser.cc
[modify] https://crrev.com/9cddc0b9cd174242d365e9d64615687384b73c89/media/formats/webm/webm_cluster_parser.h
[modify] https://crrev.com/9cddc0b9cd174242d365e9d64615687384b73c89/media/formats/webm/webm_cluster_parser_unittest.cc
[modify] https://crrev.com/9cddc0b9cd174242d365e9d64615687384b73c89/media/formats/webm/webm_content_encodings_client.cc
[modify] https://crrev.com/9cddc0b9cd174242d365e9d64615687384b73c89/media/formats/webm/webm_content_encodings_client.h
[modify] https://crrev.com/9cddc0b9cd174242d365e9d64615687384b73c89/media/formats/webm/webm_content_encodings_client_unittest.cc
[modify] https://crrev.com/9cddc0b9cd174242d365e9d64615687384b73c89/media/formats/webm/webm_stream_parser.cc
[modify] https://crrev.com/9cddc0b9cd174242d365e9d64615687384b73c89/media/formats/webm/webm_stream_parser.h
[modify] https://crrev.com/9cddc0b9cd174242d365e9d64615687384b73c89/media/formats/webm/webm_stream_parser_unittest.cc
[modify] https://crrev.com/9cddc0b9cd174242d365e9d64615687384b73c89/media/formats/webm/webm_tracks_parser.cc
[modify] https://crrev.com/9cddc0b9cd174242d365e9d64615687384b73c89/media/formats/webm/webm_tracks_parser.h
[modify] https://crrev.com/9cddc0b9cd174242d365e9d64615687384b73c89/media/formats/webm/webm_tracks_parser_unittest.cc
[modify] https://crrev.com/9cddc0b9cd174242d365e9d64615687384b73c89/media/formats/webm/webm_video_client.cc
[modify] https://crrev.com/9cddc0b9cd174242d365e9d64615687384b73c89/media/formats/webm/webm_video_client.h
[modify] https://crrev.com/9cddc0b9cd174242d365e9d64615687384b73c89/media/gpu/video_encode_accelerator_unittest.cc
[modify] https://crrev.com/9cddc0b9cd174242d365e9d64615687384b73c89/media/mojo/services/interface_factory_impl.cc
[modify] https://crrev.com/9cddc0b9cd174242d365e9d64615687384b73c89/media/mojo/services/interface_factory_impl.h
[modify] https://crrev.com/9cddc0b9cd174242d365e9d64615687384b73c89/media/mojo/services/media_service.cc
[modify] https://crrev.com/9cddc0b9cd174242d365e9d64615687384b73c89/media/mojo/services/media_service.h
[modify] https://crrev.com/9cddc0b9cd174242d365e9d64615687384b73c89/media/mojo/services/mojo_media_client.cc
[modify] https://crrev.com/9cddc0b9cd174242d365e9d64615687384b73c89/media/mojo/services/mojo_media_client.h
[modify] https://crrev.com/9cddc0b9cd174242d365e9d64615687384b73c89/media/mojo/services/test_mojo_media_client.cc
[modify] https://crrev.com/9cddc0b9cd174242d365e9d64615687384b73c89/media/mojo/services/test_mojo_media_client.h
[modify] https://crrev.com/9cddc0b9cd174242d365e9d64615687384b73c89/media/renderers/audio_renderer_impl.cc
[modify] https://crrev.com/9cddc0b9cd174242d365e9d64615687384b73c89/media/renderers/audio_renderer_impl.h
[modify] https://crrev.com/9cddc0b9cd174242d365e9d64615687384b73c89/media/renderers/audio_renderer_impl_unittest.cc
[modify] https://crrev.com/9cddc0b9cd174242d365e9d64615687384b73c89/media/renderers/default_renderer_factory.cc
[modify] https://crrev.com/9cddc0b9cd174242d365e9d64615687384b73c89/media/renderers/default_renderer_factory.h
[modify] https://crrev.com/9cddc0b9cd174242d365e9d64615687384b73c89/media/renderers/video_renderer_impl.cc
[modify] https://crrev.com/9cddc0b9cd174242d365e9d64615687384b73c89/media/renderers/video_renderer_impl.h
[modify] https://crrev.com/9cddc0b9cd174242d365e9d64615687384b73c89/media/renderers/video_renderer_impl_unittest.cc
[modify] https://crrev.com/9cddc0b9cd174242d365e9d64615687384b73c89/media/test/pipeline_integration_test.cc
[modify] https://crrev.com/9cddc0b9cd174242d365e9d64615687384b73c89/media/test/pipeline_integration_test_base.cc
[modify] https://crrev.com/9cddc0b9cd174242d365e9d64615687384b73c89/media/test/pipeline_integration_test_base.h
[modify] https://crrev.com/9cddc0b9cd174242d365e9d64615687384b73c89/testing/libfuzzer/fuzzers/es_parser_mpeg1audio_fuzzer.cc
[modify] https://crrev.com/9cddc0b9cd174242d365e9d64615687384b73c89/testing/libfuzzer/fuzzers/mp4_box_reader_fuzzer.cc

Status: Fixed (was: Started)

Sign in to add a comment