New issue
Advanced search Search tips

Issue 711817 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Jun 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

Allow dragging items down from the overflow shelf to the main shelf.

Project Member Reported by sammiequon@chromium.org, Apr 14 2017

Issue description

Shelf currently only supports ripping items off when you move a certain amount of pixels above the shelf. If you want to move between shelfs (main and overflow), you'll need to go up and down. If your overflow shelf is rather large, you have pull up drag around, down and back across. If the overflow shelf is long enough, you will not be able to move items from the overflow shelf to the main shelf.

Suggestion: Allow ripping off down onto the main shelf, and up onto the overflow shelf.
 
omri, zach, what do you think?
Cc: sgabr...@chromium.org shibasheikh@chromium.org
Labels: OS-Chrome
I think it's a great idea, and we should do that as part of our work for enabling folders in shelf. We then can also allow dragging between folders, shelf, and overview

Isn't that already covered in bug 710228 ?
Re #3. You can drag items from shelf to shelf, but you have to drag up first then drag down. (ie. You want to move something from overflow from shelf, you have to drag the item up 50 px then drag it down) This proposes you can skip the drag up 50px step.
Got it. I didn't know this we had to drag 50px up then drag it down.
Status: Assigned (was: Untriaged)
Project Member

Comment 7 by bugdroid1@chromium.org, Jun 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bbd450e340cae1277f2f907226735cb7154270b3

commit bbd450e340cae1277f2f907226735cb7154270b3
Author: sammiequon <sammiequon@chromium.org>
Date: Tue Jun 06 22:16:16 2017

shelf: Allow directly dragging items from main shelf to overflow.

Previously we would have to drag the item up off the main shelf and then down onto the overflow shelf. This would cause extra difficutly if the items were vertically aligned. Also allows dragging items from the overflow down onto the main shelf.

TEST=ash_unittest --gtest_filter="ShelfViewTest.*"
BUG= 711817 

Review-Url: https://codereview.chromium.org/2916983002
Cr-Commit-Position: refs/heads/master@{#477432}

[modify] https://crrev.com/bbd450e340cae1277f2f907226735cb7154270b3/ash/shelf/shelf_view.cc
[modify] https://crrev.com/bbd450e340cae1277f2f907226735cb7154270b3/ash/shelf/shelf_view_unittest.cc

Status: Fixed (was: Assigned)
Status: Verified (was: Fixed)
9656.0.0, 61.0.3132.0

Sign in to add a comment