New issue
Advanced search Search tips

Issue 711789 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug-Regression
Proj-XR

Blocking:
issue 719079



Sign in to add a comment

Under Neon Lights WebVR experiment is just black after beginning presentation

Project Member Reported by meganlindsay@chromium.org, Apr 14 2017

Issue description

https://with.in/watch/under-neon-lights/

Chrome Canary 59.0.3071.3

Select Enter VR, go through DON flow
DD UI (settings button, x to exit) is present, but content is simply black and does not recover.

Happens perhaps 1/3 or 1/4 times on Canary. When it does not occur the entire experience works fine. Have not reproed on stable so far.
 
No repro in Beta either.
Owner: klausw@chromium.org
Status: Started (was: Available)
Project Member

Comment 3 by bugdroid1@chromium.org, Apr 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/262e77a72493e36e8006aeeba1c7497a42ee5ad9

commit 262e77a72493e36e8006aeeba1c7497a42ee5ad9
Author: klausw <klausw@chromium.org>
Date: Fri Apr 28 22:52:47 2017

WebVR: fix initial vsync

Applications sometimes use window.rAF while not presenting, then switch to
vrDisplay.rAF after presentation starts. Depending on the animation loop's
timing, this can cause a race condition where presentation has been started
but there's no vrDisplay.rAF pending yet. Ensure there's at least vsync
being processed after presentation starts so that a queued window.rAF
can run and schedule a vrDisplay.rAF.

BUG= 711789 

Review-Url: https://codereview.chromium.org/2848483003
Cr-Commit-Position: refs/heads/master@{#468167}

[modify] https://crrev.com/262e77a72493e36e8006aeeba1c7497a42ee5ad9/third_party/WebKit/Source/modules/vr/VRDisplay.cpp
[modify] https://crrev.com/262e77a72493e36e8006aeeba1c7497a42ee5ad9/third_party/WebKit/Source/modules/vr/VRDisplay.h

Labels: Merge-Request-59
Project Member

Comment 5 by sheriffbot@chromium.org, May 1 2017

Labels: -Merge-Request-59 Hotlist-Merge-Approved Merge-Approved-59
Your change meets the bar and is auto-approved for M59. Please go ahead and merge the CL to branch 3071 manually. Please contact milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), gkihumba@(ChromeOS), Abdul Syed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Cc: bajones@chromium.org
Is this behavior something that should be spec'd? @bajones.
Still waiting on tests for this.
We will test it on Canary and see if it works. 
(I meant that Klaus needs to write a layout test for this)
Glad to know we will add automated test for it, so we don't need to do manual testing for it.

It will be nice if Klaus can add layout tests before it is merged back to M59, so we don't need to do manual testing for it for M59 beta release.
I just tested on 60.0.3087.0 and did see the black screen issue. A couple times I got some error msg saying "Incompatible app This cardboard application is not compatible with Daydream headsets". But also, a few times it worked.
Project Member

Comment 12 by sheriffbot@chromium.org, May 5 2017

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 13 by sheriffbot@chromium.org, May 8 2017

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Blocking: 719079
Labels: -Merge-Approved-59 Merge-Merged
Patch merged as 83bc6712b5b740815f9b24dd10934656683cd5de from crrev.com/2867813002, the bug didn't get auto-updated:

https://chromium.googlesource.com/chromium/src.git/+log/branch-heads/3071

WebVR: fix initial vsync

Applications sometimes use window.rAF while not presenting, then switch to
vrDisplay.rAF after presentation starts. Depending on the animation loop's
timing, this can cause a race condition where presentation has been started
but there's no vrDisplay.rAF pending yet. Ensure there's at least vsync
being processed after presentation starts so that a queued window.rAF
can run and schedule a vrDisplay.rAF.

BUG= 711789 
NOTRY=true
NOPRESUBMIT=true

Review-Url: https://codereview.chromium.org/2848483003
Cr-Commit-Position: refs/heads/master@{#468167}
(cherry picked from commit 262e77a72493e36e8006aeeba1c7497a42ee5ad9)

Review-Url: https://codereview.chromium.org/2867813002
Cr-Commit-Position: refs/branch-heads/3071@{#454}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}
Ping, still waiting on the tests that should have been landed with the original CL.
Klaus, can you let us know if this is resolved?  Or, if we should downgrade from P1?
Owner: cjgrant@chromium.org
Based on bug age, temporarily claiming this to investigate and either close or update issue status.
Owner: klausw@chromium.org
Status: Fixed (was: Started)
This bug was open to address the addition of tests.  There were two things to cover:

1.  rAF issue.  Testing was added in this CL:
https://codereview.chromium.org/2888313002 

2.  Cardboard click - this is no longer a thing.  See:
https://developers.google.com/web/updates/2017/09/webvr-origin-trial-chrome-62

Therefore, closing this off, and setting ownership to Klaus as he added the testing.

Components: Blink>WebXR

Sign in to add a comment