New issue
Advanced search Search tips

Issue 711781 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug



Sign in to add a comment

Media.DetectedContainer has a high unknown container rate.

Project Member Reported by dalecur...@chromium.org, Apr 14 2017

Issue description

There were a few bugs that have been fixed, but we are still seeing high rates of unknown containers. This is a bucket bug for work to improve the unknown rate.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/32a6c13991b642c992f9879bb808c527bc6dc278

commit 32a6c13991b642c992f9879bb808c527bc6dc278
Author: dalecurtis <dalecurtis@chromium.org>
Date: Mon Apr 17 20:32:08 2017

Only run container name detection upon ffmpeg parse failure.

If ffmpeg thinks it can demux the file, we should defer to its result
instead of trying to compute our own. This avoids any unnecessary delay
in playback of supported formats by only running our checks if ffmpeg
indicates it can't demux the content.

BUG= 711781 
TEST=new unittests

Review-Url: https://codereview.chromium.org/2819863003
Cr-Commit-Position: refs/heads/master@{#465003}

[modify] https://crrev.com/32a6c13991b642c992f9879bb808c527bc6dc278/media/base/container_names.cc
[modify] https://crrev.com/32a6c13991b642c992f9879bb808c527bc6dc278/media/base/container_names.h
[modify] https://crrev.com/32a6c13991b642c992f9879bb808c527bc6dc278/media/filters/ffmpeg_glue.cc
[modify] https://crrev.com/32a6c13991b642c992f9879bb808c527bc6dc278/media/filters/ffmpeg_glue_unittest.cc
[add] https://crrev.com/32a6c13991b642c992f9879bb808c527bc6dc278/media/test/data/bear.amr

Since M59 went stable (end of May) the unknown container rate has dropped to less than 5% (was 45-50% since the end of March). Since this looks reasonable, marking this as fixed.
Status: Fixed (was: Assigned)
Unknown containers started dropping after M58 release. Latest results (7-Nov) are 1.7%, been below 5% since M60 shipped.

Sign in to add a comment