Randomly missed extension icons in app list recent view. |
||||||||||
Issue descriptionRepro: 1. It is recommended to have many apps previously installed. 2. Login first time to account on Chromebook. 3. Open App List view (recent page) 4. Observe that apps are automatically installed and recent view is constantly updated. 5. At some point it possible to have empty icon for random apps (some apps has higher repro rate) 6. Problem persists even if to reopen App List or if item goes out from recent and then comes to recent again. On restart problem disappears. PS. 3a - It is possible to open All Apps and then go back to App list recent to increase repro rate.
,
Apr 16 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/37568714f8eba4d6ff7eaf2257e1a785a80753e6 commit 37568714f8eba4d6ff7eaf2257e1a785a80753e6 Author: khmel <khmel@chromium.org> Date: Sun Apr 16 03:36:12 2017 Fix randomly disappearing icons in app list recent view. This fixes race condition when extension is installed. BUG= 711779 TEST=Manually on device. No flikering and no disappearing icons detected. Review-Url: https://codereview.chromium.org/2817293002 Cr-Commit-Position: refs/heads/master@{#464879} [modify] https://crrev.com/37568714f8eba4d6ff7eaf2257e1a785a80753e6/chrome/browser/ui/app_list/search/extension_app_result.cc [modify] https://crrev.com/37568714f8eba4d6ff7eaf2257e1a785a80753e6/chrome/browser/ui/app_list/search/extension_app_result.h [modify] https://crrev.com/37568714f8eba4d6ff7eaf2257e1a785a80753e6/extensions/browser/extension_icon_image.h
,
Apr 18 2017
,
Apr 18 2017
This bug requires manual review: We are only 6 days from stable. Please contact the milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), bhthompson@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Apr 18 2017
Merge approved for 58.
,
Apr 18 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/116c88cc867c94b284d999e7c7379687cc11c314 commit 116c88cc867c94b284d999e7c7379687cc11c314 Author: khmel <khmel@chromium.org> Date: Tue Apr 18 23:18:52 2017 [Merge M58] Fix randomly disappearing icons in app list recent view. This fixes race condition when extension is installed. BUG= 711779 TEST=Manually on device. No flikering and no disappearing icons detected. TBR=xiyuan@chromium.org,rdevlin.cronin@chromium.org NOTRY=true NOPRESUBMIT=true Review-Url: https://codereview.chromium.org/2817293002 Cr-Commit-Position: refs/heads/master@{#464879} (cherry picked from commit 37568714f8eba4d6ff7eaf2257e1a785a80753e6) Review-Url: https://codereview.chromium.org/2830453002 Cr-Commit-Position: refs/branch-heads/3029@{#748} Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471} [modify] https://crrev.com/116c88cc867c94b284d999e7c7379687cc11c314/chrome/browser/ui/app_list/search/extension_app_result.cc [modify] https://crrev.com/116c88cc867c94b284d999e7c7379687cc11c314/chrome/browser/ui/app_list/search/extension_app_result.h [modify] https://crrev.com/116c88cc867c94b284d999e7c7379687cc11c314/extensions/browser/extension_icon_image.h
,
Apr 21 2017
Issue 707300 has been merged into this issue.
,
Apr 21 2017
khmel@, could you merge the CL in #2 to M59 as well ? Thanks.
,
Apr 25 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3ca909385869bfc356be71fad51f7daff87b308d commit 3ca909385869bfc356be71fad51f7daff87b308d Author: khmel <khmel@chromium.org> Date: Tue Apr 25 16:45:27 2017 [Merge M59] Fig randomly disappearing icons in app list recent view. This fixes race condition when extension is installed. BUG= 711779 TEST=Manually on device. No flikering and no disappearing icons detected. TBR=xiyuan@chromium.org,rdevlin.cronin@chromium.org NOTRY=true NOPRESUBMIT=true Review-Url: https://codereview.chromium.org/2817293002 Cr-Commit-Position: refs/heads/master@{#464879} (cherry picked from commit 37568714f8eba4d6ff7eaf2257e1a785a80753e6) Review-Url: https://codereview.chromium.org/2833673004 Cr-Commit-Position: refs/branch-heads/3071@{#200} Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641} [modify] https://crrev.com/3ca909385869bfc356be71fad51f7daff87b308d/chrome/browser/ui/app_list/search/extension_app_result.cc [modify] https://crrev.com/3ca909385869bfc356be71fad51f7daff87b308d/chrome/browser/ui/app_list/search/extension_app_result.h [modify] https://crrev.com/3ca909385869bfc356be71fad51f7daff87b308d/extensions/browser/extension_icon_image.h
,
Apr 25 2017
Sorry, forgot pending merge in codereview. Now is merged to M59
,
Jan 22 2018
|
||||||||||
►
Sign in to add a comment |
||||||||||
Comment 1 by khmel@chromium.org
, Apr 14 20171.4 MB
1.4 MB View Download