New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 711775 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Apr 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

The GIT_USER_AGENT set on the bots breaks github.com server

Project Member Reported by sbc@chromium.org, Apr 14 2017

Issue description

If GIT_USER_AGENT doesn't start with git/X.Y.Z github won't                      
recognise the request as coming from git and URLs that don't                     
end in ".git" can't be cloned or fetched from.                          
                                               

 

Comment 1 by sbc@chromium.org, Apr 14 2017

Perhaps this (and the other GIT environment variables) should be set in the git wrapper (infra/go/src/infra/tools/git/git.go) instead?
Project Member

Comment 2 by bugdroid1@chromium.org, Apr 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/aade5e09de449238f20a138c89afe5bddbb45429

commit aade5e09de449238f20a138c89afe5bddbb45429
Author: Sam Clegg <sbc@chromium.org>
Date: Tue Apr 18 16:42:22 2017

Fix GIT_USER_AGENT to be compatible with github

In GIT_USER_AGENT doesn't start with git/X.Y.Z github won't
recognise the request as coming from git and URLs that don't
end in ".git" can't be cloned or fetched from.

Bug:  711775 
Change-Id: Idc569aa3f0d4f9a3d26ee3a11b66c55aa368ef71
Reviewed-on: https://chromium-review.googlesource.com/478511
Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>
Reviewed-by: Elliott Friedman <friedman@chromium.org>
Reviewed-by: Sergey Berezin <sergeyberezin@chromium.org>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Sam Clegg <sbc@chromium.org>

[modify] https://crrev.com/aade5e09de449238f20a138c89afe5bddbb45429/slave/run_slave.py

Project Member

Comment 3 by bugdroid1@chromium.org, Apr 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/aade5e09de449238f20a138c89afe5bddbb45429

commit aade5e09de449238f20a138c89afe5bddbb45429
Author: Sam Clegg <sbc@chromium.org>
Date: Tue Apr 18 16:42:22 2017

Fix GIT_USER_AGENT to be compatible with github

In GIT_USER_AGENT doesn't start with git/X.Y.Z github won't
recognise the request as coming from git and URLs that don't
end in ".git" can't be cloned or fetched from.

Bug:  711775 
Change-Id: Idc569aa3f0d4f9a3d26ee3a11b66c55aa368ef71
Reviewed-on: https://chromium-review.googlesource.com/478511
Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>
Reviewed-by: Elliott Friedman <friedman@chromium.org>
Reviewed-by: Sergey Berezin <sergeyberezin@chromium.org>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Sam Clegg <sbc@chromium.org>

[modify] https://crrev.com/aade5e09de449238f20a138c89afe5bddbb45429/slave/run_slave.py

Comment 4 by sbc@chromium.org, Apr 24 2017

Status: Fixed (was: Assigned)

Sign in to add a comment