Remove support for GSM container (not the codec). |
|||||||
Issue descriptionThe GSM container is essentially raw file without any identifying data; per our own statistics (using the same code as ffmpeg), we have a detection rate of ~0.00000091% over a 7 day period, which is low enough to just be misdetection. We also have zero detection on ChromeOS which is the only platform we support decoding on. All of our test cases use GSM in a 3gp or wav file, so I think we can safely remove this. This just amounts to removing gsm from the list of demuxers in build_ffmpeg.py with the ffmpeg roll for M60. There's almost no code savings, so it's mostly just a reduction of cruft. Sample file attached, when trying to play it in ffmpeg you get the following: [gsm @ 0x1f323a0] Format gsm detected only with low score of 1, misdetection possible! It's using the extension to make this detection, attempting to open an in-memory stream using avformat_open_input() fails, so I suspect this has never worked in Chrome. Likewise our ContainerNames code is unable to identify this file either.
,
Jun 12 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/74dc7cd2aea5383ac8f1360a790cd7e5ee865999 commit 74dc7cd2aea5383ac8f1360a790cd7e5ee865999 Author: John Rummell <jrummell@chromium.org> Date: Mon Jun 12 23:48:36 2017 Remove GSM from the list of FFmpeg formats checked Now that FFmpeg is no longer configured to check for GSM containers, there is no need to look for it in the FFmpeg context. BUG= 711774 TEST=media_unittests still pass (although there was no specific test for GSM) Change-Id: I3d34010097be177554c31ac083341fbfee0a7cc9 Reviewed-on: https://chromium-review.googlesource.com/530164 Reviewed-by: Dale Curtis <dalecurtis@chromium.org> Commit-Queue: John Rummell <jrummell@chromium.org> Cr-Commit-Position: refs/heads/master@{#478823} [modify] https://crrev.com/74dc7cd2aea5383ac8f1360a790cd7e5ee865999/media/filters/ffmpeg_glue.cc
,
Aug 26 2017
,
Jan 22 2018
|
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by bugdroid1@chromium.org
, Jun 6 2017