New issue
Advanced search Search tips

Issue 711773 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug



Sign in to add a comment

KeyboardEvent.repeat always returns false (Linux only)

Project Member Reported by jsb...@chromium.org, Apr 14 2017

Issue description

Sample:

<script>
document.body.innerHTML = '<input>';
document.querySelector('input')
  .addEventListener('keydown', e => console.log(e.key, e.repeat));
</script>

Expected: 

logs false then true for repeat when a key is held down

Actual:

Always logs false

Repros in 57 and tip-of-tree on Linux (ubuntu, desktop, not remoting or anything fancy like that)

Works fine in ChromeOS 57 and Mac 57.

 
Labels: -Pri-3 Hotlist-Input-Dev Pri-2
Owner: dtapu...@chromium.org
Status: Started (was: Untriaged)
Review posted here: https://codereview.chromium.org/2825343002/
Project Member

Comment 3 by bugdroid1@chromium.org, Apr 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0386ada9ad68b6a562fda8bddd979cf902b87486

commit 0386ada9ad68b6a562fda8bddd979cf902b87486
Author: dtapuska <dtapuska@chromium.org>
Date: Fri Apr 21 14:53:20 2017

Fix key repeat on linux.

Events posted from ibus would not get detected as repeating. This caused
issues for web content that relied upon the KeyboardEvent.repeat
javascript attribute. Store the detection of repeated events from ibus
in a separate static variable than the evdev channel.

BUG= 711773 

Review-Url: https://codereview.chromium.org/2825343002
Cr-Commit-Position: refs/heads/master@{#466332}

[modify] https://crrev.com/0386ada9ad68b6a562fda8bddd979cf902b87486/ui/events/event.cc
[modify] https://crrev.com/0386ada9ad68b6a562fda8bddd979cf902b87486/ui/events/event.h

Status: Fixed (was: Started)

Sign in to add a comment