New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 711745 link

Starred by 3 users

Issue metadata

Status: Duplicate
Merged: issue 710028
Owner:
Last visit 15 days ago
Closed: Apr 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: ----
Type: Bug


Previous locations:
gerrit:5931


Sign in to add a comment

Multiple identical email notifications on patch set updated

Project Member Reported by awdf@chromium.org, Apr 4 2017

Issue description

Affected Version: 2.13.7-3495-gcf7af33d57

What steps will reproduce the problem?
1. Upload a new code review with 'git cl upload --gerrit'
2. Make some changes
3. Upload an updated patch set with 'git cl upload'

What is the expected output?
One email notification at most


What do you see instead?

Between 4-7 identical email notifications, my reviewer gets them too. See screenshot.

 
duplicated_emails.png
117 KB View Download

Comment 1 by awdf@chromium.org, Apr 4 2017

the code review in question is at https://chromium-review.googlesource.com/c/466306

Comment 2 by wyatta@google.com, Apr 4 2017

Looking at 466306 there are 4-7 mailing lists CC'd on the change. I wonder if each of those is receiving a separate message.
Labels: -Priority-3 Milestone-Chromium-Launch Priority-1
Owner: hie...@google.com
Status: Accepted (was: New)
That's the theory. I've asked awdf to attach a screenshot of the To: lines of the emails to see if that's visible there.

Adding hiesel@ and bumping priority and milestone.

Comment 4 by awdf@chromium.org, Apr 4 2017

And here are the recipients of some of those emails received at 15:43 - see screenshot
to-lines.png
139 KB View Download

Comment 5 by awdf@chromium.org, Apr 4 2017

(seems to be the same set of recipients just in a different order)
Yep. One other question: are you subscribed to ntp-dev@, feature-media-reviews@, and/or sync-reviews@?

We certainly shouldn't be sending multiple emails to each recipient. If we are, that needs to be fixed asap. But there's also a reasonable chance that we're only sending one email, but you're receiving it up to five times via five different routes:
1) to you as the uploader
2) to you as awdf+watch@
3) to you via sync-reviews@
4) to you via ntp-dev+reviews@
5) to you via feature-media-reviews@

Comment 7 by awdf@chromium.org, Apr 4 2017

I don't think I am subscribed to any of those three (how would I tell for sure?)
I thought this is the same problem as gerrit 2.13? But that was fixed in https://gerrit-review.googlesource.com/#/c/99178/ but never added in master since they are planning on doing the fix a different way for 2.14+.
I think https://bugs.chromium.org/p/gerrit/issues/detail?id=5956 is proibably the same issue as this but since this hasn't happened to me directly I can't confirm.

awdf: you can tell if you're subscribed by visiting the Google Groups page for the group (e.g. https://groups.google.com/a/chromium.org/forum/#!forum/sync-reviews) and seeing if it says you're subscribed.

Comment 10 by awdf@chromium.org, Apr 7 2017

Can confirm I am not a member of sync-reviews, ntp-dev, or feature-media-reviews mailing lists.

Comment 11 by hie...@google.com, Apr 11 2017

I've added a test case to Gerrit to check the scenario you described, but I need to look further as those tests went as expected (only one email sent out in each case): https://gerrit-review.googlesource.com/c/103252/

Did the duplicate emails you got all have the same message ID?

Comment 12 by awdf@chromium.org, Apr 11 2017

How do I tell what message ID the emails have?

I don't think I'm the only one with code reviews affected by this issue.

Searching my inbox for 'gerrit' brought up these two reviews with 48 and 63 emails respectively, many of them identical:
https://chromium-review.googlesource.com/472428
https://chromium-review.googlesource.com/472548

(emails sent to my awdf+watch@chromium.org account since I'm watching areas they changed)

Comment 13 by hie...@google.com, Apr 13 2017

Cc: logan@google.com
Status: AwaitingInformation (was: Accepted)
Thanks for linking those changes.

This problem originates in how the chromium client adds CCs. Instead of adding them as a batch in one operation, they are added individually over several minutes. This is what generates these emails.

This problem is tracked in  Issue 710028 .

Logan, could you please move this to chromium and mark it is a duplicate of 710028? I am lacking permissions to do so.

Comment 14 by wyatta@google.com, Apr 14 2017

Project: chromium
Moved issue gerrit:5931 to now be  issue chromium:711745 .

Comment 15 by wyatta@google.com, Apr 14 2017

Mergedinto: 710028
Status: Duplicate (was: AwaitingInformation)

Sign in to add a comment