needless WARNING:bluetooth_low_energy_weave_client_connection logspam in test output |
|||
Issue descriptionhttps://chromium-swarm.appspot.com/task?id=358656c245528810&refresh=10&show_raw=1 29552:29552:0414/103502.259600:7977706890:INFO:bluetooth_low_energy_weave_client_connection.cc(128)] Connecting in 0 s [29552:29552:0414/103502.259688:7977706979:INFO:bluetooth_low_energy_weave_client_connection.cc(152)] Creating GATT connection with AA:BB:CC:DD:EE:FF [29552:29552:0414/103502.259952:7977707240:INFO:bluetooth_low_energy_weave_client_connection.cc(340)] GATT connection with AA:BB:CC:DD:EE:FF created. [29552:29552:0414/103502.260043:7977707337:INFO:bluetooth_low_energy_weave_client_connection.cc(583)] Time elapsed: 0.00034 s [29552:29552:0414/103502.260227:7977707515:INFO:bluetooth_low_energy_weave_client_connection.cc(373)] Remote chacteristics found. [29552:29552:0414/103502.260305:7977707592:INFO:bluetooth_low_energy_weave_client_connection.cc(583)] Time elapsed: 0.000613 s [29552:29552:0414/103502.260568:7977707859:INFO:bluetooth_low_energy_weave_client_connection.cc(432)] Notification session started TX characteristic id [29552:29552:0414/103502.260653:7977707940:INFO:bluetooth_low_energy_weave_client_connection.cc(583)] Time elapsed: 0.000959 s [29552:29552:0414/103502.260722:7977708026:INFO:bluetooth_low_energy_weave_client_connection.cc(458)] Sending connection request to the server [29552:29552:0414/103502.260853:7977708140:INFO:bluetooth_low_energy_weave_client_connection.cc(482)] Writing to characteristic 1 bytes [29552:29552:0414/103502.260964:7977708252:INFO:bluetooth_low_energy_weave_client_connection.cc(496)] Characteristic written. [29552:29552:0414/103502.261107:7977708399:INFO:bluetooth_low_energy_weave_client_connection.cc(285)] Characteristic value changed: f4b904a2-a030-43b3-98a8-221c536c03cb [29552:29552:0414/103502.261193:7977708481:INFO:bluetooth_low_energy_weave_client_connection.cc(291)] Receiver State: 1 [29552:29552:0414/103502.261271:7977708557:INFO:bluetooth_low_energy_weave_client_connection.cc(323)] Connection completed. Time elapsed: 0.001579 s [29552:29552:0414/103502.261414:7977708702:INFO:bluetooth_low_energy_weave_client_connection.cc(225)] Sending message testFeature,bb [29552:29552:0414/103502.261531:7977708821:INFO:bluetooth_low_energy_weave_client_connection.cc(482)] Writing to characteristic 3 bytes [29552:29552:0414/103502.261663:7977708951:WARNING:bluetooth_low_energy_weave_client_connection.cc(524)] Error 0 writing characteristic: 977c6674-1239-4e72-993b-502369b8bb5a [29552:29552:0414/103502.261771:7977709058:INFO:bluetooth_low_energy_weave_client_connection.cc(482)] Writing to characteristic 3 bytes [29552:29552:0414/103502.261884:7977709171:WARNING:bluetooth_low_energy_weave_client_connection.cc(524)] Error 0 writing characteristic: 977c6674-1239-4e72-993b-502369b8bb5a [29552:29552:0414/103502.261973:7977709259:INFO:bluetooth_low_energy_weave_client_connection.cc(482)] Writing to characteristic 3 bytes [29552:29552:0414/103502.262076:7977709362:WARNING:bluetooth_low_energy_weave_client_connection.cc(524)] Error 0 writing characteristic: 977c6674-1239-4e72-993b-502369b8bb5a [29552:29552:0414/103502.262187:7977709474:INFO:bluetooth_low_energy_weave_client_connection.cc(190)] Disconnect from device AA:BB:CC:DD:EE:FF None of that is interesting. Code shouldn't log by default. jingxuy@ apparently doesn't have bug permissions, so assigning to a randomly-picked reviewer.
,
Apr 19 2017
Can we just delete the LOG line?
,
Apr 19 2017
I would not like to remove the logs for now. We are currently debugging the feature, and these logs are very useful to us. I think we should just figure out why a PA_LOG(INFO) is being logged as a WARNING.
,
Apr 19 2017
According to the logs, they are being logged as INFO. I'm in favour of keeping these logs because: 1. They are only logged when we connect over BLE for MagicTether/EasyUnlock, which is a very rare event. 2. These logs are very useful, as they let us see exactly what is going on during such a connection. Without these logs, we would essentially just see a failed connection without understanding why.
,
Apr 19 2017
That seems a bit, under-defined. What does 'most' logging calls? Does that mean vmodule calls are also not okay? I was planning on suggesting that instead of polluting INFO, we instead use VMODULE to further restrict this logging - but then the quoted section would apply against that too. I am not in favor of removing important logging based on a rather vague clause in our style guide.
,
Apr 19 2017
It's not (always) important logging, it prints on 100% of test runs. In those test runs, this logging carries 0 bits of data.
,
Apr 19 2017
Ah, I should have paid more attention. In tests, yes, this is useless logging. Kyle, I believe PA_LOG has some functionality to not log during tests. Could you investigate using that so that these logs don't show up in tests?
,
Apr 19 2017
(or assign to whoever took over ownership of jingxuy@'s code)
,
Apr 19 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b55e4c29cbe6a07d9e75a386933342cbd80e5cd9 commit b55e4c29cbe6a07d9e75a386933342cbd80e5cd9 Author: khorimoto <khorimoto@chromium.org> Date: Wed Apr 19 23:06:32 2017 Disable logging in CryptAuthBluetoothLowEnergyWeaveClientConnectionTest. It was too spammy. BUG= 711741 Review-Url: https://codereview.chromium.org/2829793002 Cr-Commit-Position: refs/heads/master@{#465803} [modify] https://crrev.com/b55e4c29cbe6a07d9e75a386933342cbd80e5cd9/components/cryptauth/ble/BUILD.gn [modify] https://crrev.com/b55e4c29cbe6a07d9e75a386933342cbd80e5cd9/components/cryptauth/ble/bluetooth_low_energy_weave_client_connection_unittest.cc
,
Apr 19 2017
|
|||
►
Sign in to add a comment |
|||
Comment 1 by khorimoto@chromium.org
, Apr 18 2017