New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 711737 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS , Mac
Pri: 2
Type: Bug



Sign in to add a comment

Clang-format binds : tighter than @selector's ( in .mm files

Project Member Reported by spqc...@chromium.org, Apr 14 2017

Issue description

clang-format produced code that (choose all that apply):
+ Doesn't match Chromium style

Here's the code before formatting:
if ([application respondsToSelector:
    @selector(setAutomaticCustomizeTouchBarMenuItemEnabled:)]) {
  [application setAutomaticCustomizeTouchBarMenuItemEnabled:YES];
}

Here's the code after formatting:
if ([application respondsToSelector:@selector
                 (setAutomaticCustomizeTouchBarMenuItemEnabled:)]) {
  [application setAutomaticCustomizeTouchBarMenuItemEnabled:YES];
}

Here's how it ought to look:
if ([application respondsToSelector:
    @selector(setAutomaticCustomizeTouchBarMenuItemEnabled:)]) {
  [application setAutomaticCustomizeTouchBarMenuItemEnabled:YES];
}


Code review link for full files/context:https://codereview.chromium.org/2814683005

 
Summary: Clang-format quality problem (was: Clang-format quality proble)

Comment 2 by thakis@chromium.org, Apr 14 2017

Labels: clang-format OS-iOS OS-Mac
Summary: Clang-format binds : tighter than @selector's ( in .mm files (was: Clang-format quality problem)
Components: Infra

Comment 4 by s...@google.com, Apr 15 2017

Components: -Infra Tools

Sign in to add a comment