Add use counters for impact of making filter a containing block for all descendants |
|||||||||
Issue description.
,
Apr 15 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e208bf05c117cf2fa0f7aab01a779d47fd92b8ef commit e208bf05c117cf2fa0f7aab01a779d47fd92b8ef Author: chrishtr <chrishtr@chromium.org> Date: Sat Apr 15 02:50:11 2017 Add a use-counter for viewport-fixed position:fixed under a filter This will inform whether we can make the change suggested in https://github.com/w3c/fxtf-drafts/issues/11 BUG= 711736 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2817583006 Cr-Commit-Position: refs/heads/master@{#464853} [modify] https://crrev.com/e208bf05c117cf2fa0f7aab01a779d47fd92b8ef/third_party/WebKit/Source/core/frame/UseCounter.h [modify] https://crrev.com/e208bf05c117cf2fa0f7aab01a779d47fd92b8ef/third_party/WebKit/Source/core/layout/compositing/CompositingInputsUpdater.cpp [modify] https://crrev.com/e208bf05c117cf2fa0f7aab01a779d47fd92b8ef/tools/metrics/histograms/histograms.xml
,
Apr 15 2017
,
Apr 16 2017
Your change meets the bar and is auto-approved for M59. Please go ahead and merge the CL to branch 3071 manually. Please contact milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), gkihumba@(ChromeOS), Abdul Syed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Apr 17 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/13bf399cb6cfe09f5492834f07b1bd6bf8d0ae44 commit 13bf399cb6cfe09f5492834f07b1bd6bf8d0ae44 Author: Chris Harrelson <chrishtr@chromium.org> Date: Mon Apr 17 16:02:21 2017 Add a use-counter for viewport-fixed position:fixed under a filter This will inform whether we can make the change suggested in https://github.com/w3c/fxtf-drafts/issues/11 BUG= 711736 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2817583006 Cr-Commit-Position: refs/heads/master@{#464853} (cherry picked from commit e208bf05c117cf2fa0f7aab01a779d47fd92b8ef) Review-Url: https://codereview.chromium.org/2821943002 . Cr-Commit-Position: refs/branch-heads/3071@{#14} Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641} [modify] https://crrev.com/13bf399cb6cfe09f5492834f07b1bd6bf8d0ae44/third_party/WebKit/Source/core/frame/UseCounter.h [modify] https://crrev.com/13bf399cb6cfe09f5492834f07b1bd6bf8d0ae44/third_party/WebKit/Source/core/layout/compositing/CompositingInputsUpdater.cpp [modify] https://crrev.com/13bf399cb6cfe09f5492834f07b1bd6bf8d0ae44/tools/metrics/histograms/histograms.xml
,
Sep 11 2017
Even just viewport position-fixed under filter is 0.006%: https://www.chromestatus.com/metrics/feature/popularity#ViewportFixedPositionUnderFilter
,
Sep 11 2017
,
Dec 16 2017
,
Dec 21 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d35b3dbaf9b11af8fe30ae37098b5381635b8d37 commit d35b3dbaf9b11af8fe30ae37098b5381635b8d37 Author: Chris Harrelson <chrishtr@chromium.org> Date: Thu Dec 21 03:30:22 2017 Revert obsolete use counter. It's obsolete because the CSSWG resolved to fix ths issue by special-casing the root element. See https://github.com/w3c/fxtf-drafts/issues/11 TBR=trchen Bug: 711736 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: Ie17644b5d8d2fd8f34e97ee0803b26854ef0150d Reviewed-on: https://chromium-review.googlesource.com/831399 Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Reviewed-by: Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#525581} [modify] https://crrev.com/d35b3dbaf9b11af8fe30ae37098b5381635b8d37/third_party/WebKit/Source/core/paint/compositing/CompositingInputsUpdater.cpp [modify] https://crrev.com/d35b3dbaf9b11af8fe30ae37098b5381635b8d37/tools/metrics/histograms/enums.xml
,
Dec 22 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e96adae779e8d76411afede4fe4a36fcb943e15e commit e96adae779e8d76411afede4fe4a36fcb943e15e Author: Chris Harrelson <chrishtr@chromium.org> Date: Fri Dec 22 01:50:52 2017 Add a use counter for impact of making filter a containing block for all content. TBR=trchen Bug: 711736 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I9f3aa6516181ad49eaa7a714fa8487316ed1b0a5 Reviewed-on: https://chromium-review.googlesource.com/661637 Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Reviewed-by: Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#525893} [modify] https://crrev.com/e96adae779e8d76411afede4fe4a36fcb943e15e/third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.cpp [modify] https://crrev.com/e96adae779e8d76411afede4fe4a36fcb943e15e/third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.h [modify] https://crrev.com/e96adae779e8d76411afede4fe4a36fcb943e15e/third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilderTest.cpp [modify] https://crrev.com/e96adae779e8d76411afede4fe4a36fcb943e15e/third_party/WebKit/public/platform/web_feature.mojom [modify] https://crrev.com/e96adae779e8d76411afede4fe4a36fcb943e15e/tools/metrics/histograms/enums.xml
,
Jan 5 2018
Current use counters are showing about 0.01%-0.05% on the various Canary channels.
,
Jan 18 2018
Latest use counter shows closer to 0.1% on dev channel. Measured by dividing FilterAsContainingBlockMayChangeOutput by PageVisits on the Blink.UseCounter.Features histogram. Next step is to wait for the beta channel and check results there.
,
Apr 23 2018
,
Aug 10
|
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by schenney@chromium.org
, Apr 14 2017