New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 711727 link

Starred by 1 user

Issue metadata

Status: Duplicate
Merged: issue 706128
Owner:
Last visit 29 days ago
Closed: Apr 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug-Regression



Sign in to add a comment

Expanding objects in console scrolls to bottom

Reported by jpl0...@gmail.com, Apr 14 2017

Issue description

UserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_11_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/57.0.2987.98 Safari/537.36

Steps to reproduce the problem:
1. Ensure there is a bunch of console logs (so that scroll bars appear).
2. Scroll up and expand an object by clicking on it.

What is the expected behavior?
The object is expanded and scroll position does not change.

What went wrong?
Scroll position is moved to the very bottom. You must scroll all the way back up to see your expanded object. This is not convenient.

Did this work before? Yes 57.0.2987.98 (64-bit)

Chrome version: 59.0.3071.0 canary (64-bit)  Channel: n/a
OS Version: OS X 10.11.6
Flash Version:
 

Comment 1 by ajha@chromium.org, Apr 17 2017

Labels: Needs-Triage-M59 Needs-Bisect
Cc: sureshkumari@chromium.org
Labels: Needs-Feedback
jpl0531@ could you please provide a sample Html test file to triage the issue further.

Thanks.

Comment 3 by woxxom@gmail.com, Apr 17 2017

Yes, this is very annoying!

Repro:
	1. open devtools console, run the next code: Array(100).fill(0).map((e,i) => i)
	2. click the output to expand it, make sure the bottom part of the output is hidden 
	3. click on a visible part of the output

	EXPECTED: scroll position is unchanged
	OBSERVED: console is scrolled to the bottom of the output

Bisect:
	460465 (good) - 460475 (bad)
	https://chromium.googlesource.com/chromium/src/+log/c8cf9f23..624dc15f?pretty=fuller

Culprit:
	r460469 "DevTools: Roll CodeMirror to 5.25.1"

Debugging in devtools-for-devtools shows:
* [old] CodeMirror checked whether CodeMirror instance is focused prior to scrolling the window:
	if (op.scrollToPos.isCursor && cm.state.focused) maybeScrollWindow(cm, coords);
* [new] CodeMirror 5.25.1 doesn't:
	maybeScrollWindow(cm, rect)

[old]: https://codereview.chromium.org/2772343006/diff/20001/third_party/WebKit/Source/devtools/front_end/cm/codemirror.js#oldcode3179
[new]: https://codereview.chromium.org/2772343006/diff/20001/third_party/WebKit/Source/devtools/front_end/cm/codemirror.js#newcode3817

Comment 4 by woxxom@gmail.com, Apr 17 2017

Already reported and fixed in https://github.com/codemirror/CodeMirror/issues/4657

Comment 5 by caseq@chromium.org, Apr 18 2017

Cc: l...@chromium.org
Components: -Platform>DevTools Platform>DevTools>Authoring
Owner: lushnikov@chromium.org
Status: Assigned (was: Unconfirmed)
Over to lushnikov@ per #3.

Comment 6 by l...@chromium.org, Apr 18 2017

Labels: -Needs-Feedback -Needs-Bisect
Mergedinto: 706128
Status: Duplicate (was: Assigned)

Sign in to add a comment